Re: [sword-devel] Patches to fix compiler warnings

2013-01-28 Thread Troy A. Griffitts
Jaak, I've partially applied this patch: sword-Wunused-parameter-fix.diff.bz2 I agree that we should safely suppress the warnings in headers for empty virtual methods. These are the hunks I applied. The other warnings in the cpp files should be looked at individually to determine why the

Re: [sword-devel] Patches to fix compiler warnings

2013-01-26 Thread Troy A. Griffitts
Jaak, Just getting to these sets of patches. sword-comparison-not-assignment-fix.diff.bz2 Applied. Thanks for finding this bug. On 12/21/2012 12:32 AM, Jaak Ristioja wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello! Please apply these patches (bzip2-ed to workaround sword-dev

Re: [sword-devel] Patches to fix compiler warnings

2013-01-20 Thread Jaak Ristioja
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi! Is there any progress regarding the patches I sent? A month has passed since I submitted them and there has been no feedback. Blessings Jaak On 03.01.2013 23:11, Jaak Ristioja wrote: > On 02.01.2013 09:22, Nic Carter wrote: >> Thanks for these.

Re: [sword-devel] Patches to fix compiler warnings

2013-01-03 Thread Jaak Ristioja
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02.01.2013 09:22, Nic Carter wrote: > Thanks for these. > > Hopefully some kind soul will apply them? When I first posted the patches I thought I'll wait until 2013 before taking any further steps. But it has been a very busy time for me and possi

Re: [sword-devel] Patches to fix compiler warnings

2013-01-01 Thread Nic Carter
Thanks for these. Hopefully some kind soul will apply them? For those who are interested, some fun articles related to this stuff: * http://inessential.com/2012/12/31/coders_in_the_hands_of_an_angry_god * http://boredzo.org/blog/archives/2009-11-07/warnings * (more appropriate to Obj-C) http:/

Re: [sword-devel] Patches to fix compiler warnings

2012-12-20 Thread Jaak Ristioja
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 As Troy mentioned in an earlier post (and also pointed out to me in private), the Sword team doesn't count all such warnings as errors. It is true that most of them are not strictly errors but related to safe programming style. However, there are othe

[sword-devel] Patches to fix compiler warnings

2012-12-20 Thread Jaak Ristioja
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello! Please apply these patches (bzip2-ed to workaround sword-devel 90 KB message size limit and attached) to fix about 3000 compiler warnings with GCC and Clang. The patches should apply to https://crosswire.org/svn/sword/trunk@2751 Blessings, Ja