Thanks, this is in now as r3245 in SVN.
--Greg
On Tue, Jul 15, 2014 at 9:32 AM, Jaak Ristioja wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Sry, the original patch had some tabs vs spaces issue, I think. Here's
> the correct one for 1.7.3.
>
> On 15.07.2014 10:41, Jaak Ristioja
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Sry, the original patch had some tabs vs spaces issue, I think. Here's
the correct one for 1.7.3.
On 15.07.2014 10:41, Jaak Ristioja wrote:
> No. As I repeatedly have tried to say, I'm not qualified. Bug the
> author of the code. My patch (which I'm
On Mon, Jul 14, 2014 at 09:26:48PM -0500, Greg Hellings wrote:
> I intend on maintaining 1.7 up you're ready to release and branch 1.8.
>
> As others have noted, I've tried to apply this patch to the 1.7 series
> branch but the patch does not apply. One hunk applies with fuzz 2, the
> other does n
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
No. As I repeatedly have tried to say, I'm not qualified. Bug the
author of the code. My patch (which I'm still not convinced is
correct) only applied to 1.7.3.
Blessings,
Jaak
On 15.07.2014 05:26, Greg Hellings wrote:
> I intend on maintaining 1.7
I intend on maintaining 1.7 up you're ready to release and branch 1.8.
As others have noted, I've tried to apply this patch to the 1.7 series
branch but the patch does not apply. One hunk applies with fuzz 2, the
other does not apply. Jaak - any chance of getting a patch that applies?
--Greg
On
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
So, I assume someone my patch has been reviewed. Personally I'm not
entirely sure whether I got the { and } right.
Blessings,
Jaak
On 13.07.2014 05:09, Troy A. Griffitts wrote:
> Isaac, Thanks for checking and confirming that trunk has been
> fixed.
Isaac, Thanks for checking and confirming that trunk has been fixed.
Greg, It seems quite reasonable to applying Jaak's patch to the 1.7
branch if we intend on releasing a 1.7.4. I mention this, as this is an
exception to the rule that all patches are first applied to trunk and
then merged
On Sat, Jul 12, 2014 at 10:59:19AM -0700, Troy A. Griffitts wrote:
> Dear Jaak,
>
> Thank you so much for looking into this. I went to review your patch and it
> doesn't apply cleanly to trunk. Have you confirmed that this problem still
> exists in trunk? If so, might you consider sending a pat
For what it's worth, it didn't apply against 1.7.3 for me;
the offsets are off by a line or two.
(However, looking at the context was enough to fix it.)
Now I'll try building from VCS to check it (side note: any reason that
jsword is in git but there's still nothing at github.com/crosswire/sword?)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Yes, that code has changed a lot since 1.7.3. I have not confirmed
whether the issue still exists in trunk, but 1.7.3 is surely affected
by this. I suggest someone more familiar with the code to confirm that.
Blessings,
Jaak
On 12.07.2014 20:59, Troy
Dear Jaak,
Thank you so much for looking into this. I went to review your patch
and it doesn't apply cleanly to trunk. Have you confirmed that this
problem still exists in trunk? If so, might you consider sending a
patch against trunk? Thank you!
Troy
On 07/10/2014 01:34 AM, Jaak Rist
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
This seems to be a really silly indentation error in Sword 1.7.3. At
least the attached patch fixed the problem in my Alpine Linux VM for
"diatheke -b KJV -k Ps117". Might already be fixed in SVN.
Can any Sword developers confirm this bug and fix?
Bl
Hello,
I took a look at what it was doing via strace(1), and found that diatheke
is reading the last verse twice.
I still wouldn't know where the problem could come from, though.
Thank you and God bless,
Isaac Dunham
___
sword-devel mailing list: sword-
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Yes, the full version might be helpful. Please send it.
God bless!
Jaak
On 10.07.2014 07:36, Isaac Dunham wrote:
> On Tue, Jul 08, 2014 at 05:33:54PM +0300, Jaak Ristioja wrote:
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>>
>> Looking at cored
On Tue, Jul 08, 2014 at 05:33:54PM +0300, Jaak Ristioja wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Looking at corediatheke.cpp this is probably a bug which could be
> found using valgrind. Please try the following command with sword+musl:
>
> valgrind --leak-check=full --track
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Looking at corediatheke.cpp this is probably a bug which could be
found using valgrind. Please try the following command with sword+musl:
valgrind --leak-check=full --track-origins=yes
- --keep-stacktraces=alloc-and-free utils\diatheke -b KJV -k Ps1
On Tue, Jul 08, 2014 at 02:00:32AM -0700, David Haslam wrote:
> FWIW, this did not occur with diatheke.exe in Windows (Win7).
>
> utils\diatheke -b KJV -k Ps117
> Psalms 117:1: O praise the LORD, all ye nations: praise him, all ye people.
> Psalms 117:2: For his merciful kindness is great toward u
FWIW, this did not occur with diatheke.exe in Windows (Win7).
utils\diatheke -b KJV -k Ps117
Psalms 117:1: O praise the LORD, all ye nations: praise him, all ye people.
Psalms 117:2: For his merciful kindness is great toward us: and the truth of
the
LORD endureth for ever. Praise ye the LORD.
(KJ
Hello,
I've been trying to package Sword for Alpine Linux (alpinelinux.org),
which uses an alternate libc.
Relevant packages and versions are as follows:
libc: musl 1.1.3
gcc: 4.8.2
clucene: 2.3.3.4
icu: 53.1
sword: 1.7.3
So far, Sword builds fine, and installmgr works with a minor bug
that I thi
19 matches
Mail list logo