Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-22 Thread Jordi Boggiano
On 22.10.2010 11:31, Lukas Kahwe Smith wrote: >>> Please, don't do that. We had that in symfony1 and let's not do the same >>> errors again. >> >> I think it may be ok to have a one-liner solution as long as it's still >> very easy to expand it to a full fledged hand-crafted form definition >> (whi

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-22 Thread Lukas Kahwe Smith
On 22.10.2010, at 11:28, Jordi Boggiano wrote: > On 22.10.2010 10:54, Fabien Potencier wrote: >>> and once we have that .. we might think about how to easily add a >>> submit button to a form inside a template and then rendering a form >>> could become a one or two liner .. >> >> Please, don't d

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-22 Thread Jordi Boggiano
On 22.10.2010 10:54, Fabien Potencier wrote: >> and once we have that .. we might think about how to easily add a >> submit button to a form inside a template and then rendering a form >> could become a one or two liner .. > > Please, don't do that. We had that in symfony1 and let's not do the sam

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-22 Thread Fabien Potencier
On 10/22/10 10:33 AM, Lukas Kahwe Smith wrote: On 22.10.2010, at 10:08, Jordi Boggiano wrote: On 21.10.2010 19:36, Lukas Kahwe Smith wrote: Finally I wonder if we should have something to render a tag: It could be interesting as something like: {% form formVar get|post 'doctrine_user_ses

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-22 Thread Lukas Kahwe Smith
On 22.10.2010, at 10:08, Jordi Boggiano wrote: > On 21.10.2010 19:36, Lukas Kahwe Smith wrote: >> Finally I wonder if we should have something to render a tag: >> > form|render_enctype } method="POST" class="doctrine_user_session_new"> > > It could be interesting as something like: > > {% form

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-22 Thread Fabien Potencier
On 10/21/10 7:36 PM, Lukas Kahwe Smith wrote: On 20.10.2010, at 17:08, Thibault D wrote: Yeah I know (and agree) Twig is the default for Bundles. It was not the case when we wrote DoctrineUserBundle and ForumBundle, that's the reason why templates are in PHP. Any contribution to translate them

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-22 Thread Jordi Boggiano
On 21.10.2010 19:36, Lukas Kahwe Smith wrote: > Finally I wonder if we should have something to render a tag: > form|render_enctype } method="POST" class="doctrine_user_session_new"> It could be interesting as something like: {% form formVar get|post 'doctrine_user_session_create' with ['routep

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-21 Thread Lukas Kahwe Smith
On 20.10.2010, at 17:08, Thibault D wrote: > Yeah I know (and agree) Twig is the default for Bundles. It was not > the case when we wrote DoctrineUserBundle and ForumBundle, that's the > reason why templates are in PHP. > Any contribution to translate them to Twig is welcome :) with the two pul

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Lukas Kahwe Smith
On 20.10.2010, at 17:33, Thibault D wrote: > If you need a variable in your layout, you may consider writing a > template helper for it. If it's a menu, MenuBundle provides an easy > way to create a helper for your menu (http://github.com/knplabs/ > MenuBundle/blob/master/Resources/doc/02-Integra

[symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Thibault D
If you need a variable in your layout, you may consider writing a template helper for it. If it's a menu, MenuBundle provides an easy way to create a helper for your menu (http://github.com/knplabs/ MenuBundle/blob/master/Resources/doc/02-Integrate-With- Symfony.markdown) On Oct 20, 5:11 pm, Lukas

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Lukas Kahwe Smith
On 20.10.2010, at 17:08, Thibault D wrote: > Yeah I know (and agree) Twig is the default for Bundles. It was not > the case when we wrote DoctrineUserBundle and ForumBundle, that's the > reason why templates are in PHP. > Any contribution to translate them to Twig is welcome :) ok great! now i

[symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Thibault D
Yeah I know (and agree) Twig is the default for Bundles. It was not the case when we wrote DoctrineUserBundle and ForumBundle, that's the reason why templates are in PHP. Any contribution to translate them to Twig is welcome :) On Oct 20, 3:50 pm, Lukas Kahwe Smith wrote: > On 20.10.2010, at 15:4

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Lukas Kahwe Smith
On 20.10.2010, at 15:47, Fabien Potencier wrote: > > On 10/20/10 3:24 PM, Lukas Kahwe Smith wrote: >> >> On 20.10.2010, at 15:19, Thibault D wrote: >> >>> From what I know about template/CSS writers, we always need custom >>> HTML. Defaults are never good enough, even for small HTML parts like

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Fabien Potencier
On 10/20/10 3:24 PM, Lukas Kahwe Smith wrote: On 20.10.2010, at 15:19, Thibault D wrote: From what I know about template/CSS writers, we always need custom HTML. Defaults are never good enough, even for small HTML parts like the login form element. In my current bundles, templates are just e

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Jordi Boggiano
On 20.10.2010 15:39, Lukas Kahwe Smith wrote: > actually in the controllers they have already made this configurable ..: > return > $this->render('DoctrineUserBundle:Session:new.'.$this->getRenderer(), array( > 'form' => $this['templating.form']->get($form) Oh well, ok great,

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Lukas Kahwe Smith
On 20.10.2010, at 15:32, Jordi Boggiano wrote: > On 20.10.2010 15:24, Lukas Kahwe Smith wrote: >>> In my current bundles, templates are just examples, designed to be >>> completely overwritten at application level. >>> >>> We could provide more granular partials to make small parts reusable, >>>

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Jordi Boggiano
On 20.10.2010 15:24, Lukas Kahwe Smith wrote: >> In my current bundles, templates are just examples, designed to be >> completely overwritten at application level. >> >> We could provide more granular partials to make small parts reusable, >> yes. For some bundles it may make sense. > > yeah .. li

Re: [symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Lukas Kahwe Smith
On 20.10.2010, at 15:19, Thibault D wrote: > From what I know about template/CSS writers, we always need custom > HTML. Defaults are never good enough, even for small HTML parts like > the login form element. > In my current bundles, templates are just examples, designed to be > completely overwr

[symfony-devs] Re: Improving integration of 3rd party Bundles

2010-10-20 Thread Thibault D
>From what I know about template/CSS writers, we always need custom HTML. Defaults are never good enough, even for small HTML parts like the login form element. In my current bundles, templates are just examples, designed to be completely overwritten at application level. We could provide more gra