[symfony-users] Re: Doctrine admin : sorting and filtering are done before table_method makes joined tables available for query building

2009-01-14 Thread jukea
Jon, I sumbmitted a patch to the ticket, which passed all tests included with sfDoctrinePlugin. see it here : http://trac.symfony-project.org/ticket/5586 Julien On Jan 13, 2:53 pm, Jonathan Wage wrote: > You can run the tests included with the sfDoctrinePlugin in the test folder. > > - Jon >

[symfony-users] Re: Doctrine admin : sorting and filtering are done before table_method makes joined tables available for query building

2009-01-13 Thread Jonathan Wage
You can run the tests included with the sfDoctrinePlugin in the test folder. - Jon On Tue, Jan 13, 2009 at 1:45 PM, jukea wrote: > > Also , if I patch the admin code templates, is there any test I should > code, before submitting a patch ? I found none for the generated > admins > > Julien > >

[symfony-users] Re: Doctrine admin : sorting and filtering are done before table_method makes joined tables available for query building

2009-01-13 Thread jukea
Also , if I patch the admin code templates, is there any test I should code, before submitting a patch ? I found none for the generated admins Julien On Jan 13, 2:29 pm, jukea wrote: > Jon, > > I think the filter forms should get passed the table_method with a > setTableMethod, if any, in the s

[symfony-users] Re: Doctrine admin : sorting and filtering are done before table_method makes joined tables available for query building

2009-01-13 Thread jukea
Jon, I think the filter forms should get passed the table_method with a setTableMethod, if any, in the same way the pager does. eg : $filterForm->setTableMethod() if there's no filter, then we'd still need to do it before the sorting criteria is added: $query=Doctrine::getTable('getModelC

[symfony-users] Re: Doctrine admin : sorting and filtering are done before table_method makes joined tables available for query building

2009-01-13 Thread Jonathan Wage
Could we just change it so table_method is done first? - Jon On Tue, Jan 13, 2009 at 12:48 PM, jukea wrote: > > Just to add more information on that matter : > > For the sorting feature to work, what I did was move the use of the > table_method just before the sorting part is added (directly in

[symfony-users] Re: Doctrine admin : sorting and filtering are done before table_method makes joined tables available for query building

2009-01-13 Thread jukea
Just to add more information on that matter : For the sorting feature to work, what I did was move the use of the table_method just before the sorting part is added (directly in the actions code template) protected function addSortQuery($query) { if (array(null, null) == ($sort = $this->