Re: [sympy] 0.7.1 hanging on sub of DeferredVector

2011-07-25 Thread Aaron Meurer
I think the proper fix is to either make DeferredVector an Expr object or give it a _sympy_ method so that sympify() knows how to convert it without resorting to trying to iterate over it. Actually, I see now that DeferredVector is a generator of Symbol objects. So expr.subs(x, newt) makes about

Re: [sympy] 0.7.1 hanging on sub of DeferredVector

2011-07-25 Thread Chris Smith
On Mon, Jul 25, 2011 at 7:46 PM, Aaron Meurer wrote: > Tracking it down was easy.  The thing I'm not sure about is how to > properly fix this. Any objects that iterates infinitely would have > this problem. > I can't look into this too deeply now, but is there an exclude flag on the iterable() fu

Re: [sympy] 0.7.1 hanging on sub of DeferredVector

2011-07-25 Thread Aaron Meurer
Tracking it down was easy. The thing I'm not sure about is how to properly fix this. Any objects that iterates infinitely would have this problem. Aaron Meurer On Mon, Jul 25, 2011 at 6:08 PM, Matthew Brett wrote: > Hi, > > On Tue, Jul 26, 2011 at 1:02 AM, Aaron Meurer wrote: >> I bisected thi

Re: [sympy] Pull Request Request

2011-07-25 Thread Aaron Meurer
It will merge cleanly. I am running the sympy-bot tests now. Aaron Meurer On Mon, Jul 25, 2011 at 6:13 PM, Haz wrote: >   I've reviewed it a number of times. If there are still problems, it's > likely something that I won't pick up (like reading your own reading -- you > just see it correctly r

Re: [sympy] Pull Request Request

2011-07-25 Thread Haz
I've reviewed it a number of times. If there are still problems, it's likely something that I won't pick up (like reading your own reading -- you just see it correctly rather than seeing any mistakes that may be there :p). It's also been looked at by others in the community (see those participati

Re: [sympy] 0.7.1 hanging on sub of DeferredVector

2011-07-25 Thread Matthew Brett
Hi, On Tue, Jul 26, 2011 at 1:02 AM, Aaron Meurer wrote: > I bisected this to > > commit f95d0146f59fd9160fe867561fb6620c3a035ad1 > Author: Chris Smith > Date:   Wed Jun 15 22:15:17 2011 -0500 > >    use ordered_iter and iterable > >    This reverts commit 654cb9bc6d3bdab45d45a8ec2b41df358b5aa44

Re: [sympy] Pull Request Request

2011-07-25 Thread Aaron Meurer
So has it passed review and you just need someone to push it in, or do you need help reviewing it still? Aaron Meurer On Mon, Jul 25, 2011 at 6:02 PM, Haz wrote: >   Excuse the stutter ;). There is a pull request [0] that has gone through a > number of iterations and contains quite a large chunk

[sympy] Pull Request Request

2011-07-25 Thread Haz
Excuse the stutter ;). There is a pull request [0] that has gone through a number of iterations and contains quite a large chunk of code that is needed for further work in Saptarshi's SoC plans. Could high dev higher up please take a final gander / pull it into the trunk so progress can continue?

Re: [sympy] 0.7.1 hanging on sub of DeferredVector

2011-07-25 Thread Aaron Meurer
I bisected this to commit f95d0146f59fd9160fe867561fb6620c3a035ad1 Author: Chris Smith Date: Wed Jun 15 22:15:17 2011 -0500 use ordered_iter and iterable This reverts commit 654cb9bc6d3bdab45d45a8ec2b41df358b5aa440 and adds a few more use cases. The problem is that sympify(newt)

[sympy] 0.7.1 hanging on sub of DeferredVector

2011-07-25 Thread Matthew Brett
Hi, On my snow leopard machine: from sympy import Symbol, DeferredVector x = Symbol('x') newt = DeferredVector("t") res = x.subs(x, newt) results in a long hang. On 0.7.0 and 0.6.6 it's very quick. Ctrl-C on the 0.7.1 branch running the code above (as ``hanging.py``) ends with a traceback:

[sympy] Avoiding big branches

2011-07-25 Thread Aaron Meurer
Hi everyone. I wrote a blog post about this (http://asmeurersympy.wordpress.com/2011/07/25/merging-integration3-with-sympy-0-7-0-nightmare/), but I think it's important enough that it should be discussed here. You can read my blog post for the details, but basically I spent the past three weeks o

[sympy] Re: 1.0 * Symbol('x') in 0.7.0

2011-07-25 Thread Vinzent Steinberg
On 25 Jul., 05:17, Matthew Brett wrote: > Hi, > > On Sun, Jul 24, 2011 at 10:22 PM, Vinzent Steinberg > > wrote: > > On Jul 24, 1:28 am, Matthew Brett wrote: > >> To me, that inconsistency is a benefit.  Is there some disbenefit? > >> I'm asking honestly.  For me it is just a question of reduced

Re: [sympy] Re: 1.0 * Symbol('x') in 0.7.0

2011-07-25 Thread Matthew Brett
Hi, On Sun, Jul 24, 2011 at 10:22 PM, Vinzent Steinberg wrote: > On Jul 24, 1:28 am, Matthew Brett wrote: >> To me, that inconsistency is a benefit.  Is there some disbenefit? >> I'm asking honestly.  For me it is just a question of reduced >> readability in doctests and examples. > > How would