Re: [sympy] Thought on implementing measurements in sympy/physics/quantum/circuitplot.py

2013-07-16 Thread Ondřej Čertík
Indeed. If there is anything that you need help with, please let us know. I'll do my best. Ondrej On Mon, Jul 15, 2013 at 4:08 PM, Brian Granger wrote: > Rick, this is fantastic! > > On Mon, Jul 15, 2013 at 1:02 PM, Rick Muller wrote: >> The second round is now done: controlled wires now succes

Re: [sympy] test_args

2013-07-16 Thread Aaron Meurer
Just put @XFAIL on the line before the def of the test. Aaron Meurer On Tue, Jul 16, 2013 at 4:26 PM, Mary Clark wrote: > Do I just put that in front of the test in test_args? Also, I realised that > CartanType_generator also fails, likely for the same reason. > > > On Tuesday, 16 July 2013

Re: [sympy] test_args

2013-07-16 Thread Mary Clark
Do I just put that in front of the test in test_args? Also, I realised that CartanType_generator also fails, likely for the same reason. On Tuesday, 16 July 2013 22:01:45 UTC+1, Aaron Meurer wrote: > > Just mark this test as @XFAIL. We haven't decided what the proper way > to deal with classes

Re: [sympy] test_args

2013-07-16 Thread Aaron Meurer
Just mark this test as @XFAIL. We haven't decided what the proper way to deal with classes that have strings in them is yet. It's the same issue as MatrixSymbol (you can read the discussion at https://groups.google.com/d/msg/sympy/pyzfmCq_thI/UwFLv_RDX2IJ if you are interested). Aaron Meurer On T

Re: [sympy] test_args

2013-07-16 Thread Mary Clark
Okay, so...what exactly makes an object Basic, for lack of a better way to say it? Standard_Cartan needs to have two arguments, one to specify the letter, and one to specify the rank. I don't understand how to make it so that the __init__ method uses Basic objects to specify these things. -

Re: [sympy] test_args

2013-07-16 Thread Ondřej Čertík
On Tue, Jul 16, 2013 at 1:20 PM, Mary Clark wrote: > Right, okay. So I did that for both CartanType_generator and > Standard_Cartan and the tests passed for CartanType_generator, but not > Standard_Cartan and I'm not entirely sure why. > > Here is the test I wrote for Standard_Cartan: > > def tes

Re: [sympy] test_args

2013-07-16 Thread Mary Clark
Right, okay. So I did that for both CartanType_generator and Standard_Cartan and the tests passed for CartanType_generator, but not Standard_Cartan and I'm not entirely sure why. Here is the test I wrote for Standard_Cartan: def test_sympy__liealgebras__cartan_type__Standard_Cartan(): fr

Re: [sympy] Ternary quadratic forms and Quadratic congruences

2013-07-16 Thread Thilina Rathnayake
Thank you very much mario for the trouble taken. I'll let you guys know whether this fix works. On Tue, Jul 16, 2013 at 7:43 PM, Ondřej Čertík wrote: > Thanks Mario! > > Thilina, let us know if that works. I apologize I didn't have time > yesterday. > > Ondrej > > On Tue, Jul 16, 2013 at 5:38 A

Re: [sympy] test_args

2013-07-16 Thread Aaron Meurer
On Jul 16, 2013, at 9:14 AM, "Ondřej Čertík" wrote: > On Tue, Jul 16, 2013 at 12:49 AM, F. B. wrote: >> I think that new developers should be notified about the args tree >> expressions. I had to do a lot of rewriting in my first PR after learning of >> test_args. > > Yeah. Also the exception

Re: [sympy] test_args

2013-07-16 Thread Ondřej Čertík
On Tue, Jul 16, 2013 at 12:49 AM, F. B. wrote: > I think that new developers should be notified about the args tree > expressions. I had to do a lot of rewriting in my first PR after learning of > test_args. Yeah. Also the exception in our test suite should point to the link: http://docs.sympy

Re: [sympy] Ternary quadratic forms and Quadratic congruences

2013-07-16 Thread Ondřej Čertík
Thanks Mario! Thilina, let us know if that works. I apologize I didn't have time yesterday. Ondrej On Tue, Jul 16, 2013 at 5:38 AM, mario wrote: > In the attached file there is my attempt; it seems to work; it seems to me > that there is a bug > in the code in the book; in line 4 it should be >

Re: [sympy] Ternary quadratic forms and Quadratic congruences

2013-07-16 Thread mario
On Tuesday, July 16, 2013 1:38:02 PM UTC+2, mario wrote: > > In the attached file there is my attempt; it seems to work; it seems to me > that there is a bug > in the code in the book; in line 4 it should be > ``Find r in [0,..., ceiling(abs(B)/2] such that r**2 == A mod B`` > > > > On Tuesday,

Re: [sympy] Ternary quadratic forms and Quadratic congruences

2013-07-16 Thread mario
In the attached file there is my attempt; it seems to work; it seems to me that there is a bug in the code in the book; in line 4 it should be ``Find r in [0,..., ceiling(abs(B)/2] such that r**2 == A mod B`` On Tuesday, July 16, 2013 2:13:32 AM UTC+2, Thilina Rathnayake wrote: > > Hi Ondrej, >