Re: [sympy] Re: Lie algebra module

2013-07-23 Thread Ondřej Čertík
Thanks. This looks ok to me, tests pass, so I just merged it. Big congrats! Now let's get your other PR in. Ondrej On Tue, Jul 23, 2013 at 3:30 PM, Mary Clark wrote: > I've fixed the error. The travis build is here: > https://travis-ci.org/sympy/sympy/builds/9404509 > > > -- > You received th

Re: [sympy] Lazy attributes (C removal)

2013-07-23 Thread Aaron Meurer
On Tue, Jul 23, 2013 at 12:07 PM, Joachim Durchholz wrote: > What about the other outstanding decisions? > > Do we need the ability to assign to lazy class attributes? > I think probably no, but I may be missing something. > > Do we need the ability to reset a lazy class attribute? > This would be

Re: [sympy] Ternary quadratic forms and Quadratic congruences

2013-07-23 Thread Thilina Rathnayake
Thanks mario for the great job. Let me try your code. Regards, Thilina On Wed, Jul 24, 2013 at 12:47 AM, Ondřej Čertík wrote: > Thanks. Should we integrate it into sympy? > > Ondrej > > On Tue, Jul 23, 2013 at 1:34 AM, mario wrote: > > In the attached file there is a new version of ``descent``

Re: [sympy] Re: Lie algebra module

2013-07-23 Thread Mary Clark
I've fixed the error. The travis build is here: https://travis-ci.org/sympy/sympy/builds/9404509 -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@go

Re: [sympy] Ternary quadratic forms and Quadratic congruences

2013-07-23 Thread Ondřej Čertík
Thanks. Should we integrate it into sympy? Ondrej On Tue, Jul 23, 2013 at 1:34 AM, mario wrote: > In the attached file there is a new version of ``descent``; I followed your > suggestion about > reducing the input to the square free part; in this way the lowest modular > square root is > always

Re: [sympy] Lazy attributes (C removal)

2013-07-23 Thread Joachim Durchholz
What about the other outstanding decisions? Do we need the ability to assign to lazy class attributes? I think probably no, but I may be missing something. Do we need the ability to reset a lazy class attribute? This would be useful to cut down on memory usage. It would require something where

Re: [sympy] Lazy attributes (C removal)

2013-07-23 Thread Aaron Meurer
On Tue, Jul 23, 2013 at 5:19 AM, Joachim Durchholz wrote: > Okay, the lazy attribute stuff works. I haven't stress tested it yet because > some design options have popped up and I need feedback on what's needed. > > Here goes: > > 1) Do we need the ability to assign to a lazy attribute? > This is

Re: [sympy] Re: Lie algebra module

2013-07-23 Thread Ondřej Čertík
I see, it only fails when you merge with master do: git checkout liealgebras_1 git fetch origin master:master git merge master ondrej@eagle:~/repos/sympy(a)$ bin/doctest sympy/liealgebras/ = test process starts == executable: /u

Re: [sympy] Re: Lie algebra module

2013-07-23 Thread Mary Clark
https://travis-ci.org/meclark256/sympy/builds/933 On Tuesday, 23 July 2013 01:40:03 UTC+1, Ondřej Čertík wrote: > > Can you post a link? The latest commit is 957ea04, which has an "X" next > to it: > > https://travis-ci.org/sympy/sympy/builds/9332240 > > which fails. This needs to get fixed

[sympy] Lazy attributes (C removal)

2013-07-23 Thread Joachim Durchholz
Okay, the lazy attribute stuff works. I haven't stress tested it yet because some design options have popped up and I need feedback on what's needed. Here goes: 1) Do we need the ability to assign to a lazy attribute? This is a pure design choice: - Assigning could be made to simply overwrite