Re: [sympy] Re: You can now grant people access to push to your PRs

2016-09-07 Thread Aaron Meurer
It will make reviewing easier, because if someone doesn't respond to a review I can just push the fix. That's assuming they checked the box (it's off by default). It doesn't help with finding which PRs to review, which is what my other discussion is about. Maybe it would be useful to be able to se

[sympy] Re: You can now grant people access to push to your PRs

2016-09-07 Thread Samuel Lelièvre
2016-09-07 21:01:53 UTC+2, Aaron Meurer: > > GitHub now has a checkbox that you can check on your PRs, which lets you > grant project maintainers access to push to that branch. See > https://github.com/blog/2247-improving-collaboration-with-forks. So now, > if someone has checked that box, inst

Re: [sympy] Re: Simplify complex expression

2016-09-07 Thread Blair Azzopardi
That's great - I hadn't consider that. Thank you. On 6 September 2016 at 02:05, Aaron Meurer wrote: > When you enter 1/4, Python evaluates this as a float. That's why all your > expressions have floating point numbers. Use Rational(1, 4), or root(-1, > 4). If you do that, then expand_complex() w

Re: [sympy] You can now grant people access to push to your PRs

2016-09-07 Thread Jason Moore
Awesome! A long needed feature. This can really help cut down on the time it takes to make small, minor, and inconsequential changes. And we no longer have to do pr's against other people's pr. This will really help the workflow. Jason moorepants.info +01 530-601-9791 On Wed, Sep 7, 2016 at 12:0

[sympy] You can now grant people access to push to your PRs

2016-09-07 Thread Aaron Meurer
GitHub now has a checkbox that you can check on your PRs, which lets you grant project maintainers access to push to that branch. See https://github.com/blog/2247-improving-collaboration-with-forks. So now, if someone has checked that box, instead of waiting for them to fix issues from your review,