[sympy] New attribute: is_symbol (lowercase S)

2016-09-08 Thread Francesco Bonazzi
After a discussion with Aaron, I introduced the idea of *is_symbol* in #11571 as a way to tell *Derivative* that the object, say *x*, with *is_symbol = True* should not be replaced with a dummy when an expression is being derived w.r.t. that object *x

Re: [sympy] Idea for PR reviewing

2016-09-08 Thread Jason Moore
I agree that closing is not a good idea. Jason moorepants.info +01 530-601-9791 On Thu, Sep 8, 2016 at 12:15 PM, Ondřej Čertík wrote: > On Thu, Sep 8, 2016 at 12:09 PM, Aaron Meurer wrote: > > I'm not a fan of that. Closing gives people the impression that the pull > > request is being reject

Re: [sympy] Idea for PR reviewing

2016-09-08 Thread Ondřej Čertík
On Thu, Sep 8, 2016 at 12:09 PM, Aaron Meurer wrote: > I'm not a fan of that. Closing gives people the impression that the pull > request is being rejected. I know. GitHub should improve this workflow a lot. Ondrej -- You received this message because you are subscribed to the Google Groups "

Re: [sympy] Idea for PR reviewing

2016-09-08 Thread Aaron Meurer
I'm not a fan of that. Closing gives people the impression that the pull request is being rejected. Aaron Meurer On Thu, Sep 8, 2016 at 1:48 PM, Ondřej Čertík wrote: > One option is to close the PR if it's not ready, since I think the > author of the PR can reopen it. That solves the issue that

Re: [sympy] Idea for PR reviewing

2016-09-08 Thread Ondřej Čertík
One option is to close the PR if it's not ready, since I think the author of the PR can reopen it. That solves the issue that the author of the PR can't touch the labels. On Fri, Sep 2, 2016 at 1:55 PM, Aaron Meurer wrote: > It seems several similar tools already exist. https://about.pullapprove.