Re: [sympy] Are indirect imports problematic?

2015-01-12 Thread Joachim Durchholz
Am 12.01.2015 um 20:22 schrieb Rathmann: To me, the relevant concept seems to be software coupling, as railed against by structured programming gurus in the 1970s and 80s. Coupling is logical interdependency. An import already establishes that dependency. Having imports which know exactly whe

Re: [sympy] Are indirect imports problematic?

2015-01-12 Thread Rathmann
To me, the relevant concept seems to be software coupling, as railed against by structured programming gurus in the 1970s and 80s. Having imports which know exactly where a symbol is defined, increase the knowledge that one part of our code has of other parts. Coupling is often unavoidable, but

Re: [sympy] Are indirect imports problematic?

2015-01-11 Thread Joachim Durchholz
Am 11.01.2015 um 19:12 schrieb Aaron Meurer: The other con is that if the function is moved (say, split out into a new file), you have to change every other file that imports it. I agree it's a con (and one I overlooked because I incorrectly thought it's already covered under (22), quoted belo

Re: [sympy] Are indirect imports problematic?

2015-01-11 Thread Aaron Meurer
On Sat, Jan 10, 2015 at 4:52 PM, Joachim Durchholz wrote: > E.g. some modules do > > from sympy import log > > others do > > from sympy.functions.elementary.exponential import exp > > > Pros of doing just direct imports > - > > 01) Code review can instantly see whe

[sympy] Are indirect imports problematic?

2015-01-10 Thread Joachim Durchholz
E.g. some modules do from sympy import log others do from sympy.functions.elementary.exponential import exp Pros of doing just direct imports - 01) Code review can instantly see where some symbol originates from. 02) This should eliminate some circular import