Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

On Tue, 4 Apr 2023 at 08:33, Aaron Meurer wrote: > > On Sun, Apr 2, 2023 at 10:29 AM Oscar Benjamin > wrote: > > > > > > I have figured out though a way that I could automate updates for > > requirements.txt files using the create-pull-request action and > > pip-upgrader: > > https://github.com/m

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

On Sun, Apr 2, 2023 at 10:29 AM Oscar Benjamin wrote: > > On Sun, 2 Apr 2023 at 02:19, Aaron Meurer wrote: > > > > On Sat, Apr 1, 2023 at 5:04 AM Oscar Benjamin > > wrote: > > > > > > On Sat, 1 Apr 2023 at 06:36, Aaron Meurer wrote: > > > > > > > > On Fri, Mar 31, 2023 at 10:33 PM Jason Moore

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

On Sun, 2 Apr 2023 at 02:19, Aaron Meurer wrote: > > On Sat, Apr 1, 2023 at 5:04 AM Oscar Benjamin > wrote: > > > > On Sat, 1 Apr 2023 at 06:36, Aaron Meurer wrote: > > > > > > On Fri, Mar 31, 2023 at 10:33 PM Jason Moore wrote: > > > > > > > > When the # of dependencies is large, dependabot is

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

On Sat, Apr 1, 2023 at 5:04 AM Oscar Benjamin wrote: > > On Sat, 1 Apr 2023 at 06:36, Aaron Meurer wrote: > > > > On Fri, Mar 31, 2023 at 10:33 PM Jason Moore wrote: > > > > > > When the # of dependencies is large, dependabot is a very annoying > > > feature. I contributed to a Javascript lib a

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

On Sat, 1 Apr 2023 at 06:36, Aaron Meurer wrote: > > On Fri, Mar 31, 2023 at 10:33 PM Jason Moore wrote: > > > > When the # of dependencies is large, dependabot is a very annoying feature. > > I contributed to a Javascript lib and the dependabot floods your inbox and > > notifications with usel

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

On Fri, Mar 31, 2023 at 10:33 PM Jason Moore wrote: > > When the # of dependencies is large, dependabot is a very annoying feature. I > contributed to a Javascript lib and the dependabot floods your inbox and > notifications with useless PRs. It may be ok for us, since it is only > checking a h

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

When the # of dependencies is large, dependabot is a very annoying feature. I contributed to a Javascript lib and the dependabot floods your inbox and notifications with useless PRs. It may be ok for us, since it is only checking a handful of dependencies and those don't change too often. Jason mo

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

I only ever hear bad things about dependabot. I don't have any experience with it myself, but I would be cautious about using it. Maybe try reaching out to other communities that have tried it to see what their experiences have been. Aaron Meurer On Fri, Mar 31, 2023 at 8:20 AM Oscar Benjamin wr

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

I like the idea of the following With https://github.com/sympy/sympy/pull/24908 you can pip install pre-commit and then any time you want to run the precommit checks you just run: $ pre-commit flake8...Passed ruff

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

Okay, so it seems people are not keen on integrating the pre-commit.ci bot. We can of course continue to make a pre-commit config that any contributor wants to use. Another question I have is what people think about using dependabot. We regularly have problems where new versions of SymPy's depend

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

That's what I was worried about too. If the bot pushes a commit, then the PR author won't be able to push any additional commits unless they either pull first or force push. Personally I would find that a little surprising, and might not even notice it when I do "git push". Plus I feel like this wo

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

On Tue, 28 Mar 2023 at 17:13, Tirthankar Mazumder wrote: > > Adding a bit to this, the Rust repository does something similar to the > pre-commit hook thing: When you set up your dev environment, you can > optionally run ./x.py setup which optionally installs a pre-commit hook (with > the user'

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

Adding a bit to this, the Rust repository does something similar to the pre-commit hook thing: When you set up your dev environment, you can optionally run ./x.py setup which optionally installs a pre-commit hook (with the user's permission, of course) for ru

Re: [sympy] Enabling precommit.ci to fix common PR problems automatically

I personally would find a bot adding commits to my work a bit intrusive. If the bot posted a comment to the issue telling me what to fix, that would be preferable. Right now we have to make a few clicks to see why the linter failed. Conda forge has a bot that will add commits to your branch, but o

[sympy] Enabling precommit.ci to fix common PR problems automatically

Hi all, There are two open PRs discussing the potential use of pre-commit and pre-commit.ci in SymPy: https://github.com/sympy/sympy/pull/24908 https://github.com/sympy/sympy/pull/24941 I want to know what others think specifically about enabling pre-commit.ci on the sympy repo or otherwise enco