Re: [sympy] Linear Inequality Simplifier

2021-06-27 Thread Oscar Benjamin
Great! There seems to have been some kind of git problem so that the changes in the PR are not as intended though... I left a comment at the PR: https://github.com/sympy/sympy/pull/21673 Let's continue the discussion there. Oscar ‪On Sun, 27 Jun 2021 at 19:49, ‫אוריאל מליחי‬‎ wrote:‬ > > ok. >

Re: [sympy] Linear Inequality Simplifier

2021-06-27 Thread אוריאל מליחי
ok. I made a pull request for the linear programing solver and I did not add the inequalities functions in the commit for now. The pull request number is #21673 waiting for your aproval/corrections. thank you! On Sunday, 20 June 2021 at 22:33:16 UTC+3 Oscar wrote: > Okay, that code looks good.

Re: [sympy] Linear Inequality Simplifier

2021-06-20 Thread Oscar Benjamin
Okay, that code looks good. It will also need docs and tests. I suggest first trying to add the smallest part of this to sympy. Then other parts can be added one step at a time. The question is what is the smallest part that is useful on its own. Is that the simplex function? If you open a pull

Re: [sympy] Linear Inequality Simplifier

2021-06-19 Thread אוריאל מליחי
Yes, my code is viewable in here- https://github.com/orielmalihi/Final-Project/blob/main/my%20functions/inequalities%20functions.py On Friday, 18 June 2021 at 00:09:11 UTC+3 Oscar wrote: > That's great. I suggest not trying to add everything at once. Probably > some changes will need to be made

Re: [sympy] Linear Inequality Simplifier

2021-06-17 Thread Oscar Benjamin
That's great. I suggest not trying to add everything at once. Probably some changes will need to be made and there are other steps like tests and so on that would need to be added if there aren't already tests in the right format. Is your code publicly viewable already? For example if you put it i

Re: [sympy] Linear Inequality Simplifier

2021-06-17 Thread אוריאל מליחי
Hello everyone! I finally completed implementing these functions. *Quick reminder:* The main function is called *is_implied_by* and it gets a set of linear inequalities and a target linear inequality and return whether the target is implied by the set or not. Two other functions are *find_v

Re: [sympy] Linear Inequality Simplifier

2021-02-18 Thread Oscar Gustafsson
Den tors 18 feb. 2021 kl 14:36 skrev Oscar Benjamin < oscar.j.benja...@gmail.com>: > On Thu, 18 Feb 2021 at 11:32, Oscar Gustafsson > wrote: > > > > After currently using Mathematica for similar things, I would just like > to encourage you to provide some nice method to simplify constraints of >

Re: [sympy] Linear Inequality Simplifier

2021-02-18 Thread Oscar Benjamin
On Thu, 18 Feb 2021 at 11:32, Oscar Gustafsson wrote: > > After currently using Mathematica for similar things, I would just like to > encourage you to provide some nice method to simplify constraints of > piecewise functions using your simplifier, including additional constraints > on the rang

Re: [sympy] Linear Inequality Simplifier

2021-02-18 Thread Oscar Gustafsson
After currently using Mathematica for similar things, I would just like to encourage you to provide some nice method to simplify constraints of piecewise functions using your simplifier, including additional constraints on the range of variables (as SymPy doesn't have a way to put ranges on variabl

Re: [sympy] Linear Inequality Simplifier

2021-02-18 Thread אוריאל מליחי
I understand. So I would use the LP solver implemented by Lee which should work with symbolic coefficients. On Thu, 18 Feb 2021 at 00:46, Oscar Benjamin wrote: > ‪On Tue, 16 Feb 2021 at 17:01, ‫אוריאל מליחי‬‎ > wrote:‬ > > > > For your first question, I intend to create a new function that whe

Re: [sympy] Linear Inequality Simplifier

2021-02-17 Thread Oscar Benjamin
‪On Tue, 16 Feb 2021 at 17:01, ‫אוריאל מליחי‬‎ wrote:‬ > > For your first question, I intend to create a new function that when given a > set of linear inequalities and a target inequality it would output True if > the target is implied by this set, False if it is not, and Unknown otherwise. >

Re: [sympy] Linear Inequality Simplifier

2021-02-16 Thread אוריאל מליחי
Thank you Lee for your quick reply. I will recheck it. בתאריך יום ג׳, 16 בפבר׳ 2021, 19:36, מאת S.Y. Lee ‏: > SciPy's implementation is to minimize c^{T} x while my implementation is > to maximize c^{T} x > I verified that it gives same result result with scipy when I changed the > problem to mi

Re: [sympy] Linear Inequality Simplifier

2021-02-16 Thread S.Y. Lee
SciPy's implementation is to minimize c^{T} x while my implementation is to maximize c^{T} x I verified that it gives same result result with scipy when I changed the problem to minimize -c^{T} x I have given a brief documentation about how to use in the comment, but not in the docstring, beca

Re: [sympy] Linear Inequality Simplifier

2021-02-16 Thread אוריאל מליחי
Hey Oscar, sorry for the late reply, I was overloaded with exams. For your first question, I intend to create a new function that when given a set of linear inequalities and a target inequality it would output True if the target is implied by this set, False if it is not, and Unknown otherwise. I

Re: [sympy] Linear Inequality Simplifier

2020-12-31 Thread S.Y. Lee
I have a full implementation of linear programming in https://github.com/sympy/sympy/issues/20391 Although if you may or may not want the code, I hope it can reduce any duplicate efforts if you were intending to implement the same method. On Thursday, December 31, 2020 at 5:58:55 AM UTC+9 Oscar

Re: [sympy] Linear Inequality Simplifier

2020-12-30 Thread Oscar Benjamin
‪On Wed, 30 Dec 2020 at 19:47, ‫אוריאל מליחי‬‎ wrote:‬ > > > Okay, well if you want this to be included in sympy I suggest to begin. > > by making some specific proposals either here or in github issues. We > > should agree the basic ideas before too much work is done. Of course > > you don't have

Re: [sympy] Linear Inequality Simplifier

2020-12-30 Thread אוריאל מליחי
> Okay, well if you want this to be included in sympy I suggest to begin. > by making some specific proposals either here or in github issues. We > should agree the basic ideas before too much work is done. Of course > you don't have to implement all the proposals but we should agree what > makes s

Re: [sympy] Linear Inequality Simplifier

2020-12-29 Thread Oscar Benjamin
Okay, well if you want this to be included in sympy I suggest to begin by making some specific proposals either here or in github issues. We should agree the basic ideas before too much work is done. Of course you don't have to implement all the proposals but we should agree what makes sense as par

Re: [sympy] Linear Inequality Simplifier

2020-12-28 Thread אוריאל מליחי
Thank you all for your advices. and Oscar, for your question- yes, i do intend for this to be incorporated as part of sympy if it is possible. On Sunday, 27 December 2020 at 23:57:20 UTC+2 Oscar wrote: > ‪On Sun, 27 Dec 2020 at 10:46, ‫אוריאל מליחי‬‎ > wrote:‬ > > > > Hello everyone! > > Hi, >

Re: [sympy] Linear Inequality Simplifier

2020-12-27 Thread Oscar Benjamin
‪On Sun, 27 Dec 2020 at 10:46, ‫אוריאל מליחי‬‎ wrote:‬ > > Hello everyone! Hi, > As part of my final project in my computer science degree I would like to > develop a class for linear inequalities simplifying. That sounds like an excellent project. To be clear, are you intending for this to be

[sympy] Linear Inequality Simplifier

2020-12-27 Thread אוריאל מליחי
Hello everyone! As part of my final project in my computer science degree I would like to develop a class for linear inequalities simplifying. The class's main algorithm is that for given a set of linear inequalities in m variables, it returns a simplified set. "Simplified" may mean an equiva