Re: [sympy] Pull Request Request

2011-07-25 Thread Aaron Meurer
It will merge cleanly. I am running the sympy-bot tests now. Aaron Meurer On Mon, Jul 25, 2011 at 6:13 PM, Haz wrote: >   I've reviewed it a number of times. If there are still problems, it's > likely something that I won't pick up (like reading your own reading -- you > just see it correctly r

Re: [sympy] Pull Request Request

2011-07-25 Thread Haz
I've reviewed it a number of times. If there are still problems, it's likely something that I won't pick up (like reading your own reading -- you just see it correctly rather than seeing any mistakes that may be there :p). It's also been looked at by others in the community (see those participati

Re: [sympy] Pull Request Request

2011-07-25 Thread Aaron Meurer
So has it passed review and you just need someone to push it in, or do you need help reviewing it still? Aaron Meurer On Mon, Jul 25, 2011 at 6:02 PM, Haz wrote: >   Excuse the stutter ;). There is a pull request [0] that has gone through a > number of iterations and contains quite a large chunk

[sympy] Pull Request Request

2011-07-25 Thread Haz
Excuse the stutter ;). There is a pull request [0] that has gone through a number of iterations and contains quite a large chunk of code that is needed for further work in Saptarshi's SoC plans. Could high dev higher up please take a final gander / pull it into the trunk so progress can continue?