[sympy] Re: Irreducibility test

2010-03-09 Thread Mateusz Paprocki
Hi, On Sun, Mar 07, 2010 at 02:07:29PM +0100, Kasun Samarasinghe wrote: > hi, > I have attached the patch with this for rabin's test for irreducibility > test. Please give me some comments on that. > def gf_irreducible_rabin(f, p, K): """Test for the irreducibility of a polynomial over `GF(p

[sympy] Re: Irreducibility test

2010-03-09 Thread Mateusz Paprocki
Hi, On Tue, Mar 09, 2010 at 08:36:18PM +0100, Kasun Samarasinghe wrote: > Hi, > > I m working on the comments, I think i can find out the problems in the > algorithm implementation. > > In the implementation I need to have a polynomial x^(p^ni) to test the gcd > with the given polynomial. In thi

[sympy] Re: Irreducibility test

2010-03-22 Thread Mateusz Paprocki
Hi, On Sat, Mar 13, 2010 at 10:44:51AM +0100, Kasun Samarasinghe wrote: > hi, > > this is a further clarification. In rabins test there are two conditions > checked. both of them > has to be satisfied. In my implementation for the irreducible polynomials > passed one of them > are not satisfied.

Re: [sympy] Re: Irreducibility test

2010-03-09 Thread Kasun Samarasinghe
Hi, I m working on the comments, I think i can find out the problems in the algorithm implementation. In the implementation I need to have a polynomial x^(p^ni) to test the gcd with the given polynomial. In this situation it takes a long time using the gf_pow function. My values are p = 11, ni =

Re: [sympy] Re: Irreducibility test

2010-03-09 Thread Kasun Samarasinghe
but i need to check the gcd for all ni, where ni=n/pi. here pi are the prime factors of n. So i have to call gf_pow for all such numbers. what can i do in that case? Kasun On Tue, Mar 9, 2010 at 8:52 PM, Mateusz Paprocki wrote: > Hi, > > On Tue, Mar 09, 2010 at 08:36:18PM +0100, Kasun Samarasin

Re: [sympy] Re: Irreducibility test

2010-03-10 Thread Kasun Samarasinghe
i figured out the way. I will send the patch for review. kasun On Tue, Mar 9, 2010 at 9:02 PM, Kasun Samarasinghe wrote: > but i need to check the gcd for all ni, where ni=n/pi. here pi are the > prime factors of n. So > i have to call gf_pow for all such numbers. what can i do in that case? >

Re: [sympy] Re: Irreducibility test

2010-03-12 Thread Kasun Samarasinghe
Hi, I tried to address almost all the comments you made. I still get wrong results due to some reason? what could be the reason. code is as below. n = gf_degree(f) if n <=1: return True if f[0]!=1: return False h = g = gf_pow([K.one, K.zero], p, p, K) for pf

Re: [sympy] Re: Irreducibility test

2010-03-13 Thread Kasun Samarasinghe
hi, this is a further clarification. In rabins test there are two conditions checked. both of them has to be satisfied. In my implementation for the irreducible polynomials passed one of them are not satisfied. the condition which is not satisfying is let f in GF(p) be the polynomial passed with

Re: [sympy] Re: Irreducibility test

2010-03-16 Thread Kasun Samarasinghe
hi, hope u havent seen my last mail about the irreduciblity algorithm problem, please have a look on that so that i can complete the my patch and send for the review, regards, kasun On Sat, Mar 13, 2010 at 10:44 AM, Kasun Samarasinghe < kwsamarasin...@gmail.com> wrote: > hi, > > this is a furt