[sympy] Re: Sympy design question about encapsulation

2008-10-31 Thread Andy Ray Terrel
On Fri, Oct 31, 2008 at 6:46 AM, Brian Granger <[EMAIL PROTECTED]> wrote: > > One design pattern that I see in many places in sympy is that other > objects are not very encasulated. Let me give an example: > > Take printers. My initial expectation is that each object itself > would be responsibl

[sympy] Re: Sympy design question about encapsulation

2008-11-02 Thread Brian Granger
>> But, in sympy, the printer class has all of these methods for all the >> classes that need to be printed. Why is it done this way? > > See issue 908 for some details. ( > http://code.google.com/p/sympy/issues/detail?id=908 ) I skimmed quickly through some of this and it does sound like there

[sympy] Re: Sympy design question about encapsulation

2008-11-03 Thread Ondrej Certik
On Sat, Nov 1, 2008 at 10:32 PM, Brian Granger <[EMAIL PROTECTED]> wrote: > >>> But, in sympy, the printer class has all of these methods for all the >>> classes that need to be printed. Why is it done this way? >> >> See issue 908 for some details. ( >> http://code.google.com/p/sympy/issues/det

[sympy] Re: Sympy design question about encapsulation

2008-11-03 Thread Brian Granger
Ondrej, OK, gives me a bit more context about the history of all of this. But, I am definitely in favor of the localizing logic into classes as much as possible. I will be interested to hear what others think about this proposal. I am crazy busy this week, so I won't have any time to hack on sy

[sympy] Re: Sympy design question about encapsulation

2008-11-03 Thread Robert Kern
On Mon, Nov 3, 2008 at 20:09, Brian Granger <[EMAIL PROTECTED]> wrote: > > Ondrej, > > OK, gives me a bit more context about the history of all of this. > But, I am definitely in favor of the localizing logic into classes as > much as possible. I will be interested to hear what others think > abo

[sympy] Re: Sympy design question about encapsulation

2008-11-04 Thread basti
I think it's a good proposal of Brian and I sent a patch with an implementation to http://groups.google.com/group/sympy-patches/browse_thread/thread/9f8392a8fec0b3e8 Sebastian Krämer --~--~-~--~~~---~--~~ You received this message because you are subscribed to the

[sympy] Re: Sympy design question about encapsulation

2008-11-08 Thread Ondrej Certik
On Tue, Nov 4, 2008 at 3:27 AM, Robert Kern <[EMAIL PROTECTED]> wrote: > > On Mon, Nov 3, 2008 at 20:09, Brian Granger <[EMAIL PROTECTED]> wrote: >> >> Ondrej, >> >> OK, gives me a bit more context about the history of all of this. >> But, I am definitely in favor of the localizing logic into clas