Hi,
There are opposite opinions about usage of decorator
in PR #1226.
In brief: decorator used as an arguments checker for __new__ method
(it's really helps to reduce the length of code).
Honestly the PR is stuck. If you have any
ideas to resolve this dispute. please write your comment.
Regards
Hi,
There are opposite opinions about usage of decorator
in PR #1226.
In brief: decorator used as an arguments checker for __new__ method
(it's really helps to reduce the length of code).
Honestly the PR is stuck. If you have any
ideas to resolve this dispute. please write your comment.
Regards
It is mostly my fault that this is stuck. I said that simply using
default named arguments would be a better decision (see discussion on
the pull request page). However if someone else gives a +1 one on this
topic, the PR should be ok for merging.
I would like to implement what I proposed, however
Slightly off topic, you have already merged contributions, however I
am not sure that you were added to the AUTHORS file.
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To post to this group, send email to sympy@googlegroups.com.
To unsubscribe from t
You talked me into it =) I implement it "simply" with default argument
(and make another PR). If this implementation will be better,
it will be possible to abandon decorator.
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To view this discussion on t
Yes, you're right. One of PR was merged yesterday.
On Sunday, July 1, 2012 11:57:04 PM UTC+3, Stefan Krastanov wrote:
>
> Slightly off topic, you have already merged contributions, however I
> am not sure that you were added to the AUTHORS file.
>
--
You received this message because you are s