Re: Issue 1757 in sympy: Tools to check and correct indentation

2009-12-14 Thread sympy
Comment #16 on issue 1757 by smichr: Tools to check and correct indentation http://code.google.com/p/sympy/issues/detail?id=1757 I suppose the reason for skipping third party and mpmath is that ideally we aren't maintaining them...that should be handled upstream. But I think we should so

Re: Issue 1757 in sympy: Tools to check and correct indentation

2009-12-14 Thread sympy
Comment #17 on issue 1757 by smichr: Tools to check and correct indentation http://code.google.com/p/sympy/issues/detail?id=1757 Julio, you might compare your reindent output with the existing tool found at http://coverage.livinglogic.de/Tools/scripts/reindent.py.html -- You received this

Re: Issue 1702 in sympy: Code Quality (was crlf)

2009-12-14 Thread sympy
Updates: Summary: Code Quality (was crlf) Cc: asmeurer ondrej.certik Comment #1 on issue 1702 by smichr: Code Quality (was crlf) http://code.google.com/p/sympy/issues/detail?id=1702 There are a few things that I would like to see in the testing process to verify a patch: 1) a

Re: Issue 604 in sympy: write tests for p = x**3+2*x**2+8; r = roots(p, x);

2009-12-14 Thread sympy
Comment #10 on issue 604 by idichekop: write tests for p = x**3+2*x**2+8; r = roots(p, x); http://code.google.com/p/sympy/issues/detail?id=604 Hello all, I wanted to shoot this issue here, but when just trying it out I became the following output: === In [67]: p = x**3+2*x**2+8 In

Re: Issue 1757 in sympy: Tools to check and correct indentation

2009-12-14 Thread sympy
Comment #18 on issue 1757 by asmeurer: Tools to check and correct indentation http://code.google.com/p/sympy/issues/detail?id=1757 That's what I was thinking at first for __init__.py files, but back in issue 1454, we were adding all manner of variables into the namespace because __init__.py

Re: Issue 604 in sympy: write tests for p = x**3+2*x**2+8; r = roots(p, x);

2009-12-14 Thread sympy
Comment #11 on issue 604 by asmeurer: write tests for p = x**3+2*x**2+8; r = roots(p, x); http://code.google.com/p/sympy/issues/detail?id=604 roots() returns a dictionary (notice type(r)) of root:multiplicity terms. For example: In [5]: p = (x - 12)*(x - 13)**2*(x - 42)**2 In [6]:

Re: Issue 1757 in sympy: Tools to check and correct indentation

2009-12-14 Thread sympy
Comment #19 on issue 1757 by smichr: Tools to check and correct indentation http://code.google.com/p/sympy/issues/detail?id=1757 regarding comment 14: I felt that way at first (about changing the indenation structure) but I have come to prefer the if-return/do-more to the

Issue 1765 in sympy: classify_ode((x**2 + f(x)**2)*f(x).diff(x) - 2*x*f(x), f(x)) is wrong

2009-12-14 Thread sympy
Status: Accepted Owner: asmeurer Labels: Type-Defect Priority-Medium WrongResult New issue 1765 by asmeurer: classify_ode((x**2 + f(x)**2)*f(x).diff(x) - 2*x*f(x), f(x)) is wrong http://code.google.com/p/sympy/issues/detail?id=1765 In [53]: classify_ode((x**2 + f(x)**2)*f(x).diff(x) -