Re: Issue 1845 in sympy: code quality and whitespace fix are missing \r

2010-04-01 Thread sympy
Updates: Labels: -NeedsReview PassedReview Comment #1 on issue 1845 by ronan.l...@gmail.com: code quality and whitespace fix are missing \r http://code.google.com/p/sympy/issues/detail?id=1845 Seems fine. I'll push it in. -- You received this message because you are listed in the

Re: Issue 1813 in sympy: typo

2010-04-01 Thread sympy
Updates: Labels: -NeedsReview PassedReview Comment #1 on issue 1813 by ronan.l...@gmail.com: typo http://code.google.com/p/sympy/issues/detail?id=1813 Seems fine. I'll push it in. -- You received this message because you are listed in the owner or CC fields of this issue, or because

Re: Issue 1545 in sympy: Efficient data representation in logic.satisfiable()

2010-04-01 Thread sympy
Comment #16 on issue 1545 by Vinzent.Steinberg: Efficient data representation in logic.satisfiable() http://code.google.com/p/sympy/issues/detail?id=1545 Thanks, this is in now. I felt free to add your comment about the test change. I think it's a great idea to use a dict for

Re: Issue 1545 in sympy: Efficient data representation in logic.satisfiable()

2010-04-01 Thread sympy
Comment #17 on issue 1545 by christian.muise: Efficient data representation in logic.satisfiable() http://code.google.com/p/sympy/issues/detail?id=1545 As far as abstracting the representation into a class goes, I had planned on introducing this when it comes time to speed things up with

Re: Issue 1551 in sympy: StrPrinter is class sympy.printing.str and instance in sympy.core.basic

2010-04-01 Thread sympy
Comment #4 on issue 1551 by Vinzent.Steinberg: StrPrinter is class sympy.printing.str and instance in sympy.core.basic http://code.google.com/p/sympy/issues/detail?id=1551 Was this a positive review? I think Basic.__str__ == Basic.__repr__. -- You received this message because you are