Comment #42 on issue 1694 by nicolas.pourcelot: solve has many issues with
fractions
http://code.google.com/p/sympy/issues/detail?id=1694
"if checksol(b, symbol, sol) is not True: # False or None"
yes, I adapted it from "if checksol(f, symbol, sol) is not False:" in an
other part of the co
Comment #43 on issue 1694 by nicolas.pourcelot: solve has many issues with
fractions
http://code.google.com/p/sympy/issues/detail?id=1694
Or we may at least emit a warning for the solutions which could not be
verified.
--
You received this message because you are subscribed to the Google
Updates:
Labels: -PassedReview NeedsReview
Comment #44 on issue 1694 by smichr: solve has many issues with fractions
http://code.google.com/p/sympy/issues/detail?id=1694
1) Regarding comment 13,14: There is only one solution to the equation in
question there. Does the current patch cor
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #45 on issue 1694 by smichr: solve has many issues with fractions
http://code.google.com/p/sympy/issues/detail?id=1694
Two bad solutions are slipping through after applying the patch:
from sympy import *
var('x')
x
eq=x**Rational
Comment #46 on issue 1694 by smichr: solve has many issues with fractions
http://code.google.com/p/sympy/issues/detail?id=1694
Also, the above takes excessively long to report in comparison to master:
master:
0.635
3.04 - 6.03*I
0
3.04 + 6.03*I
2.2135913
after patch:
3.04 - 6.03*I
0
3.04 +
Updates:
Cc: -asmeurer
Labels: -NeedsBetterPatch NeedsReview
Comment #47 on issue 1694 by nicolas.pourcelot: solve has many issues with
fractions
http://code.google.com/p/sympy/issues/detail?id=1694
@smichr, in short (I've just lost my comment before posting it):
#comments 44,
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #48 on issue 1694 by nicolas.pourcelot: solve has many issues with
fractions
http://code.google.com/p/sympy/issues/detail?id=1694
Hmm... There's something I can't explain for now.
After patch:
from sympy import *
var('x')
x
eq
Comment #49 on issue 1694 by asmeurer: solve has many issues with fractions
http://code.google.com/p/sympy/issues/detail?id=1694
It's because you are only running it when f is a Mul or Pow (here it is an
Add). Maybe you meant to only indent line 257?
--
You received this message because you
Comment #50 on issue 1694 by nicolas.pourcelot: solve has many issues with
fractions
http://code.google.com/p/sympy/issues/detail?id=1694
I use f.as_numer_denom() only for Mul or Pow.
But in case of GS_POLY_CV_1 strategy, checksol() is used for an Add.
(line 322)
for sol in cv_sols:
Comment #51 on issue 1694 by smichr: solve has many issues with fractions
http://code.google.com/p/sympy/issues/detail?id=1694
#47 (2) - sorry...I see that there was nothing being thrown away now. It
might be good to keep the comment there as you admitted.
--
You received this message becau
Comment #52 on issue 1694 by smichr: solve has many issues with fractions
http://code.google.com/p/sympy/issues/detail?id=1694
As per comment 8, checking if "0 in result" might fail. Perhaps a comment
could be put there to the effect, "simplification of results might be
necessary to find out
11 matches
Mail list logo
