Re: Issue 1982 in sympy: use is None instead of == None

Comment #5 on issue 1982 by smichr: use is None instead of == None http://code.google.com/p/sympy/issues/detail?id=1982 All the "== True" have been removed from expressions. This generated a slight error in fcode which was fixed. It also highlighted a bit of a wart in the printing logic: The

Re: Issue 1985 in sympy: as_real_imag() gives wrong answer when expanding quotient

Comment #8 on issue 1985 by smichr: as_real_imag() gives wrong answer when expanding quotient http://code.google.com/p/sympy/issues/detail?id=1985 In github/smichr branch t (the one up for review) you will get: import sympy as S S.var('x') x e = (x+x*S.I)/(1+S.I) e.as_real_imag() (re(x),

Re: Issue 1975 in sympy: nsimplify() should be recursive

Updates: Labels: -EasyToFix NeedsReview Comment #5 on issue 1975 by smichr: nsimplify() should be recursive http://code.google.com/p/sympy/issues/detail?id=1975 Sorry about that...please see 1975 branch t at github/smichr -- You received this message because you are subscribed to the Go

Re: Issue 1975 in sympy: nsimplify() should be recursive

Comment #6 on issue 1975 by smichr: nsimplify() should be recursive http://code.google.com/p/sympy/issues/detail?id=1975 and commit 1778 for the sympification rational=True option. -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to thi

Re: Issue 1985 in sympy: as_real_imag() gives wrong answer when expanding quotient

Comment #9 on issue 1985 by renato.c...@gmail.com: as_real_imag() gives wrong answer when expanding quotient http://code.google.com/p/sympy/issues/detail?id=1985 Yes, it works too. It's almost the same thing, using expand(c_mul=True). I missed that in the docs, and was a bit surprised when

Re: Issue 1972 in sympy: Doctests in a module docstring are not executed

Comment #2 on issue 1972 by smichr: Doctests in a module docstring are not executed http://code.google.com/p/sympy/issues/detail?id=1972 Nice catch. +1. -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group, send email to sy

Re: Issue 1985 in sympy: as_real_imag() gives wrong answer when expanding quotient

Updates: Cc: Ronan.Lamy smichr Vinzent.Steinberg Comment #10 on issue 1985 by asmeurer: as_real_imag() gives wrong answer when expanding quotient http://code.google.com/p/sympy/issues/detail?id=1985 So I was so convinced that my solution (refactoring expand(complex=True) and as_real

Re: Issue 1978 in sympy: select whether constant gets distributed into mul

Comment #6 on issue 1978 by asmeurer: select whether constant gets distributed into mul http://code.google.com/p/sympy/issues/detail?id=1978 I'm not sure about this one. Let's see what others think. (I'm referencing the 1978 commit in your t branch). -- You received this message because

Re: Issue 1924 in sympy: Eq() gets .as_basic() method

Updates: Labels: -NeedsReview PassedReview Comment #7 on issue 1924 by asmeurer: Eq() gets .as_basic() method http://code.google.com/p/sympy/issues/detail?id=1924 I am +1 on the change given in 799dbcb17ac243a791c8 (see github comments). I do think that maybe as_basic() should be rena

Re: Issue 1926 in sympy: ode tweaks

Comment #5 on issue 1926 by asmeurer: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 See my comment on github. I am +1 on commit 0fcd2423eb1809a77330, except that item 5c (4c in the commit message) should have a test, if I understand it correctly. -- You received this mes

Re: Issue 1924 in sympy: Eq() gets .as_basic() method

Updates: Labels: -PassedReview NeedsReview Comment #8 on issue 1924 by ronan.l...@gmail.com: Eq() gets .as_basic() method http://code.google.com/p/sympy/issues/detail?id=1924 Still -1. An Eq is already an instance of Basic, so it doesn't make sense to convert it to Basic - unless th

Re: Issue 1647 in sympy: leading_monom is incorrect

Comment #6 on issue 1647 by ronan.l...@gmail.com: leading_monom is incorrect http://code.google.com/p/sympy/issues/detail?id=1647 -1 on changing the name to something cryptic and non-compliant with PEP 8. -- You received this message because you are subscribed to the Google Groups "sympy-issue

Re: Issue 1823 in sympy: integral.atoms(Symbol) should introspect

Updates: Labels: -NeedsReview PassedReview Comment #10 on issue 1823 by asmeurer: integral.atoms(Symbol) should introspect http://code.google.com/p/sympy/issues/detail?id=1823 See comments at github. One thing though, shouldn't we make symbols an method of Basic that does the same

Re: Issue 1772 in sympy: Integral(1,x).is_number fails

Updates: Labels: -NeedsReview NeedsBetterPatch Comment #10 on issue 1772 by asmeurer: Integral(1,x).is_number fails http://code.google.com/p/sympy/issues/detail?id=1772 This doesn't work with the example I gave in comment 1: In [2]: Integral(0, x).is_number Out[2]: False Also, I'm not

Re: Issue 334 in sympy: integrate: integrate(exp(-x**2), x)

Updates: Owner: asmeurer Labels: Integration Comment #12 on issue 334 by asmeurer: integrate: integrate(exp(-x**2), x) http://code.google.com/p/sympy/issues/detail?id=334 Of course, the right thing to do is to implement the full algorithm, which can split out exp(-x**2) from th

Re: Issue 1924 in sympy: Eq() gets .as_basic() method

Comment #9 on issue 1924 by smichr: Eq() gets .as_basic() method http://code.google.com/p/sympy/issues/detail?id=1924 Ronan, could you please give consideration to the difference between Basic and basic just as we do for Integer and integer? Poly is also a Basic and has this mechanism: Po

Re: Issue 1647 in sympy: leading_monom is incorrect

Comment #7 on issue 1647 by smichr: leading_monom is incorrect http://code.google.com/p/sympy/issues/detail?id=1647 OTOH, anyone working with polynomials, I would think, would quickly take to the short and concise names since they are derived from the first letter of the relevant words. I di

Re: Issue 1924 in sympy: Eq() gets .as_basic() method

Comment #10 on issue 1924 by ronan.l...@gmail.com: Eq() gets .as_basic() method http://code.google.com/p/sympy/issues/detail?id=1924 "integer" has a clear meaning, "basic" doesn't. Besides, all Integers are integers, but integers aren't necessarily Integers: your suggestion is inconsisten

Re: Issue 1982 in sympy: use is None instead of == None

Updates: Labels: PassedReview Comment #6 on issue 1982 by asmeurer: use is None instead of == None http://code.google.com/p/sympy/issues/detail?id=1982 I didn't see any "== True" fixes in t. Are they somewhere else. I am +1 on the commit 0509dc16d981a2aa784a in t (see comments on tha

Re: Issue 1983 in sympy: unify mul and pow handling of Add**e

Updates: Labels: PassedReview Comment #1 on issue 1983 by asmeurer: unify mul and pow handling of Add**e http://code.google.com/p/sympy/issues/detail?id=1983 See GitHub comments on commit f44e30877c6cc7911127. -- You received this message because you are subscribed to the Google Groups

Re: Issue 1978 in sympy: select whether constant gets distributed into mul

Comment #7 on issue 1978 by asmeurer: select whether constant gets distributed into mul http://code.google.com/p/sympy/issues/detail?id=1978 Just to be absolutely rigorous (and to get into the habit), I am referencing commit af3778790f8d21fe047b. -- You received this message because you a

Re: Issue 1926 in sympy: ode tweaks

Updates: Labels: -NeedsReview PassedReview NeedsBetterPatch Comment #6 on issue 1926 by asmeurer: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 Adding PassedReview too because everything is fine except for the lack of the test. -- You received this message because y