Status: Accepted
Owner: ryanlists
Labels: Type-Defect Priority-Medium NeedsReview
New issue 1493 by ryanlists: factor a minus 1 out of fractions in simplify
http://code.google.com/p/sympy/issues/detail?id=1493
Added functionality to simplify so that a minus 1 is factored out of
the numerator and
Updates:
Labels: -NeedsReview
Comment #1 on issue 1493 by ondrej.certik: factor a minus 1 out of
fractions in simplify
http://code.google.com/p/sympy/issues/detail?id=1493
It doesn't pass tests:
sympy/simplify/tests/test_rewrite.py:'XPASS: test_trim_xfail'
sympy/simplify/tests/test_si
Comment #3 on issue 1493 by ryanlists: factor a minus 1 out of fractions in
simplify
http://code.google.com/p/sympy/issues/detail?id=1493
Here is the result of running the solver test:
ryan|03:26 PM|~/git/sympy (simplify_minus_sign)$ bin/test -v
sympy/solvers/tests/test_solvers.py
===
Comment #4 on issue 1493 by ryanlists: factor a minus 1 out of fractions in
simplify
http://code.google.com/p/sympy/issues/detail?id=1493
and here is my full test result:
ryan|03:27 PM|~/git/sympy (simplify_minus_sign)$ bin/test
= test process starts
Comment #6 on issue 1493 by ryanlists: factor a minus 1 out of fractions in
simplify
http://code.google.com/p/sympy/issues/detail?id=1493
I made the simplification you suggested and change the log to this:
###
Factor out -1 from fractions in simplify if possibl
Comment #5 on issue 1493 by ryanlists: factor a minus 1 out of fractions in
simplify
http://code.google.com/p/sympy/issues/detail?id=1493
FYI, this little entry in the 4th line from the bottom:
..^X^F...
was my typing and not realizing where the focus was.
--
You received this message becaus
Comment #2 on issue 1493 by ryanlists: factor a minus 1 out of fractions in
simplify
http://code.google.com/p/sympy/issues/detail?id=1493
I don't get those failures. I tested before I pushed. I am re-testing
with the
latest pull. Are you testing from a branch that would different than thi
Updates:
Status: NeedsReview
Comment #8 on issue 1493 by ryanlists: factor a minus 1 out of fractions in
simplify
http://code.google.com/p/sympy/issues/detail?id=1493
(No comment was entered for this change.)
--
You received this message because you are listed in the owner
or CC field
Updates:
Labels: NeedsReview
Comment #7 on issue 1493 by ryanlists: factor a minus 1 out of fractions in
simplify
http://code.google.com/p/sympy/issues/detail?id=1493
I don't think this can be accepted as it still doesn't pass tests. It
messes up
test_solvers.py.
--
You received th
Comment #9 on issue 1493 by ryanlists: factor a minus 1 out of fractions in
simplify
http://code.google.com/p/sympy/issues/detail?id=1493
So, I think I fixed this. test_solvers.py has been modified and all tests
pass.
There is a new branch in my repo:
git://github.com/ryanGT/sympy.git
calle
Updates:
Status: Fixed
Comment #10 on issue 1493 by ondrej.certik: factor a minus 1 out of
fractions in simplify
http://code.google.com/p/sympy/issues/detail?id=1493
This is in, thanks!
--
You received this message because you are listed in the owner
or CC fields of this issue, or bec
11 matches
Mail list logo
