Status: Accepted
Owner: Toon.Verstraelen
Labels: Type-Defect Priority-Medium
New issue 1551 by Toon.Verstraelen: StrPrinter is class sympy.printing.str
and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
This is at least confusing and scaring away people with
Updates:
Labels: NeedsReview
Comment #1 on issue 1551 by Toon.Verstraelen: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
Here is the patch, all tests pass on my side
Attachments:
0001-Renamed-of-St
Updates:
Labels: -NeedsReview PassedReview
Comment #2 on issue 1551 by Vinzent.Steinberg: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
The patch looks fine to me. The non-conventional naming before was ind
Comment #3 on issue 1551 by ronan.l...@gmail.com: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
Hmm... I have looked at Basic.__str__ and Basic.__repr__ many times and I
never
actually understood the code.
This
Comment #4 on issue 1551 by Vinzent.Steinberg: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
Was this a positive review?
I think Basic.__str__ == Basic.__repr__.
--
You received this message because you are liste
Comment #5 on issue 1551 by Toon.Verstraelen: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
Ronan, with monkey-patching, do you mean defining new variables in a module
from
outside the module (similar for classes
Updates:
Labels: -PassedReview NeedsReview
Comment #6 on issue 1551 by Toon.Verstraelen: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
I've tried to take into account the comments of Ronan. There were modul
Comment #7 on issue 1551 by Toon.Verstraelen: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
Here are two more patches that completely solve the problem.
The first one reduces the problem because importing from pri
Updates:
Cc: Ronan.Lamy
Comment #8 on issue 1551 by Vinzent.Steinberg: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
Ronan should review this, as he requested the changes.
--
You received this message beca
Comment #9 on issue 1551 by ronan.l...@gmail.com: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
This looks good, thanks!
I've squashed your commits together, rewritten the commit message and added
a commit
of m
Comment #10 on issue 1551 by asmeurer: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
You should probably mark him as the author using git commit --amend
--author=...
--
You received this message because you are
Updates:
Status: Fixed
Comment #11 on issue 1551 by Toon.Verstraelen: StrPrinter is class
sympy.printing.str and instance in sympy.core.basic
http://code.google.com/p/sympy/issues/detail?id=1551
It is indeed best to squash the four patches together. I like your
simplification,
and
12 matches
Mail list logo