Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-08 Thread codesite-noreply
Updates: Summary: runtests modifications and docstring corrections Comment #27 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 With the ability to test more of the repo, failures that hadn't been detected

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-09 Thread codesite-noreply
Updates: Summary: runtests modifications and docstring corrections Comment #29 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Sorry, just hit a strange bug... -- You received this message becaus

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-09 Thread codesite-noreply
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #30 on issue 1671 by asmeurer: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 This doesn't work on my system: Aaron-Meurer:sympy aaronmeurer((6c5804f...)$)$./bin/test sympy/

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-09 Thread codesite-noreply
Comment #31 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 This is because Chris forgot to add the file get_sympy.py. For me and probably for him get_sympy.pyc was still present, so this did not trigge

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-09 Thread codesite-noreply
Comment #32 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Checkout my runtest2 branch on github, user vks. Should work now. -- You received this message because you are listed in the owner or CC fields

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-09 Thread codesite-noreply
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #33 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 (No comment was entered for this change.) -- You received this message because you are l

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-09 Thread codesite-noreply
Comment #34 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 I added the file now (I think) and have many of the docstrings corrected. Updates pushed to runtest_3. -- You received this message because you are list

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-10 Thread codesite-noreply
Comment #35 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 All docstrings now pass on Windows. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred th

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-10 Thread codesite-noreply
Comment #36 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 On Linux too. Thank you a lot for all this work. Could you please rebase it a bit? There are commit messages like 'fix 4', basically saying no

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-10 Thread codesite-noreply
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #37 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 (No comment was entered for this change.) -- You received this message because you are l

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-10 Thread codesite-noreply
Comment #38 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 re symbols...I just used a find a replace to change most of them. There are some, especially those with assumptions, that remain. rebasing is finished,

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-10 Thread codesite-noreply
Comment #39 on issue 1671 by asmeurer: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 This still does not work for me: dhcp-baca-10:sympy aaronmeurer((8cfa7c2...)$)$./bin/test Traceback (most recent call last): File "./bin/test", line

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-10 Thread codesite-noreply
Comment #40 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 please try again...I added and committed the file. I don't think I did the commit before. -- You received this message because you are listed in the own

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-10 Thread codesite-noreply
Comment #41 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 I'm wondering if we might put in two options into doctest: -n --normal this would run a normal doctest (as stlid would run) -s --star this would giv

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-10 Thread codesite-noreply
Comment #42 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 After working on this issue for some time now, I leave a few notes. I'm not sure if here or in the commit message is the best place to put them. [*] I t

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-11 Thread codesite-noreply
Comment #43 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 You hav to write >>> from sympy.polys.galoispolys import (gf_from_dict, gf_diff, ... gf_sqf, gf_pow) like

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-12 Thread codesite-noreply
Comment #44 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 They are now sorted in reverse order (so editing doesn't throw off the numbers). Doctests are strict by default, normal when using -n option (use -h to

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-12 Thread codesite-noreply
Comment #45 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 ...tutorials still have "from sympy import *" in them, however. -- You received this message because you are listed in the owner or CC fields of this issu

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-26 Thread sympy
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #46 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 It looks very fine to me, Aaron, please test if the runtest_3 branch works for you so I

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-26 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #47 on issue 1671 by asmeurer: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 I get: sympy/utilities/tests/test_code_quality.py:test_no_trailing_whitespace_and_no_tabs

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-26 Thread sympy
Comment #48 on issue 1671 by asmeurer: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Also, one other thing: Aaron-Meurer:sympy aaronmeurer((a7839dd...)$)$./bin/doctest -h Usage: doctest [options] Options: -h, --help show this help

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-26 Thread sympy
Comment #49 on issue 1671 by asmeurer: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 The plotting tests seem to fail if pyglet is not installed. -- You received this message because you are listed in the owner or CC fields of this issue,

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-29 Thread sympy
Comment #50 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 OK, I've got Jorn as the author and me as the committer, but put in the notes which parts were by whom. /c -- You received this message because you are

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-29 Thread sympy
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #51 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Thanks for catching those, Aaron. The gotchas have been fixed and the -n option now reads "run norm

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-29 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #52 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Please rebase your branch on master. Also, I'm getting this failing doctest: File "/home/

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-29 Thread sympy
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #53 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Yep, I let Symbol stay in the namespace...I've taken it back out. Please try again. -- You receive

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-29 Thread sympy
Comment #54 on issue 1671 by asmeurer: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 The pyglet tests only fail if pyglet is not installed, so maybe if you uninstall pyglet you will see them. It seems that they fail in master too, so ma

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-11-29 Thread sympy
Comment #55 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 I don't know how to install or uninstall these. There is a pyglet folder in the thirdparty folder of sympy. Of course if I remove the folder then runtest

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-12-02 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #56 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Aaron, to which tests are you actually referring? I get no failing test, and I don't hav

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-12-02 Thread sympy
Comment #57 on issue 1671 by asmeurer: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 It seems that I was wrong. The tests are properly skipped in master, but it is broken in Chris's branch. My fink installation of Python doesn't have

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-12-02 Thread sympy
Comment #58 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 This looks like a bug in the pyglet version shipped with sympy, which is only triggered on mac. If you install it, maybe are more recent versio

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-12-02 Thread sympy
Comment #59 on issue 1671 by asmeurer: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Yes, skipping is the issue here, because it skips just fine in master. -- You received this message because you are listed in the owner or CC fields of t

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-12-02 Thread sympy
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #60 on issue 1671 by smichr: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Recent commit 356e808 added the line "import pyglet.window" to a try portion of the code in test_pl

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-12-03 Thread sympy
Comment #61 on issue 1671 by asmeurer: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 It seems you were right. It works now. The tests runner seems to work fine for me, though I haven't looked at the code. Is there anything else that n

Re: Issue 1671 in sympy: runtests modifications and docstring corrections

2009-12-04 Thread sympy
Updates: Status: Fixed Labels: -NeedsReview Comment #62 on issue 1671 by Vinzent.Steinberg: runtests modifications and docstring corrections http://code.google.com/p/sympy/issues/detail?id=1671 Nothing, this is in now. -- You received this message because you are listed in the