Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-12 Thread codesite-noreply
Status: Accepted Owner: jorn.baayen Labels: Type-Defect Priority-Medium NeedsReview New issue 1705 by jorn.baayen: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 This fixes an issue where the following ODE w

Re: Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-12 Thread codesite-noreply
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #1 on issue 1705 by asmeurer: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 Thanks for the patch. I've been waiting for some kind of bug to po

Re: Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-12 Thread codesite-noreply
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #2 on issue 1705 by jorn.baayen: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 Okay, done. Thanks for the review! Attachments: 0001-_s

Re: Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-12 Thread codesite-noreply
Updates: Cc: asmeurer Comment #3 on issue 1705 by smichr: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 I looked at this and things look good. Since this function is being edited (and since there

Re: Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-12 Thread codesite-noreply
Updates: Labels: -NeedsReview PassedReview Comment #4 on issue 1705 by asmeurer: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 I am +1 on the existing patch. If Jorn or Chris want to make more chan

Re: Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-13 Thread codesite-noreply
Updates: Labels: -PassedReview NeedsReview Comment #5 on issue 1705 by smichr: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 The changes I discussed above have been made and branch 1705 pushed to

Re: Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-26 Thread sympy
Updates: Status: Started Labels: -NeedsReview NeedsBetterPatch Comment #6 on issue 1705 by Vinzent.Steinberg: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 Looks fine to me (all tests pass),

Re: Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-28 Thread sympy
Updates: Cc: Vinzent.Steinberg Comment #7 on issue 1705 by smichr: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 I tried but was not successful in setting the author detail. If you can do that it's

Re: Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-29 Thread sympy
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #8 on issue 1705 by smichr: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 OK, I've got Jorn as the author and me as the committer, but put in th

Re: Issue 1705 in sympy: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected

2009-11-29 Thread sympy
Updates: Status: Fixed Labels: -NeedsReview Comment #9 on issue 1705 by Vinzent.Steinberg: [PATCH] _separatevars_dict: Fix issue where unintended symbols would be selected http://code.google.com/p/sympy/issues/detail?id=1705 It was not necessary to change the author, just credit