Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2011-01-07 Thread sympy
Updates: Status: Fixed Comment #17 on issue 1903 by asmeurer: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 OK. So if an issue has been pushed in and completely fixed, you can close it :) -- You received this message because you

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2011-01-07 Thread sympy
Comment #16 on issue 1903 by christian.muise: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 As Ronan stated, this has been pushed in. The concern raised on the final commit is no longer valid as the new sat solver doesn't use the p1_true

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2011-01-06 Thread sympy
Updates: Labels: -Milestone-Release0.7.0 Milestone-Release0.7.1 Comment #15 on issue 1903 by asmeurer: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 So what is the state of this? Is what remains still priority? -- You received this

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-07-10 Thread sympy
Comment #14 on issue 1903 by ronan.l...@gmail.com: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 It's in. I'll work on the last commit later, I don't think it's terribly important since pl_true isn't really used anywhere. -- You received

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-07-08 Thread sympy
Comment #13 on issue 1903 by ronan.l...@gmail.com: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 I understand that the review is positive except for the last commit, so I'll push everything but that last commit tomorrow. -- You received

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-06-14 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #12 on issue 1903 by Vinzent.Steinberg: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 Christian, your review is as official as any other one. :) The main goal is to catch thing

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-05-27 Thread sympy
Comment #11 on issue 1903 by asmeurer: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 By the way, you can just start working off of this branch before it gets merged in. It will probably increase its chances of being pushed in (because you

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-05-27 Thread sympy
Comment #10 on issue 1903 by asmeurer: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 You can set it up in your GitHub preferences to have it email you when someone comments on a commit after you. Also, I think if you watch Ronan's reposit

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-05-27 Thread sympy
Updates: Cc: ondrej.certik Comment #9 on issue 1903 by christian.muise: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 So I've gone through and left comments throughout all of the commits[0]. I'm not sure if I'll be notified for any

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-05-12 Thread sympy
Updates: Labels: NeedsReview Blockedon: -1928 Comment #8 on issue 1903 by ronan.l...@gmail.com: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 I've cleaned up the code, which is now ready for review in the branch "implement-Pr

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-05-01 Thread sympy
Updates: Cc: christian.muise Blockedon: 1928 Comment #7 on issue 1903 by ronan.l...@gmail.com: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 I think I've reached the end of what can be done without breaking backwards compatib

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-04-20 Thread sympy
Comment #6 on issue 1903 by Vinzent.Steinberg: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 No, it's a special read-only attribute. help(instance) always shows the docstring for the class. It's possible to overwrite it for functions and

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-04-20 Thread sympy
Comment #5 on issue 1903 by ronan.l...@gmail.com: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 Can't we just assign the __doc__ attribute? No, it's a special read-only attribute. help(instance) always shows the docstring for the class

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-04-19 Thread sympy
Updates: Cc: fab...@fseoane.net Comment #4 on issue 1903 by Vinzent.Steinberg: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 (No comment was entered for this change.) -- You received this message because you are listed in the owner

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-04-19 Thread sympy
Comment #3 on issue 1903 by Vinzent.Steinberg: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 Not simply, because Q.complex is still an ordinary object, not a class or a function. Can't we just assign the __doc__ attribute? +return e

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-04-18 Thread sympy
Comment #2 on issue 1903 by ronan.l...@gmail.com: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 Not simply, because Q.complex is still an ordinary object, not a class or a function. However, there are 2 ways to have docstrings: either make

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-04-18 Thread sympy
Comment #1 on issue 1903 by asmeurer: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 With this way, is it possible to have docstrings for the assumptions in Q, i.e., make help(Q.complex) work? -- You received this message because you are

Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-04-18 Thread sympy
Status: Started Owner: ronan.l...@gmail.com Labels: Type-Defect Priority-Medium Milestone-Release0.7.0 Assumptions New issue 1903 by ronan.l...@gmail.com: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 Assume keys, ask keys and ask handlers c