Status: Accepted
Owner: smichr
CC: ondrej.certik, asmeurer, Vinzent.Steinberg
Labels: Type-Defect Priority-Medium NeedsReview
New issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
A common idiom is to change an Eq back into a simple Basic
e
Updates:
Status: WontFix
Comment #19 on issue 1924 by smi...@gmail.com: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
(No comment was entered for this change.)
--
You received this message because you are subscribed to the Google Groups
"sympy-issues
Updates:
Status: Accepted
Comment #20 on issue 1924 by asmeu...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
Maybe as_basic() isn't the right name for it, but I do think there needs to
be a method to Eq (and perhaps the other relationa
Comment #21 on issue 1924 by matt...@gmail.com: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
Just to note: the name as_basic() is outdated. Now it should be as_expr(),
because this is the name that is use elsewhere (e.g. in polys). Anyway, I
already had s
Comment #22 on issue 1924 by asmeu...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
Yes, the name should be something like as_nonrelational (except there is
probably a better name than that). as_expr() doesn't make sense as noted
above since
Comment #23 on issue 1924 by matt...@gmail.com: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
as_expr() doesn't make sense as noted above since Eq is already an Expr.
Poly is an Expr, but it has as_expr() method. Almost everything is an Expr
but there is
Comment #24 on issue 1924 by smi...@gmail.com: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
I agree and see c17 above which responds to Ronan's previous comment.
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" gro
Updates:
Blockedon: 1887
Comment #25 on issue 1924 by ronan.l...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
c12 still stands: Eq(FiniteSet(1, 2), FiniteSet(1, 2, 3)) should return
what?
I don't think this can be reasonably implemen
Comment #26 on issue 1924 by ronan.l...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
c12 still stands: Eq(FiniteSet(1, 2), FiniteSet(1, 2, 3)) should return
what?
I meant Eq(FiniteSet(1, 2), FiniteSet(1, 2, 3)).as_expr(), obviously.
--
You
Comment #27 on issue 1924 by smi...@gmail.com: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
Perhaps, as I indicated before, we can consider this a case of garbage
in garbage out. And why would Eq keep that and not simply return
False?
--
You received this me
Comment #28 on issue 1924 by matt...@gmail.com: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
As a side note, I'm curious why:
In [1]: Eq(FiniteSet(1, 2), FiniteSet(1, 2, 3))
Out[1]: {1, 2} = {1, 2, 3}
although:
In [2]: Eq(1, 2)
Out[2]: False
I think [1] s
Comment #29 on issue 1924 by smi...@gmail.com: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
So there might be an _eval_Eq method, the default being to put the
objects in the lhs and rhs; for FiniteSet, the evaluation would be to
return True or False.
--
You
Comment #30 on issue 1924 by asmeu...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
As Ronan noted, the confusion here stems from issue 1887. We probably
should try to fix that first.
--
You received this message because you are subscribed t
Comment #1 on issue 1924 by ronan.l...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
Issue 1856 has been merged into this issue.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #2 on issue 1924 by ronan.l...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
I don't quite see the point of this. For me, eq.lhs - eq.rhs is easier to
write and
understand than eq.a
Updates:
Labels: -NeedsBetterPatch NeedsReview
Comment #3 on issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
This isn't a new proposal for a new function, so please look beyond the
name...or
think of it this way: there are ints an
Comment #4 on issue 1924 by Vinzent.Steinberg: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
Maybe as_basic should be renamed to as_expr?
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this
Comment #5 on issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
If there's a 2nd on this, I'll make the change.
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send e
Updates:
Cc: -asmeurer Ronan.Lamy
Comment #6 on issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
Hearing no second, I've just rebased this on master; it is branch 1924 at
smichr's github acct.
--
You received this message because
Updates:
Labels: -NeedsReview PassedReview
Comment #7 on issue 1924 by asmeurer: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
I am +1 on the change given in 799dbcb17ac243a791c8 (see github comments).
I do think that maybe as_basic() should be rena
Updates:
Labels: -PassedReview NeedsReview
Comment #8 on issue 1924 by ronan.l...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
Still -1. An Eq is already an instance of Basic, so it doesn't make sense
to convert it to Basic - unless th
Comment #9 on issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
Ronan, could you please give consideration to the difference between Basic
and basic just as we do for Integer and integer? Poly is also a Basic and
has this mechanism:
Po
Comment #10 on issue 1924 by ronan.l...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
"integer" has a clear meaning, "basic" doesn't. Besides, all Integers are
integers, but integers aren't necessarily Integers: your suggestion is
inconsisten
Comment #11 on issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
I'm sorry, I don't understand what you are referring to about Poly's
behavior. What I was trying to point out is that Poly(x, x, domain='ZZ') is
a Basic object. It has an .a
Comment #12 on issue 1924 by ronan.l...@gmail.com: Eq() gets .as_basic()
method
http://code.google.com/p/sympy/issues/detail?id=1924
What I'm saying is that Poly shouldn't have an .as_basic() method.
"as_expr" might be a better name, but there is a problem: there's no reason
for the members
Comment #13 on issue 1924 by Vinzent.Steinberg: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
Feel free to propose a better name. :) I don't really like as_expr(), but
it's the best name I could think of. And the purpose is indead to have Expr
instances.
Comment #14 on issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
Like this?
Eq(Eq(x,3),Eq(x,0))
(x == 3) == (x == 0)
A further problem I see with giving Eq this method is that, whereas Poly by
definition is something = 0, Eq is not. So t
Comment #15 on issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
In reviewing this, Aaron points out that such a routine allows solve to
behave in a polymorphic manner. Forget the name for a minute and consider
this scenario. I have an ec
Updates:
Labels: smichr
Comment #16 on issue 1924 by asmeurer: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
(No comment was entered for this change.)
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
Comment #17 on issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
In thinking about the above statement "there's no reason for the members of
the equality to be Exprs, so the result may be something that's not an
Expr, or it could even be
Updates:
Labels: -NeedsReview -smichr
Comment #18 on issue 1924 by smichr: Eq() gets .as_basic() method
http://code.google.com/p/sympy/issues/detail?id=1924
I'm removing the NeedsReview but I think the questions of the previous
comment should be discussed. Should this be raised in Disc
31 matches
Mail list logo
