Re: Issue 1926 in sympy: ode tweaks

Updates: Status: Fixed Comment #10 on issue 1926 by asmeurer: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 I have cherry-picked the 0fcd2423eb1809a77330 commit on master. It applied cleanly and tests passed. -- You received this message because you are subscribed

Re: Issue 1926 in sympy: ode tweaks

Comment #9 on issue 1926 by smichr: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 Here are some examples: [f(x) == (3*C1 + 3*x)**(1/3), f(x) == -(3*C1 + 3*x)**(1/3)/2 - I*3**(1/2)*(3*C1 + 3*x)**(1/3)/2, f(x) == -(3*C1 + 3*x)**(1/3)/2 + I*3**(1/2)*(3*C1 + 3*x)**(1/3)

Re: Issue 1926 in sympy: ode tweaks

Comment #8 on issue 1926 by smichr: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 regarding the test...there are odes that wanted to traverse that code but were not doing so before. Now they do. They weren't testing the code before but now they are. -- You received this m

Re: Issue 1926 in sympy: ode tweaks

Updates: Labels: smichr Comment #7 on issue 1926 by asmeurer: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this gro

Re: Issue 1926 in sympy: ode tweaks

Updates: Labels: -NeedsReview PassedReview NeedsBetterPatch Comment #6 on issue 1926 by asmeurer: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 Adding PassedReview too because everything is fine except for the lack of the test. -- You received this message because y

Re: Issue 1926 in sympy: ode tweaks

Comment #5 on issue 1926 by asmeurer: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 See my comment on github. I am +1 on commit 0fcd2423eb1809a77330, except that item 5c (4c in the commit message) should have a test, if I understand it correctly. -- You received this mes

Re: Issue 1926 in sympy: ode tweaks

Updates: Cc: asmeurer Vinzent.Steinberg Comment #4 on issue 1926 by smichr: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 This is now a single commit, rebased on the current master, ready for review in smichr's 1926 branch (note: NOT commit 1926 in 1766, a separate

Re: Issue 1926 in sympy: ode tweaks

Comment #3 on issue 1926 by smichr: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 Either place you make the change, things are going to break in ode. And I think you mean simplify(Eq) -> Eq(simplify(Eq.lhs), simplify(Eq.rhs))? -- You received this message because you are

Re: Issue 1926 in sympy: ode tweaks

Comment #2 on issue 1926 by asmeurer: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 1, 2, 3, and 4 are fine. 5a. Remember odesimp() is an internal function, so API things like this aren't that important. That being said, I don't remember how this works much, so your change

Re: Issue 1926 in sympy: ode tweaks

Updates: Labels: NeedsReview Comment #1 on issue 1926 by smichr: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 please review as commit 1926 in smichr's 1766 branch at github. (The change to the ode_or_bool section appears in the commit after 1926 if anyone wants to

Issue 1926 in sympy: ode tweaks

Status: Accepted Owner: smichr Labels: Type-Defect Priority-Medium New issue 1926 by smichr: ode tweaks http://code.google.com/p/sympy/issues/detail?id=1926 There are a variety of changes that accumulated to ode in my 1766 branch. These are some of the less major. 1) I get nervous when I see di