Issue 1942 in sympy: Refactor the singleton mechanism

2010-05-16 Thread sympy
Status: Started Owner: ronan.l...@gmail.com Labels: Type-Defect Priority-Medium Milestone-Release0.7.0 NeedsReview New issue 1942 by ronan.l...@gmail.com: Refactor the singleton mechanism http://code.google.com/p/sympy/issues/detail?id=1942 There are some issues with the singleton code which mak

Re: Issue 1942 in sympy: Refactor the singleton mechanism

2010-05-16 Thread sympy
Comment #1 on issue 1942 by asmeurer: Refactor the singleton mechanism http://code.google.com/p/sympy/issues/detail?id=1942 I haven't looked at it too much, but +1 for the change to sympy/core/__init__.py. I was just trying to figure out where oo was being imported from the other day, and I c

Re: Issue 1942 in sympy: Refactor the singleton mechanism

2010-06-14 Thread sympy
Comment #2 on issue 1942 by Vinzent.Steinberg: Refactor the singleton mechanism http://code.google.com/p/sympy/issues/detail?id=1942 Looks fine to me. Why should Singleton derive from Atom? Please add it to the commit message. The docstring should be fixed, but this can be done later. Yo

Re: Issue 1942 in sympy: Refactor the singleton mechanism

2010-09-01 Thread sympy
Updates: Labels: Ronan.Lamy Comment #3 on issue 1942 by asmeurer: Refactor the singleton mechanism http://code.google.com/p/sympy/issues/detail?id=1942 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "sympy-issues"

Re: Issue 1942 in sympy: Refactor the singleton mechanism

2010-10-29 Thread sympy
Comment #4 on issue 1942 by ronan.l...@gmail.com: Refactor the singleton mechanism http://code.google.com/p/sympy/issues/detail?id=1942 I had the wrong idea earlier. Being a Singleton is clearly a property of the class, not of the instance: S.One should behave the same whether it's define

Re: Issue 1942 in sympy: Refactor the singleton mechanism

2011-01-06 Thread sympy
Comment #5 on issue 1942 by jensen.oyvind: Refactor the singleton mechanism http://code.google.com/p/sympy/issues/detail?id=1942 I reviewed the pull request and I like it. But I am not so familiar with metaclass hacking, so perhaps one of the more experienced developers should have a look a

Re: Issue 1942 in sympy: Refactor the singleton mechanism

2011-01-06 Thread sympy
Updates: Labels: -NeedsReview PassedReview Comment #6 on issue 1942 by Vinzent.Steinberg: Refactor the singleton mechanism http://code.google.com/p/sympy/issues/detail?id=1942 Ronan is probably the most experienced developer we have. :) -- You received this message because you are su

Re: Issue 1942 in sympy: Refactor the singleton mechanism

2011-01-14 Thread sympy
Updates: Status: Fixed Comment #7 on issue 1942 by asmeurer: Refactor the singleton mechanism http://code.google.com/p/sympy/issues/detail?id=1942 I've pushed it in. -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group