Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2012-12-08 Thread sympy
Issue 2026: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 This issue is now blocking issue sympy:790. See http://code.google.com/p/sympy/issues/detail?id=790 -- You received this message because you are listed in the owner or CC fields of

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2012-10-30 Thread sympy
Issue 2026: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 This issue is no longer blocking issue sympy:1851. See http://code.google.com/p/sympy/issues/detail?id=1851 -- You received this message because you are listed in the owner or CC

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2012-10-14 Thread sympy
Updates: Labels: -NeedsReview Comment #32 on issue 2026 by julien.r...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 Not sure what remains to be done, but there is nothing to review. -- You received this message

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2012-10-03 Thread sympy
Issue 2026: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 This issue is now blocking issue sympy:1851. See http://code.google.com/p/sympy/issues/detail?id=1851 -- You received this message because you are listed in the owner or CC fields

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2012-09-13 Thread sympy
Issue 2026: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 This issue is now blocking issue sympy:2010. See http://code.google.com/p/sympy/issues/detail?id=2010 -- You received this message because you are listed in the owner or CC fields

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2012-09-13 Thread sympy
Issue 2026: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 This issue is now blocking issue sympy:2010. See http://code.google.com/p/sympy/issues/detail?id=2010 -- You received this message because you are listed in the owner or CC fields

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2012-03-16 Thread sympy
Comment #30 on issue 2026 by smi...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 documentation has been updated and 690 committed. -- You received this message because you are subscribed to the Google Groups sympy-issues

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-10-28 Thread sympy
Updates: Labels: NeedsReview Comment #28 on issue 2026 by ronan.l...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 https://github.com/sympy/sympy/pull/687 -- You received this message because you are subscribed to

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-23 Thread sympy
Comment #26 on issue 2026 by asmeurer: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 I misread the code. Please ignore my comments about in. My other comments are still valid, though. -- You received this message because you are

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-22 Thread sympy
Comment #22 on issue 2026 by ronan.l...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 I updated my branch (cf. comments 10, 12, 14). It's still at https://github.com/rlamy/sympy/commits/matching. The method is now called

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-22 Thread sympy
Comment #23 on issue 2026 by ronan.l...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 I updated my branch (cf. comments 10, 12, 14). It's still at https://github.com/rlamy/sympy/commits/matching. The method is now called

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-22 Thread sympy
Comment #24 on issue 2026 by ronan.l...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 I updated my branch (cf. comments 10, 12, 14). It's still at https://github.com/rlamy/sympy/commits/matching. The method is now called

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-22 Thread sympy
Comment #25 on issue 2026 by asmeurer: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 Your function is good, except it uses in, so I think it really needs issue 2389 to be fixed to be as semantically dumb as possible. Otherwise, I

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-11 Thread sympy
Comment #19 on issue 2026 by asmeurer: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 what should `sqrt(n).subs(n, 1)` be sqrt(1), that is, 1. subs should not make any assumptions about mathematical equality of old and new. The

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-11 Thread sympy
Comment #20 on issue 2026 by asmeurer: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 So I haven't read it deeply yet, but I get that the gist of Sebastian's idea was to make match contain all the intelligence wrt hints and to just

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-08 Thread sympy
Comment #17 on issue 2026 by Vinzent.Steinberg: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 Some older discussion on this (I think Sebastian even started working on it):

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-08 Thread sympy
Comment #18 on issue 2026 by smi...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 There's really another issue, too: what should `sqrt(n).subs(n, 1)` be if `n = Symbol('n', negative=True)`? 1, I, or should it raise an

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-07-07 Thread sympy
Issue 2026: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 This issue is now blocking issue 2081. See http://code.google.com/p/sympy/issues/detail?id=2081 -- You received this message because you are listed in the owner or CC fields of this

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-03-11 Thread sympy
Comment #15 on issue 2026 by ronan.l...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 So, this means that expr.replace(...) could be used as a primitive to do all kinds of transformations on expressions, including

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-03-10 Thread sympy
Comment #13 on issue 2026 by asmeurer: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 But we should keep something as low level as atomic substitution separate from pattern matching. In other words, you should be able to atomically

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-03-10 Thread sympy
Comment #14 on issue 2026 by ronan.l...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 replace() doesn't depend on matching, it just applies the substitution rule given to it. On the other hand, matching relies on replace()

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-03-09 Thread sympy
Updates: Status: Started Comment #10 on issue 2026 by ronan.l...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 In https://github.com/rlamy/sympy/commits/matching, I implemented atomic substitution as .replace().

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-03-09 Thread sympy
Comment #12 on issue 2026 by ronan.l...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 Actually, if you supply the right dict-like object, it can do everything the other replace() does. For instance, something like: class

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-02-07 Thread sympy
Comment #9 on issue 2026 by asmeurer: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 The third case is a bit specific, but very important to making certain algorithms work, particularly integrate(). I need to find the blocking

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-02-06 Thread sympy
Updates: Summary: Exact, algebraic, and integer_power substitution Comment #6 on issue 2026 by asmeurer: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 From comment 16 of issue 2081: But we need three types of substitution.

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-02-06 Thread sympy
Comment #7 on issue 2026 by ronan.l...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 The third case is really specific and it's just a detail of the behaviour of algebraic substitution, so I don't think it should placed on

Re: Issue 2026 in sympy: Exact, algebraic, and integer_power substitution

2011-02-06 Thread sympy
Comment #8 on issue 2026 by smi...@gmail.com: Exact, algebraic, and integer_power substitution http://code.google.com/p/sympy/issues/detail?id=2026 I would like to refer to these as exact and extractive (algebraic). The 3rd case is an extractive case. When you don't want the extractive