Re: Issue 2305 in sympy: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt)

2011-05-05 Thread sympy
Comment #11 on issue 2305 by gdrummo...@gmail.com: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) http://code.google.com/p/sympy/issues/detail?id=2305 Pull request has been merged. This issue can be closed. -- You received this message because you are subscribed to the Google

Re: Issue 2305 in sympy: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt)

2011-05-05 Thread sympy
Updates: Status: Fixed Labels: -NeedsReview PassedReview Comment #12 on issue 2305 by Vinzent.Steinberg: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) http://code.google.com/p/sympy/issues/detail?id=2305 Thanks. -- You received this message because you are

Re: Issue 2305 in sympy: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt)

2011-04-29 Thread sympy
Comment #10 on issue 2305 by matt...@gmail.com: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) http://code.google.com/p/sympy/issues/detail?id=2305 Related issue: 1801 -- You received this message because you are subscribed to the Google Groups sympy-issues group. To post to

Re: Issue 2305 in sympy: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt)

2011-04-28 Thread sympy
Comment #7 on issue 2305 by asmeurer: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) http://code.google.com/p/sympy/issues/detail?id=2305 Another inconsistency regarding methods to Integer: In [9]: S(2).gcd Out[9]: bound method Integer.gcd of 2 In [10]: S(2).igcd

Re: Issue 2305 in sympy: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt)

2011-04-28 Thread sympy
Comment #9 on issue 2305 by gdrummo...@gmail.com: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) http://code.google.com/p/sympy/issues/detail?id=2305 These methods have been added by Mateusz as part of polys. Removing them will break polys functionality. Some commits I

Re: Issue 2305 in sympy: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt)

2011-04-27 Thread sympy
Comment #5 on issue 2305 by ronan.l...@gmail.com: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) http://code.google.com/p/sympy/issues/detail?id=2305 That's better, but I still think it should be a function, not a method. -- You received this message because you are

Re: Issue 2305 in sympy: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt)

2011-04-27 Thread sympy
Comment #6 on issue 2305 by Vinzent.Steinberg: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) http://code.google.com/p/sympy/issues/detail?id=2305 I agree that it should be rather a function. We don't have Integer.pow(0.5) or similar. -- You received this message because

Re: Issue 2305 in sympy: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt)

2011-04-26 Thread sympy
Comment #3 on issue 2305 by gdrummo...@gmail.com: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) http://code.google.com/p/sympy/issues/detail?id=2305 Method renamed. Pull request submitted: https://github.com/sympy/sympy/pull/263 -- You received this message because you are

Re: Issue 2305 in sympy: Integer(3).sqrt() == 1

2011-04-25 Thread sympy
Comment #1 on issue 2305 by gdrummo...@gmail.com: Integer(3).sqrt() == 1 http://code.google.com/p/sympy/issues/detail?id=2305 The docstring says: Compute integer square root of `a`. It also uses an isqrt function from mpmath. Perhaps the method should be renamed to isqrt -- You received

Re: Issue 2305 in sympy: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt)

2011-04-25 Thread sympy
Updates: Summary: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) Comment #2 on issue 2305 by asmeurer: Integer(3).sqrt() == 1 (Rename Integer.sqrt to Integer.isqrt) http://code.google.com/p/sympy/issues/detail?id=2305 I think it should just be renamed to isqrt.

Issue 2305 in sympy: Integer(3).sqrt() == 1

2011-04-24 Thread sympy
Status: Accepted Owner: ronan.l...@gmail.com Labels: Type-Defect Priority-Critical WrongResult Milestone-Release0.7.0 New issue 2305 by ronan.l...@gmail.com: Integer(3).sqrt() == 1 http://code.google.com/p/sympy/issues/detail?id=2305 I don't think it really makes sense to have sqrt() as a