Issue 2308 in sympy: Rename or refactor Add.primitive()

2011-04-24 Thread sympy
Status: Accepted Owner: ronan.l...@gmail.com Labels: Type-Defect Priority-Medium Milestone-Release0.7.0 New issue 2308 by ronan.l...@gmail.com: Rename or refactor Add.primitive() http://code.google.com/p/sympy/issues/detail?id=2308 What Add.primitive() does is "Divide ``self`` by the GCD of coef

Re: Issue 2308 in sympy: Rename or refactor Add.primitive()

2011-04-24 Thread sympy
Comment #1 on issue 2308 by asmeurer: Rename or refactor Add.primitive() http://code.google.com/p/sympy/issues/detail?id=2308 Well the name is not really cryptic, since that is the mathematical definition of "primitive". See http://en.wikipedia.org/wiki/Gauss%27s_lemma_(polynomial). -- Yo

Re: Issue 2308 in sympy: Rename or refactor Add.primitive()

2011-04-25 Thread sympy
Comment #2 on issue 2308 by ronan.l...@gmail.com: Rename or refactor Add.primitive() http://code.google.com/p/sympy/issues/detail?id=2308 No, "primitive" doesn't mean that. If it means anything on its own, it's "antiderivative". So, you're actually suggesting that it should be renamed p

Re: Issue 2308 in sympy: Rename or refactor Add.primitive()

2011-04-26 Thread sympy
Comment #3 on issue 2308 by asmeurer: Rename or refactor Add.primitive() http://code.google.com/p/sympy/issues/detail?id=2308 Well, unfortunately, the word "primitive" has a bunch of completely different meanings (and all of them seem to be from algebra). See http://en.wikipedia.org/wiki/Pr

Re: Issue 2308 in sympy: Rename or refactor Add.primitive()

2011-05-17 Thread sympy
Updates: Blockedon: 2307 Comment #4 on issue 2308 by asmeurer: Rename or refactor Add.primitive() http://code.google.com/p/sympy/issues/detail?id=2308 It's easy to add a .primitive() method to Expr, but its implementation depends on what we decide to do in issue 2307. -- You received

Re: Issue 2308 in sympy: Rename or refactor Add.primitive()

2011-05-18 Thread sympy
Updates: Labels: asmeurer NeedsReview Comment #5 on issue 2308 by asmeurer: Rename or refactor Add.primitive() http://code.google.com/p/sympy/issues/detail?id=2308 So I went ahead and implemented Expr.primitive(), which just returns self.as_coeff_Mul(). As I mentioned on issue 2307, I

Re: Issue 2308 in sympy: Rename or refactor Add.primitive()

2011-05-18 Thread sympy
Updates: Status: NeedsDecision Comment #6 on issue 2308 by ronan.l...@gmail.com: Rename or refactor Add.primitive() http://code.google.com/p/sympy/issues/detail?id=2308 Argh! Please, no! If sin(x).primitive() exists, it should return something like cos(x). -- You received this mes

Re: Issue 2308 in sympy: Rename or refactor Add.primitive()

2011-05-18 Thread sympy
Comment #7 on issue 2308 by asmeurer: Rename or refactor Add.primitive() http://code.google.com/p/sympy/issues/detail?id=2308 You must be referring to http://en.wikipedia.org/wiki/Primitive_function. I've never heard of that use of the word before you mentioned it. I don't think it's commo

Re: Issue 2308 in sympy: Rename or refactor Add.primitive()

2011-05-18 Thread sympy
Comment #8 on issue 2308 by ronan.l...@gmail.com: Rename or refactor Add.primitive() http://code.google.com/p/sympy/issues/detail?id=2308 I never thought it was uncommon in English, but I'm not a native speaker. Still, http://www.google.com/search?client=ubuntu&channel=fs&q=%22the+primiti