Re: Issue 2340 in sympy: Float(1) returns Integer

2012-02-03 Thread sympy
Updates: Summary: Float(1) returns Integer Status: Accepted Labels: -NeedsReview Comment #4 on issue 2340 by ronan.l...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 I think that's still a problem. Float() should return an instan

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-10 Thread sympy
Comment #6 on issue 2340 by smi...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 Ronan is pointing out that Float of a Rational gives a Float but Float of an Integer (as the issue describes) does not give a Float: 219/13 Float(_) 16.8461538461538

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-15 Thread sympy
Comment #7 on issue 2340 by 16sn...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 Furthermore, the use of Float on zero is really weird. (see https://github.com/sympy/sympy/issues/1580#issuecomment-9456464) In short Float(0.0) returns an Integer, wh

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-15 Thread sympy
Updates: Cc: fredrik@gmail.com Comment #8 on issue 2340 by asmeu...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 There was an explanation for why this is somewhere in the issue tracker, but I can't find it. If we can remember what it was

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-16 Thread sympy
Comment #9 on issue 2340 by smi...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 Author: Fredrik Johansson 2008-05-25 20:25:27 Committer: Fredrik Johansson 2008-05-25 20:25:27 Parent: eb414788a6d0cb370a2edd664e405adc8001cc85 (implemented source

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-16 Thread sympy
Comment #10 on issue 2340 by asmeu...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 So chances are if you change the behavior, it will lead to some test failures. I guess try it and see what happens. -- You received this message because you are subs

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-16 Thread sympy
Comment #12 on issue 2340 by asmeu...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 By the way, what command did you use to get the commit output in that form? -- You received this message because you are subscribed to the Google Groups "sympy-issues"

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-16 Thread sympy
Comment #11 on issue 2340 by asmeu...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 By the way, what command did you use to get the commit output in that form? -- You received this message because you are subscribed to the Google Groups "sympy-issues"

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-18 Thread sympy
Comment #13 on issue 2340 by 16sn...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 I made the change. As you predicted some tests failed, but I think they were actually caused by a bug in simplify (which should now be fixed). See https://github.com/s

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-18 Thread sympy
Updates: Labels: NeedsReview Comment #14 on issue 2340 by asmeu...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "sympy-issu

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-21 Thread sympy
Comment #15 on issue 2340 by smi...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 Aaron, regarding the commit output, I think I just copied and pasted from a gitk window. -- You received this message because you are subscribed to the Google Groups

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-21 Thread sympy
Updates: Status: Fixed Comment #16 on issue 2340 by smi...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "sympy-issues" grou

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-10-24 Thread sympy
Comment #17 on issue 2340 by 16sn...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 I just found another potential issue, which wasn't fixed in the recent PR: >>> Float(1.0) - Float(1.0) 0 It should probably return a Float (0.0). Similar things h

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-11-29 Thread sympy
Updates: Status: Valid Comment #18 on issue 2340 by smi...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 The issues in the previous comment should be resolved. -- You received this message because you are subscribed to the Google Groups "sympy

Re: Issue 2340 in sympy: Float(1) returns Integer

2012-11-29 Thread sympy
Updates: Status: Fixed Comment #19 on issue 2340 by smi...@gmail.com: Float(1) returns Integer http://code.google.com/p/sympy/issues/detail?id=2340 I'll move the last comments to issue 3446 -- You received this message because you are subscribed to the Google Groups "sympy-issues" grou