Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-09-04 Thread sympy
Status: Accepted Owner: vlada.pe...@gmail.com Labels: Type-Defect Priority-Low Python3 New issue 2674 by vlada.pe...@gmail.com: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 A helper function, cmp_to_key, was introduced with commit d68d33. The

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-10-09 Thread sympy
Updates: Cc: matt...@gmail.com Comment #6 on issue 2674 by vlada.pe...@gmail.com: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 Hmmm. Mateusz did some recent work related to this so I have to redo my branch from scratch (not yet ready).

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-10-10 Thread sympy
Comment #7 on issue 2674 by asmeurer: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 That's a reasonable possibility. Otherwise, we just keep cmp_to_key around until we drop the old ordering. To quote Mateusz on the other issue, "The old order

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-10-10 Thread sympy
Issue 2674: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 This issue is no longer blocking issue 1491. See http://code.google.com/p/sympy/issues/detail?id=1491 -- You received this message because you are listed in the owner or CC fields of this issu

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-10-10 Thread sympy
Updates: Blockedon: 1491 Comment #9 on issue 2674 by vlada.pe...@gmail.com: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 Alright, so based on the other issue, we'll drop old ordering two versions from now, so this is blocked on that.

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-10-10 Thread sympy
Comment #10 on issue 2674 by vlada.pe...@gmail.com: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 Alright, so based on the other issue, we'll drop old ordering two versions from now, so this is blocked on that. Or, again, I could just not def

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-09-04 Thread sympy
Issue 2674: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 This issue is now blocking issue 1491. See http://code.google.com/p/sympy/issues/detail?id=1491 -- You received this message because you are listed in the owner or CC fields of this issue, or

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-09-10 Thread sympy
Updates: Status: Started Comment #2 on issue 2674 by vlada.pe...@gmail.com: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 Well, this was embarrassingly simple to fix actually. As you said, most of the uses of Basic.compare_pretty can be

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-09-11 Thread sympy
Updates: Cc: asmeurer Comment #3 on issue 2674 by vlada.pe...@gmail.com: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 Aaron, I've applied your patch (https://gist.github.com/1208773) but it unfortunately breaks other things, see the at

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-09-11 Thread sympy
Comment #4 on issue 2674 by asmeurer: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 Can you push this up to a branch? -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group, send

Re: Issue 2674 in sympy: Remove the cmp_to_key() helper function

2011-09-11 Thread sympy
Comment #5 on issue 2674 by vlada.pe...@gmail.com: Remove the cmp_to_key() helper function http://code.google.com/p/sympy/issues/detail?id=2674 Check the cmp_to_key branch. Expect rebases. Thanks for taking a look at this, I'm a bit lost. -- You received this message because you are subsc