Re: Issue 2979 in sympy: and = are changed into and =

2012-02-08 Thread sympy
Updates: Status: Fixed Comment #7 on issue 2979 by smi...@gmail.com: and = are changed into and = http://code.google.com/p/sympy/issues/detail?id=2979 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups

Re: Issue 2979 in sympy: and = are changed into and =

2012-02-08 Thread sympy
Updates: Labels: -NeedsReview Comment #8 on issue 2979 by smi...@gmail.com: and = are changed into and = http://code.google.com/p/sympy/issues/detail?id=2979 It ended up at See https://github.com/sympy/sympy/pull/990 Note that the gotcha noted in relational.py can't(?) be

Re: Issue 2979 in sympy: and = are changed into and =

2012-01-12 Thread sympy
Comment #5 on issue 2979 by hunt...@gmail.com: and = are changed into and = http://code.google.com/p/sympy/issues/detail?id=2979 Okay, I've implemented this, and all tests pass but about 6 or 7. I need someone else's help with those however, as some of those tests are *not* my area of

Re: Issue 2979 in sympy: and = are changed into and =

2012-01-12 Thread sympy
Updates: Labels: NeedsReview Comment #6 on issue 2979 by asmeu...@gmail.com: and = are changed into and = http://code.google.com/p/sympy/issues/detail?id=2979 You did it correctly. One thing that you should do differently in the future is commit on a different branch from

Re: Issue 2979 in sympy: and = are changed into and =

2012-01-11 Thread sympy
Comment #2 on issue 2979 by asmeu...@gmail.com: and = are changed into and = http://code.google.com/p/sympy/issues/detail?id=2979 I don't follow exactly what the direction flag would do. I see two basic ways to fix this: 1. Keep it like it is, but keep track inside the Inequality object

Re: Issue 2979 in sympy: and = are changed into and =

2012-01-11 Thread sympy
Comment #3 on issue 2979 by hunt...@gmail.com: and = are changed into and = http://code.google.com/p/sympy/issues/detail?id=2979 Only having idly glanced through the Sympy codebase, option 2 of those would seem to me more Sympyonic. My area of largest interest or concern is memory

Re: Issue 2979 in sympy: and = are changed into and =

2012-01-11 Thread sympy
Comment #4 on issue 2979 by asmeu...@gmail.com: and = are changed into and = http://code.google.com/p/sympy/issues/detail?id=2979 No, you are right. lhs and rhs should stay. They would be a little confusing if we choose option 1 is all. I too tend to think that option 2 is better.

Issue 2979 in sympy: and = are changed into and =

2012-01-10 Thread sympy
Status: Accepted Owner: Labels: Type-Defect Priority-Medium New issue 2979 by asmeu...@gmail.com: and = are changed into and = http://code.google.com/p/sympy/issues/detail?id=2979 Greater than inequalities are converted into less than inequalities. In [28]: x y Out[28]: x y In [29]:

Re: Issue 2979 in sympy: and = are changed into and =

2012-01-10 Thread sympy
Comment #1 on issue 2979 by smi...@gmail.com: and = are changed into and = http://code.google.com/p/sympy/issues/detail?id=2979 You could add a direction flag +/-1 which doesn't get printed. When comparing they should compare taking the direction into account so x y == y x. lhs and