Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-11 Thread sympy
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 multiset_partitions does not seem to be generating all possible partit

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-11 Thread sympy
Updates: Status: Valid Labels: WrongResult Combinatorics Comment #1 on issue 3501 by asmeu...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 (No comment was entered for this change.) -- You

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-12 Thread sympy
Comment #2 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 This is very pertinent issue since I just committed kbins which depends on this. I think this is different, because an empt

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-13 Thread sympy
Comment #3 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Does this look better? [2, 2, 2, 84] [2, 2, 3, 56] [2, 2, 4, 42] [2, 2, 4, 42] [2, 2, 4, 42] [2, 2, 6, 28] [2, 2, 6, 28] [2,

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-13 Thread sympy
Comment #4 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 The relevant Knuth reference is Algorithm M, (Multipartitions in decreasing lexicographic order), page 429 of volume 4

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-13 Thread sympy
Comment #5 on issue 3501 by asmeu...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Is there a combinatorial formula to count these? That could also serve as a check. -- You received this message becaus

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-13 Thread sympy
Comment #6 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Oops - scratch the Sage reference I gave at the end of comment #4. The class subset.py in sage enumerates the *subset

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-13 Thread sympy
Comment #7 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Here is a failing test for the partitions of range(5) into 2 groups: Should be for ai in a: ... print ai ... ((0, 1, 3,

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-15 Thread sympy
Comment #8 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Could you post a picture/scan of the pertinent page? I don't have access to it here. -- You received this message because

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-15 Thread sympy
Updates: Labels: NeedsReview smichr Comment #9 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 I added a different routine. Perhaps the Knuth routine will find its way back,

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-15 Thread sympy
Updates: Labels: -Priority-Medium Priority-Critical Comment #10 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 (No comment was entered for this change.) -- You received this

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-15 Thread sympy
Comment #11 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Re:posting 8. I was going to point you to the oracle himself. Knuth still has the fasicles on his web page. See <

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-15 Thread sympy
Comment #12 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 If 'ans' is the list of permutations that you want to make canonical, try set( [tuple(sorted([tuple(sorted(j)) for j in i])

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-15 Thread sympy
Comment #13 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 btw, thanks for the reference to the Knuth fascicle. I used a different source for the new algorithm: http://www.math.up

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-16 Thread sympy
Comment #14 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Thanks for your implementation of https://github.com/sympy/sympy/pull/1658, and for pointing me to the Wilf reference

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-16 Thread sympy
Comment #15 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Can you explain what you mean by "exposing the core of your code as a set partitions implementation"? I think I might get

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-17 Thread sympy
Comment #16 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Sorry for any confusion. I am not using the terminology consistently and am probably (still) a bit confused by the rel

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-17 Thread sympy
Comment #17 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Thanks for your clarifying comments. multiset_partitions is now a clearing house for any enumerations of sets (with or wi

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-17 Thread sympy
Comment #18 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 I would like to have multiset working even if less than optimally. Is it ok with you to commit what is there, pkrathmann2?

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-18 Thread sympy
Comment #19 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 btw, the old multiset code didn't look at the values of the multiset. Unless a routine does, I don't know how anything cou

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-19 Thread sympy
Comment #20 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Re comment 17 - Great! With a general dispatcher routine, if/when 7.2.1.5m working, can be later integrated, for those

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-20 Thread sympy
Comment #21 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Hello, I have had a chance to look at the pull request, and perform some testing. (I see that you are adding more com

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-20 Thread sympy
Comment #22 on issue 3501 by asmeu...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Re your Git workflow: I don't know if git checkout sets up the branch to track by default. See if git pull updates the b

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-20 Thread sympy
Comment #23 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 git checkout -b kbins smichr/kbins That's what I would do...looks good. You *might* consider adding something lik

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-20 Thread sympy
Comment #24 on issue 3501 by asmeu...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Your last line got cut off there. -- You received this message because you are subscribed to the Google Groups "sympy-is

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-20 Thread sympy
Comment #25 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 sorry...that was timeit('RGS_enum(23)','from sympy import bell as RGS_enum', number=100) 0.0007009506225585938 -- You

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-20 Thread sympy
Comment #26 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Great! This looks good to commit. (With caveat that I am just getting my feet wet with Sympy.) Nits (which I don't n

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-20 Thread sympy
Comment #27 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 OK, that's done now, too. Your feedback has been very helpful. Thank you. Now if I can figure out why some of the tests ar

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-21 Thread sympy
Updates: Status: Fixed Comment #28 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 It's in...all partitions are now generated. -- You received this message because you are su

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-21 Thread sympy
Comment #29 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 pkrathmann2: is there a chance you could look over PR https://github.com/sympy/sympy/pull/1666 ? It fixes (with pretty sim

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-23 Thread sympy
Comment #30 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 It's in...all partitions are now generated. Awesome. Congratulations, this has been fun. ... look over PR https://

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-23 Thread sympy
Updates: Status: Valid Comment #31 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Good news: round 2! If you could carefully look over https://github.com/sympy/sympy/pull/1

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-11-29 Thread sympy
Updates: Status: Fixed Comment #32 on issue 3501 by smi...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 (No comment was entered for this change.) -- You received this message because you are subsc

Re: Issue 3501 in sympy: Missing partitions in sympy.utilities.iterables.multiset_partitions

2012-12-04 Thread sympy
Comment #33 on issue 3501 by pkrathma...@gmail.com: Missing partitions in sympy.utilities.iterables.multiset_partitions http://code.google.com/p/sympy/issues/detail?id=3501 Entered comments (on the github pages) for pull requests 1671 and 1666. -- You received this message because you are s