Updates:
Status: Fixed
Labels: -NeedsReview
Comment #19 on issue 415 by ronan.l...@gmail.com: sqrt(6)/2*sqrt(2) does
not auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
It seems this had been forgotten. I'm +1 and it rebases cleanly, so I've
Updates:
Cc: ondrej.certik Ronan.Lamy
Comment #17 on issue 415 by Vinzent.Steinberg: sqrt(6)/2*sqrt(2) does not
auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
So it is up to 2.2 times slower with your change, but correct. I'm fine
with this,
but don't
Comment #18 on issue 415 by asmeurer: sqrt(6)/2*sqrt(2) does not
auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
Mul only reflattens when it needs to, that is, when it can potentially pull
out a constant from a power. As I noted
in the commit message, a simple
Updates:
Labels: -NeedsBetterPatch NeedsReview
Comment #16 on issue 415 by asmeurer: sqrt(6)/2*sqrt(2) does not
auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
I have added some performance information to the commit, and also rebased
over the latest
Updates:
Labels: -PassedReview NeedsBetterPatch
Comment #15 on issue 415 by Vinzent.Steinberg: sqrt(6)/2*sqrt(2) does not
auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
The performance test could be in the commit message.
--
You received this message
Updates:
Labels: -NeedsReview PassedReview
Comment #13 on issue 415 by ondrej.certik: sqrt(6)/2*sqrt(2) does not
auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
If all tests pass, it's +1.
My experience with these changes it that it breaks something else,
Comment #14 on issue 415 by Vinzent.Steinberg: sqrt(6)/2*sqrt(2) does not
auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
Before pushing this in, we'll need to test the performance impact.
--
You received this message because you are listed in the owner
or CC
Updates:
Cc: Vinzent.Steinberg
Labels: NeedsReview
Comment #12 on issue 415 by asmeurer: sqrt(6)/2*sqrt(2) does not
auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
I figured it out. Around line 256 of mul.py:
else:
obj
Updates:
Owner: asmeurer
Comment #11 on issue 415 by Vinzent.Steinberg: sqrt(6)/2*sqrt(2) does not
auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
(No comment was entered for this change.)
--
You received this message because you are listed in the owner
or
Updates:
Summary: sqrt(6)/2*sqrt(2) does not auto-simplify properly
Comment #10 on issue 415 by asmeurer: sqrt(6)/2*sqrt(2) does not
auto-simplify properly
http://code.google.com/p/sympy/issues/detail?id=415
Remembering that Python associates * and / to the left:
In [12]:
10 matches
Mail list logo
