Darn, I will look into this... Brian
On Mon, Mar 22, 2010 at 2:04 PM, Aaron S. Meurer <asmeu...@gmail.com> wrote: > Sorry, I get some errors: > ________________________________________________________________________________ > sympy/utilities/tests/test_code_quality.py:test_no_trailing_whitespace_and_no_tabs > File > "/users/aaronmeurer/documents/python/sympy/sympy/sympy/utilities/tests/test_code_quality.py", > line 75, in test_no_trailing_whitespace_and_no_tabs > check_directory_tree(sympy_path) > File > "/users/aaronmeurer/documents/python/sympy/sympy/sympy/utilities/tests/test_code_quality.py", > line 47, in check_directory_tree > assert False, message_space % (fname, idx+1) > AssertionError: File contains trailing whitespace: > /users/aaronmeurer/documents/python/sympy/sympy/sympy/solvers/tests/test_ode.py, > line 1060. > > tests finished: 1757 passed, 1 failed, 9 skipped, 44 expected to fail, > 1 expected to fail but passed, in 1028.57 seconds > DO *NOT* COMMIT! > > And also doctest failures: > > ______________ sympy.functions.special.bsplines.bspline_basis_set > ______________ > File > "/Users/aaronmeurer/Documents/Python/sympy/sympy/sympy/functions/special/bsplines.py", > line 117, in sympy.functions.special.bsplines.bspline_basis_set > Failed example: > splines = bspline_basis_set(d, knots, x) > Exception raised: > Traceback (most recent call last): > File > "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", > line 1241, in __run > compileflags, 1) in test.globs > File "<doctest sympy.functions.special.bsplines.bspline_basis_set[2]>", > line 1, in <module> > splines = bspline_basis_set(d, knots, x) > NameError: name 'bspline_basis_set' is not defined > ********************************************************************** > File > "/Users/aaronmeurer/Documents/Python/sympy/sympy/sympy/functions/special/bsplines.py", > line 118, in sympy.functions.special.bsplines.bspline_basis_set > Failed example: > splines > Exception raised: > Traceback (most recent call last): > File > "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", > line 1241, in __run > compileflags, 1) in test.globs > File "<doctest sympy.functions.special.bsplines.bspline_basis_set[3]>", > line 1, in <module> > splines > NameError: name 'splines' is not defined > ________________________________________________________________________________ > ________________ sympy.functions.special.bsplines.bspline_basis > ________________ > File > "/Users/aaronmeurer/Documents/Python/sympy/sympy/sympy/functions/special/bsplines.py", > line 37, in sympy.functions.special.bsplines.bspline_basis > Failed example: > bspline_basis(d, knots, 0, x) > Exception raised: > Traceback (most recent call last): > File > "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", > line 1241, in __run > compileflags, 1) in test.globs > File "<doctest sympy.functions.special.bsplines.bspline_basis[2]>", line > 1, in <module> > bspline_basis(d, knots, 0, x) > NameError: name 'bspline_basis' is not defined > ********************************************************************** > File > "/Users/aaronmeurer/Documents/Python/sympy/sympy/sympy/functions/special/bsplines.py", > line 45, in sympy.functions.special.bsplines.bspline_basis > Failed example: > bspline_basis(3, range(5), 0, x) > Exception raised: > Traceback (most recent call last): > File > "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", > line 1241, in __run > compileflags, 1) in test.globs > File "<doctest sympy.functions.special.bsplines.bspline_basis[3]>", line > 1, in <module> > bspline_basis(3, range(5), 0, x) > NameError: name 'bspline_basis' is not defined > ********************************************************************** > File > "/Users/aaronmeurer/Documents/Python/sympy/sympy/sympy/functions/special/bsplines.py", > line 53, in sympy.functions.special.bsplines.bspline_basis > Failed example: > bspline_basis(d, knots, 0, x) > Exception raised: > Traceback (most recent call last): > File > "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", > line 1241, in __run > compileflags, 1) in test.globs > File "<doctest sympy.functions.special.bsplines.bspline_basis[6]>", line > 1, in <module> > bspline_basis(d, knots, 0, x) > NameError: name 'bspline_basis' is not defined > ********************************************************************** > File > "/Users/aaronmeurer/Documents/Python/sympy/sympy/sympy/functions/special/bsplines.py", > line 62, in sympy.functions.special.bsplines.bspline_basis > Failed example: > b0 = bspline_basis(d, knots, 0, x) > Exception raised: > Traceback (most recent call last): > File > "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", > line 1241, in __run > compileflags, 1) in test.globs > File "<doctest sympy.functions.special.bsplines.bspline_basis[9]>", line > 1, in <module> > b0 = bspline_basis(d, knots, 0, x) > NameError: name 'bspline_basis' is not defined > ********************************************************************** > File > "/Users/aaronmeurer/Documents/Python/sympy/sympy/sympy/functions/special/bsplines.py", > line 63, in sympy.functions.special.bsplines.bspline_basis > Failed example: > f = lambdify(x, b0) > Exception raised: > Traceback (most recent call last): > File > "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", > line 1241, in __run > compileflags, 1) in test.globs > File "<doctest sympy.functions.special.bsplines.bspline_basis[10]>", > line 1, in <module> > f = lambdify(x, b0) > NameError: name 'lambdify' is not defined > ********************************************************************** > File > "/Users/aaronmeurer/Documents/Python/sympy/sympy/sympy/functions/special/bsplines.py", > line 64, in sympy.functions.special.bsplines.bspline_basis > Failed example: > f(0.5) > Exception raised: > Traceback (most recent call last): > File > "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/doctest.py", > line 1241, in __run > compileflags, 1) in test.globs > File "<doctest sympy.functions.special.bsplines.bspline_basis[11]>", > line 1, in <module> > f(0.5) > NameError: name 'f' is not defined > > And for the doctests that take up much more than 80 characters, you can > shorten them by doing something like: > >>>> bspline_basis(3, range(5), 0, x) == Piecewise((x**3/6, [0, 1)), (2/3 - 2*x >>>> + 2*x**2 - x**3/2, [1, 2)), > … (-22/3 + 10*x - 4*x**2 + x**3/2, [2, 3)), (32/3 - 8*x + 2*x**2 - x**3/6, > [3, 4]), (0, True)) > True > > Also, it would be nice if this explained that only numerical arguments are > accepted, instead of just raising TypeError for int(x): > > In [8]: bspline_basis(y, range(6), 0, x) > --------------------------------------------------------------------------- > TypeError Traceback (most recent call last) > > /Users/aaronmeurer/Documents/Python/sympy/sympy/<ipython console> in > <module>() > > /Users/aaronmeurer/Documents/Python/sympy/sympy/sympy/functions/special/bsplines.py > in bspline_basis(d, knots, n, x, close) > 68 """ > 69 knots = [sympify(k) for k in knots] > ---> 70 d = int(d) > 71 n = int(n) > 72 n_knots = len(knots) > > TypeError: int() argument must be a string or a number, not 'Symbol' > > At any rate, it should be tested. Use raises(). > > BTW, we still need to see how it rebases over the latest master with the new > polys, though hopefully there won't be any problems. > > Aaron Meurer > On Mar 21, 2010, at 12:15 PM, Brian Granger wrote: > >> OK, I have addressed all review comments. My branch should be ready to >> merge. >> >> Cheers, >> >> Brian >> >> On Thu, Mar 18, 2010 at 4:11 PM, Brian Granger <ellisonbg....@gmail.com> >> wrote: >>> I am going to try to get on this soon. >>> >>> Cheers, >>> >>> Brian >>> >>> On Fri, Mar 12, 2010 at 10:10 AM, Aaron S. Meurer <asmeu...@gmail.com> >>> wrote: >>>> Seenu comment at github. >>>> >>>> Aaron Meurer >>>> Sent from my iPod touch. >>>> On Mar 10, 2010, at 4:08 PM, Brian Granger <ellisonbg....@gmail.com> wrote: >>>> >>>> Hi, >>>> >>>> I have improved the Piecewise class and implemented B-splines. Here is the >>>> branch on github: >>>> >>>> http://github.com/ellisonbg/sympy/tree/bg-piecewise >>>> >>>> There are tests for everything I have added and docstrings/doctests. I >>>> would love comments and feedback. >>>> >>>> Cheers, >>>> >>>> Brian >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "sympy-patches" group. >>>> To post to this group, send email to sympy-patc...@googlegroups.com. >>>> To unsubscribe from this group, send email to >>>> sympy-patches+unsubscr...@googlegroups.com. >>>> For more options, visit this group at >>>> http://groups.google.com/group/sympy-patches?hl=en. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "sympy-patches" group. >>>> To post to this group, send email to sympy-patc...@googlegroups.com. >>>> To unsubscribe from this group, send email to >>>> sympy-patches+unsubscr...@googlegroups.com. >>>> For more options, visit this group at >>>> http://groups.google.com/group/sympy-patches?hl=en. >>>> >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy-patches" group. >> To post to this group, send email to sympy-patc...@googlegroups.com. >> To unsubscribe from this group, send email to >> sympy-patches+unsubscr...@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/sympy-patches?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "sympy-patches" group. > To post to this group, send email to sympy-patc...@googlegroups.com. > To unsubscribe from this group, send email to > sympy-patches+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/sympy-patches?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
