Fixed a bug causing DPLL to think satisfiable theories are unsat.

2010-03-29 Thread Christian Muise
There was a critical bug in the DPLL procedure for sat theories that didn't contain any unit clauses or pure literals. - git://github.com/haz/sympy.git - Branch: sat-bug -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, se

Re: Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-29 Thread jegerjensen
> I think we should get rid of cmp in the long term. It's not supported in > Python 3 and it is confusing to use comparisons just for canonical ordering. > This should be rather in an own function, there is also the 'key' keyword > argument to the built-in sort(). I just realized that changing to

Re: [PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-29 Thread Øyvind Jensen
great, thanks! ma., 29.03.2010 kl. 18.53 +0200, skrev Vinzent Steinberg: > 2010/3/29 Øyvind Jensen : > > Fixed the spacing and pushed to tha branch fix__lt__3. > > > > The parentheses around (a < b) are necessary, else it is interpreted as > > assert (a < b == Lt(a, b)). > > Thanks, this is in! >

Re: [PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-29 Thread Vinzent Steinberg
2010/3/29 Øyvind Jensen : > Fixed the spacing and pushed to tha branch fix__lt__3. > > The parentheses around (a < b) are necessary, else it is interpreted as > assert (a < b == Lt(a, b)). Thanks, this is in! Vinzent -- You received this message because you are subscribed to the Google Groups

Re: [PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-29 Thread Øyvind Jensen
Fixed the spacing and pushed to tha branch fix__lt__3. The parentheses around (a < b) are necessary, else it is interpreted as assert (a < b == Lt(a, b)). Øyvind ma., 29.03.2010 kl. 13.21 +0200, skrev Vinzent Steinberg: > 2010/3/29 Øyvind Jensen : > >> I think he meant to put commutative=False,

Re: [PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-29 Thread Vinzent Steinberg
2010/3/29 Øyvind Jensen : >> I think he meant to put commutative=False, not noncommutative=True. > > Exactly, I put up another branch fix__lt__2, where this is fixed. Thanks! I'm +1 for this one. I have only a few minor stylistic remarks: +assert (ab) == Gt(a,b) +assert (a>=b) == Ge(a,b)

Re: [PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-29 Thread Øyvind Jensen
> I think he meant to put commutative=False, not noncommutative=True. Exactly, I put up another branch fix__lt__2, where this is fixed. > It's weird that Symbol will let you create nonexistent assumptions > on it: But that can be quite useful: In [4]: r = Symbol('r',something=True) In [5]: r