Re: review request

2010-05-11 Thread smichr
In the meanwhile, I've used Øyvind's hint to create branches numbered as to commit number for all the commits in review and pushed them to github. In cases where there are additions (like 1725a 1725b 1725c, those are all in branch 1725). ff50ca5 1936: Integral and Sum edits c2a77c6 1919: unify var

Re: review request

2010-05-11 Thread Vinzent Steinberg
2010/5/11 smichr > > > > I hope I am not adding confusion here, but I think Vincent just asked > > for something like > > > > ]$ git branch 1766-for-review ff50ca5221a22e9b80d1 > > > > Øyvind > > That's a helpful hint Øyvind. I see that that creates a branch with > the indicated commit as the HEA

Re: review request

2010-05-11 Thread smichr
> > I hope I am not adding confusion here, but I think Vincent just asked > for something like > > ]$ git branch 1766-for-review ff50ca5221a22e9b80d1 > > Øyvind That's a helpful hint Øyvind. I see that that creates a branch with the indicated commit as the HEAD. I'm willing to do what is most help

Re: review request

2010-05-11 Thread Øyvind Jensen
ti., 11.05.2010 kl. 02.36 -0700, skrev smichr: > > > As I already said, it would be much easier if you could create another > > > branch for review (1766-for-review) which contains only "stable" changes. > > > This would help to get it in faster. > > The commits before "1766--"

Re: review request

2010-05-11 Thread smichr
> > Do all tests (including the code quality) work for you? If so, we need > to improve this. You said "without the first commit". Do you mean without the latest commit? In any case, all solvers.py tests pass in all commits. The equal() can be used too make these pass on 32 or 64 bit systems if n

Re: review request

2010-05-11 Thread smichr
> > As I already said, it would be much easier if you could create another > > branch for review (1766-for-review) which contains only "stable" changes. > > This would help to get it in faster. The commits before "1766--" are stable. I am not changing those. I am only, as revie