Re: [PATCH 3/4] Added tests for free-form fortran code + fix bug in comment line wrapping

Looks good. Vinzent 2010/6/9 Øyvind Jensen : > --- >  sympy/printing/fcode.py            |    2 +- >  sympy/printing/tests/test_fcode.py |   26 -- >  2 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/sympy/printing/fcode.py b/sympy/printing/fcode.py > inde

Re: [PATCH 1/4] move function wrap_fortran() to FCodePrinter._wrap_fortran()

Looks good, but I don't like the commit message, it's not very clear from the first line that you actually change the code logic. Vinzent 2010/6/9 Øyvind Jensen : > This will let the line wrapping function respect settings of the fortran > printer. > --- >  sympy/printing/fcode.py            |  1

Re: [PATCH 2/4] Implemented optional free-form source format for Fortran code printer

What about updating the docstring? 2010/6/9 Øyvind Jensen : > fcode takes a new keyword:   source_format='fixed'|'free' > --- >  sympy/printing/fcode.py            |   71 > >  sympy/printing/tests/test_fcode.py |    6 ++-- >  2 files changed, 58 insertions(+),

Re: [PATCH] Fixes failing test due to AttributeError in matplotlib version 0.91.2 (Issue 1956)

+1 On Sun, Jun 13, 2010 at 2:17 AM, Øyvind Jensen wrote: > --- >  sympy/mpmath/tests/test_visualization.py |    8 ++-- >  1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/sympy/mpmath/tests/test_visualization.py > b/sympy/mpmath/tests/test_visualization.py > index 7ecfb7e..4