Re: disconnect-assumptions branch comments

2010-06-17 Thread Christian Muise
So the main problems start to crop up when you start stripping out assumptions from the constructor of basic sympy objects. This breaks compatibility, and very quickly the number of errors goes up. You can view the natural progression of what you suggest on this branch: -

Re: disconnect-assumptions branch comments

2010-06-17 Thread Christian Muise
I'll see what I can do, but fixing those tests will likely cause more to fail. I've attached the 7 errors that occur at d25877c: - Two are because Symbols is trying to use assumptions0, something that was inherited from AssumeMeths. - Four are because the tests are trying to create intervals with

Re: disconnect-assumptions branch comments

2010-06-17 Thread Christian Muise
Ondrej, if you could provide feedback on these two commits, it would really help: - http://github.com/haz/sympy/commit/91bcb155b24fd354cfdc3b765823ba5041412dce - http://github.com/haz/sympy/commit/f0c8becedc87b324f293baea159a73c4057a9a3a Specifically in the last one, this is something I didn't

Re: disconnect-assumptions branch comments

2010-06-17 Thread Vinzent Steinberg
2010/6/17 Ondrej Certik ond...@certik.cz: On Thu, Jun 17, 2010 at 12:27 PM, Christian Muise christian.mu...@gmail.com wrote: Ondrej, if you could provide feedback on these two commits, it would really help: - http://github.com/haz/sympy/commit/91bcb155b24fd354cfdc3b765823ba5041412dce - 

Re: disconnect-assumptions branch comments

2010-06-17 Thread Vinzent Steinberg
2010/6/17 Vinzent Steinberg vinzent.steinb...@googlemail.com: Using global assumptions for is_real will break a lot of thinks, because global assumptions do not get cleaned automatically. You would have to clean them after every test setting assumptions. This assumes you would use global

Re: disconnect-assumptions branch comments

2010-06-17 Thread Christian Muise
I think the idea was the compatibility will indeed be broken -- assumptions are to be stripped from object constructors altogether. At least this is the impression I was under after speaking with Ondrej. On Thu, Jun 17, 2010 at 4:43 PM, Vinzent Steinberg vinzent.steinb...@googlemail.com wrote:

Re: disconnect-assumptions branch comments

2010-06-17 Thread Ondrej Certik
Yes, in this branch we should brake compatibility. We should totally get rid of the old assumptions, thus breaking compatibility. Make sure that things work nicely, all tests pass and there are no hacks. Then, for backwards compatibility, we could introduce the assumptions into the constructors,