Re: var and symbols

2010-08-17 Thread Aaron S. Meurer
Well, here's the problem with the spaceless option: >>> var('ab cd ef') (ab, cd, ef) >>> var('ab cd') (ab, cd) >>> var('ab') (a, b) So definitely symbols() should not do each_char by default. On Aug 17, 2010, at 12:44 AM, smichr wrote: > Mateusz has made changes in polys11 to make symbols behav

Re: var and symbols

2010-08-17 Thread Mateusz Paprocki
Hi, On Mon, Aug 16, 2010 at 11:44:04PM -0700, smichr wrote: > Mateusz has made changes in polys11 to make symbols behave like var; I > have submitted a patch 1919 on Vinzent's suggestion in the same issue > to make var behave like symbols. Which way should it go? > > var('abc') -> injects abc or

Re: var and symbols

2010-08-17 Thread Øyvind Jensen
ti., 17.08.2010 kl. 01.14 -0600, skrev Aaron S. Meurer: > Well, here's the problem with the spaceless option: > > >>> var('ab cd ef') > (ab, cd, ef) > >>> var('ab cd') > (ab, cd) > >>> var('ab') > (a, b) This one has bitten me many times. It would be great to make it more consistent. Øyvind >

Re: var and symbols

2010-08-17 Thread Vinzent Steinberg
2010/8/17 Aaron S. Meurer : > Well, here's the problem with the spaceless option: > var('ab cd ef') > (ab, cd, ef) var('ab cd') > (ab, cd) var('ab') > (a, b) You could still do >>> var('ab ') ab I really don't care as long as it is clearly documented, maybe we should add better do

Re: Quantum Code Review

2010-08-17 Thread Brian Granger
On Tue, Aug 17, 2010 at 9:23 AM, Christian Muise wrote: >   One thing that was pressed on me was the desire to have every commit run > clean. Regardless of what point in the commit history, all tests should > work, or at the very least the system should install (broken imports could > alter this).

Re: Quantum Code Review

2010-08-17 Thread Aaron S. Meurer
On Aug 17, 2010, at 11:07 AM, Brian Granger wrote: > On Tue, Aug 17, 2010 at 9:23 AM, Christian Muise > wrote: >> One thing that was pressed on me was the desire to have every commit run >> clean. Regardless of what point in the commit history, all tests should >> work, or at the very least th

Re: Quantum Code Review

2010-08-17 Thread Brian Granger
On Tue, Aug 17, 2010 at 11:13 AM, Aaron S. Meurer wrote: > > On Aug 17, 2010, at 11:07 AM, Brian Granger wrote: > >> On Tue, Aug 17, 2010 at 9:23 AM, Christian Muise >> wrote: >>>   One thing that was pressed on me was the desire to have every commit run >>> clean. Regardless of what point in the

Re: Quantum Code Review

2010-08-17 Thread Vinzent Steinberg
2010/8/17 Brian Granger : > On Tue, Aug 17, 2010 at 9:23 AM, Christian Muise > wrote: >>   One thing that was pressed on me was the desire to have every commit run >> clean. Regardless of what point in the commit history, all tests should >> work, or at the very least the system should install (br

Re: Quantum Code Review

2010-08-17 Thread Brian Granger
On Tue, Aug 17, 2010 at 12:06 PM, Vinzent Steinberg wrote: > 2010/8/17 Brian Granger : >> On Tue, Aug 17, 2010 at 9:23 AM, Christian Muise >> wrote: >>>   One thing that was pressed on me was the desire to have every commit run >>> clean. Regardless of what point in the commit history, all tests

Re: Quantum Code Review

2010-08-17 Thread Aaron S. Meurer
If you do decide to do rebasing, you should fix up some of the commit messages. "DId [sic] nothing basically," "Not much," and "Nothing" aren't very descriptive. Otherwise, try to do better in the future. You will be cursing yourself later when you go back to fix a bug and can't tell what a c