Re: Issue 2127 in sympy: don't allow 0 or 1-arg AssocOp

2010-12-21 Thread sympy
Updates: Labels: NeedsReview Comment #1 on issue 2127 by smichr: don't allow 0 or 1-arg AssocOp http://code.google.com/p/sympy/issues/detail?id=2127 This is part of the branch under review, a commit with the number 2127: https://github.com/sympy/sympy/pull/50 -- You received this messa

Re: Issue 1917 in sympy: 1917: misc edits

2010-12-21 Thread sympy
Updates: Blockedon: 2127 Comment #11 on issue 1917 by smichr: 1917: misc edits http://code.google.com/p/sympy/issues/detail?id=1917 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to t

Re: Issue 1917 in sympy: 1917: misc edits

2010-12-21 Thread sympy
Updates: Labels: -NeedsReview -smichr PassedReview Comment #10 on issue 1917 by asmeurer: 1917: misc edits http://code.google.com/p/sympy/issues/detail?id=1917 I too was a little perplexed by the C stuff, but I think that is a bigger issue, as noted in comment 7. Anyway, over at the p

Re: Issue 2125 in sympy: Using Integers as python slices.

2010-12-21 Thread sympy
Comment #15 on issue 2125 by asmeurer: Using Integers as python slices. http://code.google.com/p/sympy/issues/detail?id=2125 Ah, sorry, I read the code wrong. Never mind that comment. -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post t

Re: Issue 1980 in sympy: has, has_any_symbols, has_all_symbols unified

2010-12-21 Thread sympy
Comment #6 on issue 1980 by smichr: has, has_any_symbols, has_all_symbols unified http://code.google.com/p/sympy/issues/detail?id=1980 https://github.com/sympy/sympy/pull/51 -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this

[GitHub] 1980 [sympy/sympy GH-51]

2010-12-21 Thread GitHub
smichr wants someone to pull from smichr:1980: has() has been optimized and defaults to has_any. all tests pass here and all lines (except the legacy handling of iterables that maybe encountered) are covered. View Pull Request: https://github.com/sympy/sympy/pull/51 -- You received this messa

Re: Issue 1917 in sympy: 1917: misc edits

2010-12-21 Thread sympy
Comment #9 on issue 1917 by smichr: 1917: misc edits http://code.google.com/p/sympy/issues/detail?id=1917 It doesn't appear to make much difference whether C or Symbol is used (according to the following test) but importing in a function is much worse: import C def foo(): C.Symbol("X") foo(

[GitHub] 1917 [sympy/sympy GH-50]

2010-12-21 Thread GitHub
smichr wants someone to pull from smichr:1917: These are code clean-up edits that would be great to get in before 0.7. Most are just a line or two in a given file so it isn't heavy reviewing. The good news is that with these changes there will be 31 less lines to review in the future. 26 file

Re: Issue 2125 in sympy: Using Integers as python slices.

2010-12-21 Thread sympy
Comment #14 on issue 2125 by nicolas.pourcelot: Using Integers as python slices. http://code.google.com/p/sympy/issues/detail?id=2125 @Aaron: "There's no point in testing it five times in Python 2.5+, so I would move the for loop into the else block." Sorry, I don't understand what you me

Re: Issue 2126 in sympy: fix doctest or quality testing to recognize doctests

2010-12-21 Thread sympy
Updates: Labels: NeedsReview Comment #4 on issue 2126 by smichr: fix doctest or quality testing to recognize doctests http://code.google.com/p/sympy/issues/detail?id=2126 The bare exception hiding this was corrected. There are 2 other bare exceptions waiting to cause problems if som

[GitHub] Doctest [sympy/sympy GH-49]

2010-12-21 Thread GitHub
smichr wants someone to pull from smichr:doctest: Doctests that had bad formatting (i.e. were not triple quote or blank line terminated) now flag an error during doctests. This identified a problem with an existing doctest that was corrected. View Pull Request: https://github.com/sympy/sympy/pu