Re: Issue 2133 in sympy: Merge new polynomials manipulation module

Updates: Labels: -Priority-Medium Priority-Critical NeedsReview Comment #39 on issue 2133 by ronan.l...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 So, I have extracted the commits which I reviewed positively, and which d

[GitHub] Polys12 review - part 1 [sympy/sympy GH-98]

rlamy wants someone to pull from rlamy:polys12-reviewed: These are the commits from Mateusz's branch polys12 (see (issue 2133)[http://code.google.com/p/sympy/issues/detail?id=2133] that I have reviewed positively so far. View Pull Request: https://github.com/sympy/sympy/pull/98 -- You receive

Re: Issue 2127 in sympy: don't allow 0 or 1-arg AssocOp

Comment #9 on issue 2127 by smi...@gmail.com: don't allow 0 or 1-arg AssocOp http://code.google.com/p/sympy/issues/detail?id=2127 The TODO box is, I believe, the answer. In multi-commit issues I've put a TODO box there and am removing commits as they are reviewed. I don't have push access, b

Re: Issue 2127 in sympy: don't allow 0 or 1-arg AssocOp

Comment #8 on issue 2127 by asmeurer: don't allow 0 or 1-arg AssocOp http://code.google.com/p/sympy/issues/detail?id=2127 I think it would be easier if Chris pushed in his own patches that are passed review. The problem is really that if I review a patch that is tied up in other patches tha

Re: Issue 51 in sympy: RootOf for polynomial equations

Comment #30 on issue 51 by Vinzent.Steinberg: RootOf for polynomial equations http://code.google.com/p/sympy/issues/detail?id=51 PolyRoot() makes sense to me. RootOf() is more intuitive if you use it for arbitrary expressions though. On the other hand, we don't use IntegralOf(). -- You r

Re: Issue 2127 in sympy: don't allow 0 or 1-arg AssocOp

Comment #7 on issue 2127 by Vinzent.Steinberg: don't allow 0 or 1-arg AssocOp http://code.google.com/p/sympy/issues/detail?id=2127 In your big branches it is hard to keep track of which commits have already passed review and which still need review. This is basically an argument for pushi

Re: Issue 51 in sympy: RootOf for polynomial equations

Comment #29 on issue 51 by asmeurer: RootOf for polynomial equations http://code.google.com/p/sympy/issues/detail?id=51 RootOf is a name borrowed from Maple, by the way. -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, s

Re: Issue 2127 in sympy: don't allow 0 or 1-arg AssocOp

Comment #6 on issue 2127 by asmeurer: don't allow 0 or 1-arg AssocOp http://code.google.com/p/sympy/issues/detail?id=2127 In your big branches it is hard to keep track of which commits have already passed review and which still need review. -- You received this message because you are subscr