Okay this has been pushed in.
On Thu, Sep 23, 2010 at 9:08 PM, Ondrej Certik wrote:
> Hi,
>
> can you please test this pull request:
>
> http://github.com/sympy/sympy/pull/5
>
> and give it some review?
>
> It's a big chunk of code, so I would like more people to review it.
> Just write your comm
t 10:12 AM, Andy Ray Terrel wrote:
> I'm getting an error when calling the autowrap on fortran code, it
> basically looks like subprocess.call is getting a bad command.
> Unfortunately I haven't figured out where to make such a comment in
> the code review system with GitHub
I'm getting an error when calling the autowrap on fortran code, it
basically looks like subprocess.call is getting a bad command.
Unfortunately I haven't figured out where to make such a comment in
the code review system with GitHub.
Below is there error (with the autowrap command printed)
In [1]
I think the email is best and then people can CC themselves if necessary.
-- Andy
On Wed, Jul 28, 2010 at 12:49 PM, Aaron S. Meurer wrote:
> OK, a question. I can set it up to send an email or to CC. The difference
> is the sending an email only sends it out whenever the label is added, while
On Tue, Jul 27, 2010 at 4:25 PM, Aaron S. Meurer wrote:
>
> On Jul 27, 2010, at 10:11 AM, Andy Ray Terrel wrote:
>
>> On Tue, Jul 27, 2010 at 10:33 AM, Toon Verstraelen
>> wrote:
>>> On 07/26/2010 10:36 PM, Ųyvind Jensen wrote:
>>>>
>>>>
On Tue, Jul 27, 2010 at 10:33 AM, Toon Verstraelen
wrote:
> On 07/26/2010 10:36 PM, Ųyvind Jensen wrote:
>>
>> I have uploaded my work on the C code printer, C code generator and the
>> tensor module to smartbear for review:
>>
>> http://hosted.smartbear.com/sympy/go?page=ReviewDisplay&reviewid=6
>>
>> on., 14.07.2010 kl. 10.10 -0700, skrev Ondrej Certik:
>>
>> > Toon -- if you have time, please upload them to github, then we can
>> > easily pull it.
>>
>> > Ondrej
>>
>> > On Wed, Jul 14, 2010 at 9:16 AM, Andy Ray Terrel
&g
I went ahead and pushed this in since the tests were broken.
-- Andy
On Wed, Jul 14, 2010 at 2:49 PM, Andy Ray Terrel wrote:
> Okay looks like there was a incompatibility with the str.startswith in
> python2.4 to 2.5. (2.4 doesn't accept tuple arguments).
>
> I've attache
Okay looks like there was a incompatibility with the str.startswith in
python2.4 to 2.5. (2.4 doesn't accept tuple arguments).
I've attached a patch.
-- Andy
On Sat, Jul 10, 2010 at 3:40 PM, Ondrej Certik wrote:
> It's in, thanks!
>
> On Sat, Jul 10, 2010 at 9:56 AM, Øyvind Jensen
> wrote:
>
Øyvind,
Have these patches been added to a repo somewhere so I can push them
in? I'm not sure which goes where.
-- Andy
On Sat, Jul 10, 2010 at 10:35 AM, Øyvind Jensen wrote:
> Hi Toon,
>
> Thanks for your patches/suggestions and for looking over my work!
>
> lø., 10.07.2010 kl. 09.09 +0200, s
I talked to smart bear [0] at a tech fair last week. They are up for
hosting open source projects. Perhaps this would be something to look
into.
-- Andy
[0] http://smartbear.com/
On Tue, Jun 22, 2010 at 2:48 PM, Vinzent Steinberg
wrote:
> 2010/6/22 Aaron S. Meurer :
>> With the issues list,
Instead of creating new branches every time you update your repo I
suggest using stgit [0]. You should be careful though because you can
mess up and overwrite things, but as long as you are the person
pulling and pushing to your repo this will allow for easier changes.
-- Andy
[0] http://www.pro
I get the following failure when running the tests:
File "/users/aterrel/workspace/sympy/doc/src/modules/printing.txt",
line 163, in printing.txt
Failed example:
print fcode(1 - gamma(x)**2)
Expected:
C Not Fortran 77:
C gamma(x)
1 - gamma(x)**2
Got:
C Not For
So I'm +1 with this to be merged in. It is a lot of code and I
haven't gone over every line but it is well documented and the tests
seem to be covering most of the code.
-- Andy
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Goo
On Thu, Aug 20, 2009 at 12:34 PM, Aaron S. Meurer wrote:
>
> On Aug 20, 2009, at 11:19 AM, Vinzent Steinberg wrote:
>
> 2009/8/20 Aaron S. Meurer
>>
>> On Aug 20, 2009, at 5:23 AM, Vinzent Steinberg wrote:
>>
>> Thank you, this is an impressive result. :)
>>
>> 2009/8/20 Aaron S. Meurer
>>>
>>>
h of HEAD? This test passes just fine on my
> machine. Could you maybe copy eq6 from the test file and run
>
> dsolve(eq6, f(x),
> hint='nth_linear_constant_coeff_variation_of_parameters')
>
> and paste the result here?
>
> Aaron Meurer
> On Aug 20, 2009, at 9:4
Also running make html I get some errors that should be easy to fix:
/Users/aterrel/workspace/sympy/sympy/solvers/ode.py:docstring of
sympy.solvers.ode.ode_1st_homogeneous_coeff_best:10: (ERROR/3)
Unexpected indentation.
/Users/aterrel/workspace/sympy/sympy/solvers/ode.py:docstring of
sympy.solve
Running tests on HEAD I get the following error:
sympy/solvers/tests/test_ode.py:test_nth_linear_constant_coeff_variation_of_parameters
File "/Users/aterrel/workspace/sympy/sympy/solvers/tests/test_ode.py",
line 899, in test_nth_linear_constant_coeff_variation_of_parameters
assert dsolve(
Okay it's pushed. I must have blown away the right line in my config
a while back.
-- Andy
On Mon, Jul 27, 2009 at 4:11 PM, Ondrej Certik wrote:
>
> On Mon, Jul 27, 2009 at 2:50 PM, Andy Ray Terrel wrote:
>>
>> Here's what I'm getting:
>>
>>
py/*
-- Andy
On Mon, Jul 27, 2009 at 2:26 PM, Ondrej Certik wrote:
>
> On Sun, Jul 26, 2009 at 7:17 AM, Andy Ray Terrel wrote:
>>
>> Yes, I meant update the patch with discussed changes. Here I did it,
>> but it seems I can no longer push. So someone else needs to:
>
Yes, I meant update the patch with discussed changes. Here I did it,
but it seems I can no longer push. So someone else needs to:
>From fd581f3d3a3a33ff8f231c8057da3a68e4b33cfd Mon Sep 17 00:00:00 2001
From: Chris Smith
Date: Sun, 26 Jul 2009 08:00:47 -0500
Subject: [PATCH] typo and new exampl
Okay I'm +1 with the changes and arguments for the example. Update
the patch and I will push it.
-- Andy
On Sat, Jul 4, 2009 at 4:50 PM, smichr wrote:
>
>
>
> On Jul 3, 9:58 pm, Vinzent Steinberg
> wrote:
>> 2009/7/3 Andy Ray Terrel
>>
>>
>>
>&
-1
There are already 4 examples, one more is not necessary.
And you fixed the spelling of thorough but not the grammar of the
sentence. I would prefer to see:
"""
Series expansion of expr(x) around "point".
This is just a wrapper around Basic.series(), see its docstring for a
thorough explana
+1
On Mon, Apr 13, 2009 at 8:16 PM, Tomasz Buchert wrote:
>
> ---
> sympy/utilities/tests/test_code_quality.py | 4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sympy/utilities/tests/test_code_quality.py
> b/sympy/utilities/tests/test_code_quality.py
> index b2f2
I think we should try to name the exceptions as much as possible, this
helps for a user writing a library to catch the correct exception.
On Mon, Apr 13, 2009 at 8:08 PM, Tomasz Buchert wrote:
>
> ---
> sympy/core/basic.py | 2 +-
> sympy/matrices/matrices.py | 16
On Wed, Dec 10, 2008 at 9:37 AM, Sebastian <[EMAIL PROTECTED]> wrote:
>
>
>>> -To run the examples one needs to have Python version >= 2.4 installed.
>>> Each
>>> -example can be run from the command line python and the name of the
>>> example:
>>> +To run the examples one needs to have Python
On Tue, Dec 9, 2008 at 10:31 AM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> ---
> sympy/utilities/runtests.py |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sympy/utilities/runtests.py b/sympy/utilities/runtests.py
> index 80b7e92..3306e7e 100644
> --- a/sympy/ut
I'm +1 to all these patches. One thing the docstring test dots don't
wrap like the other tests do on my system.
On Tue, Dec 9, 2008 at 10:31 AM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> Hi,
>
> finally, I found time to finish the doctests, so now everything should be
> working. Please review
On Tue, Dec 9, 2008 at 10:31 AM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> This is achieved by looking for the __init__.py file and if it's missing, it
> means that such file cannot be imported in python using the "import something"
> syntax (for example all tests in sympy are such a case).
> -
On Mon, Dec 1, 2008 at 11:12 PM, <[EMAIL PROTECTED]> wrote:
> From: Andy R. Terrel <[EMAIL PROTECTED]>
>
> ---
> examples/advanced/pidigits.py | 37 -
> examples/all.py |2 +-
> 2 files changed, 21 insertions(+), 18 deletions(-)
>
> diff --
On Wed, Nov 26, 2008 at 10:49 AM, Vinzent Steinberg
<[EMAIL PROTECTED]> wrote:
>
>
> On 26 Nov., 15:59, "Andy Ray Terrel" <[EMAIL PROTECTED]> wrote:
>> I don't like it because it makes inconsistent '=' notation and I find
>> it easier t
On Wed, Nov 26, 2008 at 3:42 PM, Vinzent Steinberg
<[EMAIL PROTECTED]> wrote:
>
> Thank you for the patch!
>
> Some more (quite minor) remarks:
>
> On Nov 26, 10:58 am, "Andy Ray Terrel" <[EMAIL PROTECTED]> wrote:
>> On Fri, Nov 21, 2008 at 4:04 PM, V
So I just put something like this in the vandermonde example. I would
prefer something with less recursion such as:
def subsets_simp(M, k, unordered=False, repetitions=False):
"""Generates all k-subsets from the n-items of M"""
if k == 0:
yield []
else:
for i in xrang
On Fri, Nov 21, 2008 at 4:04 PM, Vinzent Steinberg
<[EMAIL PROTECTED]> wrote:
>
>
>
> On Nov 20, 11:23 pm, [EMAIL PROTECTED] wrote:
>> From: Andy R. Terrel <[EMAIL PROTECTED]>
>>
>> ---
>> examples/intermediate/vandermonde.py | 173
>> ++
>> 1 files changed, 155
On Thu, Nov 20, 2008 at 12:46 AM, Fabian Seoane <[EMAIL PROTECTED]> wrote:
>
> [EMAIL PROTECTED] escribió:
>> From: Andy R. Terrel <[EMAIL PROTECTED]>
>>
>> ---
>> sympy/printing/ccode.py|1 +
>> sympy/printing/tests/test_ccode.py |8 +++-
>> 2 files changed, 8 insertions(
Hello Lance,
I wasn't able to get this patch to apply, are you using:
[diff]
git = true
showfunc = 1
in your ~/.hgrc file.
Alternatively does someone know how to import hg diffs using git,
cause I'm not getting it right now.
-- Andy
--~--~-~--~~~---~--~~
Yo
Some more comments.
It would be nice to do something with the str method to get better
printing, right now I get:
In [44]: C
Out[44]: ()
Also it would be good to catch vectors and handle them, right now I'm getting
In [52]: line_integrate([x**2,y**2], C, [x,y])
Out[52]: [pi, pi]
But I believe
+1
On Fri, Nov 14, 2008 at 3:16 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> On Wed, Nov 12, 2008 at 1:04 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>> Print it the same way as py.test.
>> ---
>> sympy/utilities/runtests.py |5 -
>> 1 files changed, 4 insertions(+), 1 deletions(-)
+1. This patch seems pretty trivial i.e. no review.
On Thu, Nov 13, 2008 at 7:26 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> And a test added.
> ---
> sympy/core/numbers.py|6 +-
> sympy/test_external/test_sage.py |8
> 2 files changed, 13 insertions(+), 1
+1
I guess the patches got out of order since the last one took out all
the exclusions. But anywho I like testing these things.
-- Andy
On Thu, Nov 13, 2008 at 9:41 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> Files that currently don't pass the tests are whitelisted. The goal is to not
>
+1
-- Andy
On Thu, Nov 13, 2008 at 9:41 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> ---
> examples/fem.py|6 +++---
> examples/fem_test.py |3 ++-
> examples/pidigits.py |6 +++---
> examples/print_gtk.py
One thing that would be nice is to give a bit more information on
different algorithms used for examples. It seems that we could really
just have such a large list of examples it is hard to keep up with
them. Really the idea I would have is to make a corresponding wiki
that explained the example
+1 I think this is a nice design. Perhaps we should add CCodePrinter as well.
-- Andy
- Show quoted text -
On Wed, Nov 5, 2008 at 4:20 AM, Sebastian <[EMAIL PROTECTED]> wrote:
> As Brian Granger proposed in the thread
> http://groups.google.com/group/sympy/browse_thread/thread/2927bac0810029a0
On Tue, Nov 4, 2008 at 11:23 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> On Tue, Nov 4, 2008 at 11:12 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>> On Tue, Nov 4, 2008 at 10:57 PM, Andy Ray Terrel <[EMAIL PROTECTED]> wrote:
>>>
>>> I've
I've put the patches in the Nov_04_2008 branch. The repo is at
git://github.com/aterrel/sympy.git
On Tue, Nov 4, 2008 at 9:42 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> Also +1. Could you please push all 3 patches to your git repo? I'll
> pull it and push it in.
>
> Thanks,
> Ondrej
>
> O
Adding sympify call to Piecewise canonized arguments and refactoring code.
diff --git a/sympy/functions/elementary/piecewise.py
b/sympy/functions/elementary/piecewise.py
--- a/sympy/functions/elementary/piecewise.py
+++ b/sympy/functions/elementary/piecewise.py
@@ -40,6 +40,10 @@ class Piecewise(
# HG changeset patch
# User Andy R. Terrel <[EMAIL PROTECTED]>
# Date 1224442929 -7200
# Node ID 43aa9092910d5a23b660890b871d26c522e5889a
# Parent 38265b71f360fce5b4c57ee57961f8f8c38fdc46
Issue 883, a rework of the patch submitted by Boris Timokhin
<[EMAIL PROTECTED]>:
- Removes sympify_lists k
On Fri, Oct 17, 2008 at 12:49 AM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> On Fri, Oct 17, 2008 at 12:07 AM, Andy Ray Terrel <[EMAIL PROTECTED]> wrote:
>>
>> On Thu, Oct 16, 2008 at 11:00 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>>>
>>
On Thu, Oct 16, 2008 at 11:00 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> I am +1 for the initial impementation. Aren't you using here the same
> code as is already in some other method in your first patch? If so,
> maybe let's refactor that? Or leave there a TODO comment that it
On Thu, Oct 16, 2008 at 6:51 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote:
>
> On Thu, Oct 16, 2008 at 5:36 PM, Andy R. Terrel <[EMAIL PROTECTED]> wrote:
>>
>>
>>
>> On Oct 16, 5:11 pm, "Ondrej Certik" <[EMAIL PROTECTED]> wrote:
>>> On Thu, Oct 16, 2008 at 3:49 PM, Andy R Terrel <[EMAIL PROTECTED]>
50 matches
Mail list logo
