Re: Subject: [PATCH] Implemented code to expand negative integer powers

2009-09-02 Thread Luke
It has been a while since I looked at this, but I went ahead and implemented what Ronan suggested. The branch is on my git hub: http://github.com/hazelnusse/sympy/tree/expand_neg_int_powers It passes all tests on my machine. Let me know what you think. ~Luke On Aug 9, 7:24 pm, Aaron S

Re: Block diagonal methods for matrix class, and some code cleanup

2009-08-24 Thread Luke
Attached is the patch that implements the change from 'lines' to 'rows' in the Matrix class. I'll have the other one finished soon, hopefully git doesn't bite me. ~Luke On Mon, Aug 24, 2009 at 2:54 PM, Lukehazelnu...@gmail.com wrote: Ondrej and I cooked this patch up together while we were

Re: Block diagonal methods for matrix class, and some code cleanup

2009-08-24 Thread Luke
in order to separate the two main things we did while working on this branch. I guess we should have thought of this when we were working. ~Luke On Mon, Aug 24, 2009 at 3:46 PM, Lukehazelnu...@gmail.com wrote: Ignore this patch, lots of tests fail.  I'm working on it. On Mon, Aug 24, 2009

[PATCH] Added optional boolean argument to coeff to control whether .expand() is called

2009-08-08 Thread Luke
don't need to expand everything out and then collect terms. Especially when you have coefficients which may be long and complicated or are already in a nice compact form, you don't want to expand them out. ~Luke --~--~-~--~~~---~--~~ You received this message because

Re: [PATCH] Added optional boolean argument to coeff to control whether .expand() is called

2009-08-08 Thread Luke
Attached is an updated patch which adds a docstring that describes the new optional keyword argument and provides a doctest to demonstrate the new functionality. ~Luke On Sat, Aug 8, 2009 at 9:24 AM, Lukehazelnu...@gmail.com wrote: Attached is a patch that allows for an optional boolean argument

Subject: [PATCH] Removed .expand() in matrix_multiply, added doctests, alternate implementation

2009-08-08 Thread Luke
Attached is a patch that: 1) removes the .expand() call that was being done in matrix_multiply() 2) adds a doctest and improves the docstring 3) provides and alternative implementation that is somewhat clearer, but about 5% slower. ~Luke --~--~-~--~~~---~--~~ You

Re: Fix for ISSUE 626, cleaner implementation, all as one patch

2009-05-29 Thread Luke
Happy to help. On May 26, 9:48 pm, Ondrej Certik ond...@certik.cz wrote: The patch looks good, it's in. Thanks! On Mon, May 25, 2009 at 4:44 PM, Luke hazelnu...@gmail.com wrote: Attached is the patch that Fixes issue 626 and allows for solve() to handle Function and Derivative instances

Re: solve() can now solver for Symbol, Function, or Derivative instances

2009-05-25 Thread Luke
Has anybody had a chance to review this? If there is anything that should be done differently, I'm happy to change it up, just let me know. Thanks, ~Luke On May 21, 6:58 pm, Luke hazelnu...@gmail.com wrote: Attached is the code that allows you to use solve with equations that have Symbol

[PATCH] Fix for ISSUE 626, cleaner implementation, all as one patch

2009-05-25 Thread Luke
Attached is the patch that Fixes issue 626 and allows for solve() to handle Function and Derivative instances, implements tests for both cases, and has extensive commenting. All tests pass on my machine. Please review and let me know if I can make it better. Thanks, ~Luke

[PATCH] Fixes and tests for Issue 1434

2009-05-23 Thread Luke
Attached are the patches for Ondrej's fix. Note that after this patch: sqrt(x*y) == sqrt(x)*sqrt(y) Which is a big problem, lets get it fixed. Thanks, ~Luke --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups sympy

[PATCH] Fix for ISSUE 626

2009-05-22 Thread Luke
Issue 626 is fixed by these two patches. Also, solve can now Symbol, Function, and Derivative types. I implemented tests and everything passes on my machine. Thanks, ~Luke --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google

solve() can now solver for Symbol, Function, or Derivative instances

2009-05-21 Thread Luke
Attached is the code that allows you to use solve with equations that have Symbol, Function, or Derivative instances in them. It passed all tests on my machine. Let me know if there are any problems. I will be working on a similar patch to do the same thing for diff() Thanks, ~Luke

Re: Issue 1098 Patch

2009-04-11 Thread Luke
Yep. The two patches should take care of it. On Apr 9, 8:01 pm, Ondrej Certik ond...@certik.cz wrote: On Sun, Apr 5, 2009 at 10:39 PM, Ondrej Certik ond...@certik.cz wrote: On Sun, Apr 5, 2009 at 1:57 PM, Luke hazelnu...@gmail.com wrote: So this was my first patch, I hope I did everything

Issue 1098 Patch

2009-04-05 Thread Luke
? If not, what do I need to be able close an issue? Feedback welcome. Thanks, ~Luke --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups sympy-patches group. To post to this group, send email to sympy-patches