Re: bug in sdp_groebner: polynomials not in monic form

Hi, On 10 June 2011 07:41, mario mario.pern...@gmail.com wrote: Hi Mateusz, Indeed this improves speed of sdp_groebner(). Making a polynomial monic shouldn't affect correctness, but anyway all tests pass. Is this your observation or is it explained in literature? Can you submit a pull

Re: bug in sdp_groebner: polynomials not in monic form

Hi, On 9 June 2011 06:49, mario mario.pern...@gmail.com wrote: I don't remember how to attach a patch file; in this case is just one line, so I hope you accept that I paste it here diff --git a/sympy/polys/groebnertools.py b/sympy/polys/ groebnertools.py index 0b3155a..b8964ec 100644

Re: var and symbols

Hi, On Mon, Aug 16, 2010 at 11:44:04PM -0700, smichr wrote: Mateusz has made changes in polys11 to make symbols behave like var; I have submitted a patch 1919 on Vinzent's suggestion in the same issue to make var behave like symbols. Which way should it go? var('abc') - injects abc or a, b,

Re: Quantum Code Review

Hi, On Mon, Aug 16, 2010 at 03:05:27PM -0700, Ondrej Certik wrote: Hi Matt and Addison, great job! Some comments below: On Mon, Aug 16, 2010 at 12:19 PM, Matt Curry mattjcu...@gmail.com wrote: Addison and I have been working on adding features to sympy.physics for our GSoC project. We

Re: factoring

Hi, On Sat, Aug 07, 2010 at 04:57:18AM -0700, smichr wrote: I've asked about factoring before but am just jotting down some observations that I've made in the last few days. I was talking with Aaron the other day about a routine and suggested he should use factoring. He says, that's gong to

Re: factoring

Hi, On 7 August 2010 13:57, smichr smi...@gmail.com wrote: I've asked about factoring before but am just jotting down some observations that I've made in the last few days. I was talking with Aaron the other day about a routine and suggested he should use factoring. He says, that's gong to

Re: Please review my 'unused-imports' branch

Hi, On Wed, Mar 17, 2010 at 04:59:50PM -0600, Aaron Meurer wrote: It does not rebase trivially over master, due to mpmath being updated. New rebased branch is polys7. We currently testing it. Aaron Meurer On Mar 17, 2010, at 4:27 PM, Ondrej Certik wrote: On Wed, Mar 17, 2010 at 2:13

Re: factoring upgrade

Hi, On Wed, Dec 02, 2009 at 11:49:24PM -0800, smichr wrote: Is gcdfactor() any different from the following? In [1]: f = x**2*exp(x)+exp(x+y)*x/y In [2]: f Out[2]:            x + y  2  x   x⋅ℯ     x ⋅ℯ  +            y     In [3]: factor(f) Out[3]:   ⎛     y⎞  

Re: factoring upgrade

Hi, On Wed, Dec 02, 2009 at 04:21:46PM -0800, Ondrej Certik wrote: One last thing --- all tests+doctests pass, but some documentation tests fail and I think at least some of them may indicate some bugs, that should be fixed and regular tests written for:

Re: factoring upgrade

Hi, On Tue, Dec 01, 2009 at 11:01:25AM -0800, smichr wrote: smichr's gfactor branch at github has a (hopefully) more robust method for factoring. It relies on the standard factor that is part of polys but it does pre-processing of an expression with a gcdfactor routine. The gcdfactor pulls

Re: [PATCH] Fix two typos, one functional, one in comment

Hi, On Mon, Jul 13, 2009 at 11:10:57PM +0300, Priit Laes wrote: diff --git a/sympy/core/function.py b/sympy/core/function.py index 6e65c5b..c7d0265 100644 --- a/sympy/core/function.py +++ b/sympy/core/function.py @@ -368,7 +368,7 @@ def _eval_expand_multinomial(self, deep=True, **hints):

Re: [PATCH] Rename Basic.is_fraction to Basic.is_rational_function

Hi, On Thu, May 14, 2009 at 06:37:15PM +0300, Priit Laes wrote: Renames Basic.is_fraction to Basic.is_rational_function and adds a docstring with doctests. Can be viewed here: https://code.plaes.org/git/sympy.git/commit/?h=patches-0514id=5d27fd77f72bc3887fae02ad568b00838227e3b8 or as an

[PATCH] Poly.cancel now removes content from p/q properly

fraction returned by simplify() (in fact Poly.cancel) were multiplied by a constant. Signed-off-by: Mateusz Paprocki matt...@gmail.com --- sympy/polys/polynomial.py| 10 ++ sympy/polys/tests/test_polynomial.py |4 2 files changed, 14 insertions(+), 0 deletions(-) diff

Re: [PATCH] Fix heuristic integration to support more general forms for asin/asinh results

On Thu, Feb 26, 2009 at 12:27:54PM -0800, Ondrej Certik wrote: On Thu, Feb 26, 2009 at 12:11 PM, Priit Laes plaes...@gmail.com wrote: Patch here: http://plaes.org/files/2009-Q1/sympy-fix-asin-integral.patch Previously sympy failed to integrate things like this: In [3]:

Re: [PATCH] Implemented rsolve() recurrence solvers wrapper

On Wed, Jan 28, 2009 at 01:33:03PM -0800, Ondrej Certik wrote: As documented at: http://git.sympy.org/ you need to use: git push g...@git.sympy.org:repos/sympy.git OK, now it works. It seems I'd never before entered the main git.sympy.org page (or at least read the topmost lines

Finally removed old sympy.polynomials module

Hi, the last missing piece - factorization routines for univariate and multivariate polynomials, was finally added to sympy.polys. This way all functionality provided by the old polynomials module is now available in sympy.polys. As a consequence sympy.polynomials can be safely removed - which

[PATCH] Implemented gf_{from,to}_int_poly functions

This functionality will be needed in sympy/polys/integerpolys.py to convert GF(p)[x] to Z[x] and Z[x] to GF(p)[x]. --- sympy/polys/galoispolys.py|9 + sympy/polys/tests/test_galoispolys.py | 11 +-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git

[PATCH] Implemented k-subsets generator

This function was in fact a part of zassenhaus() in sympy/polynomials/fast/intpoly.py, but can be useful elsewhere. Added docstring and tests. --- sympy/utilities/__init__.py |3 ++- sympy/utilities/iterables.py| 25 +

[PATCH] Simplified code in gf_factor (use gf_sqf)

Now gf_factor uses gf_sqf to compute square-free decomposition of a polynomial and then factors each part independently using gf_factor_sqf. This approach is much simpler than the original one and should be faster, especially for large input and modulus, because now Shoup's DDF can be used

[PATCH] Removed Polynomial from printing tests

--- sympy/printing/tests/test_repr.py |6 +- sympy/printing/tests/test_str.py |6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/sympy/printing/tests/test_repr.py b/sympy/printing/tests/test_repr.py index 897726e..71f7788 100644 ---

[PATCH] Refactored kronecker_mv() and factor() functions

Kronecker's method for factorization of multivariate polynomials was rewritten to use Poly and new Z[x] factorization code. This way kronecker_mv() seems reasonable for small input, e.g.: In [1]: %time factor(x**10 - y**10) CPU times: user 16.05 s, sys: 0.17 s, total: 16.22 s Wall time: 16.52 s

[PATCH] Reimplemented factoring utilities over Z[x]

This patch reimplements univariate polynomials over integers and factorization algorithm over this domain. The module was written to match galoispolys.py design. All functionality available in polynomials/fast/intpoly.py was moved to the new module. All subroutines (especially zzx_mod_gcd) use

[PATCH] Use poly_factors() in rootfinding.py instead of old factor()

--- sympy/polys/rootfinding.py | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/sympy/polys/rootfinding.py b/sympy/polys/rootfinding.py index 2697d3a..fdfe413 100644 --- a/sympy/polys/rootfinding.py +++ b/sympy/polys/rootfinding.py @@ -8,6 +8,7 @@ from

[PATCH] Fixed and improved gf_{edf,ddf}_shoup docstrings

--- sympy/polys/galoispolys.py | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/sympy/polys/galoispolys.py b/sympy/polys/galoispolys.py index 2833ec2..cd2c018 100644 --- a/sympy/polys/galoispolys.py +++ b/sympy/polys/galoispolys.py @@ -849,6 +849,9 @@ def

Re: [PATCH] Reimplemented factoring utilities over Z[x]

On Sun, Nov 23, 2008 at 09:27:05PM +0100, Fabian Seoane wrote: Nice work! Thanks. Couple of questions: what does zzx stand for? zzx stands for univariate polynomial over integers --- Z[x]. The double 'z' is used in many algebra systems, so I stay compatible with those systems (also zzx

Re: Fixed issue #1123

Hi, Sorry for late reply, I'm quite busy right now. Technically yes. OK This is in: http://hg.sympy.org/sympy/rev/17b95f9f1d9d Thanks for review, Mateusz On 12 Paź, 12:49, Ondrej Certik [EMAIL PROTECTED] wrote: On Sun, Oct 12, 2008 at 8:48 AM, Mateusz Paprocki [EMAIL PROTECTED] wrote