Re: [sympy] Diagram Layout (#1429)

2012-08-08 Thread Sergiu Ivanov
Hm, note that Stefan's bot reported no problems, and neither do I see any errors on my box. I'll try to see what's different in Aaron's configuration. --- Reply to this email directly or view it on GitHub: https://github.com/sympy/sympy/pull/1429#issuecomment-7587906 -- You received this

[sympy] [WIP] Fix the DiagramGrid import failure in categories.rst. (#1472)

2012-08-08 Thread Sergiu Ivanov
This is an attempt to fix https://github.com/sympy/sympy/pull/1429#issuecomment-7570113 . I can't reproduce it on my computer, so this pull request does not contain the actual solution as of yet. You can merge this Pull Request by running: git pull https://github.com/scolobb/sympy

Re: [sympy] [WIP] Fix the DiagramGrid import failure in categories.rst. (#1472)

2012-08-08 Thread Sergiu Ivanov
@asmeurer , could you please run the HTML doc building test on this branch? --- Reply to this email directly or view it on GitHub: https://github.com/sympy/sympy/pull/1472#issuecomment-7588731 -- You received this message because you are subscribed to the Google Groups sympy-patches group. To

Re: [sympy] Diagram Layout (#1429)

2012-08-07 Thread Sergiu Ivanov
+ from sympy.categories import Object, NamedMorphism + from sympy.categories import Diagram, DiagramGrid + from sympy import FiniteSet + A = Object(A) + B = Object(B) + C = Object(C) + f = NamedMorphism(A, B, f) + g = NamedMorphism(B, C, g) + diagram =

Re: [sympy] Diagram Layout (#1429)

2012-08-07 Thread Sergiu Ivanov
@ness01 , thanks for the extra round of review! I have fixed everything you have pointed out, including fixing all whitespace in writing `dicts`. I get the same errors with Python 3.3, but I get them all over SymPy anyway, so I believe they are hardly introduced by my code. --- Reply to this

Re: [sympy] Diagram Drawing (#1430)

2012-08-07 Thread Sergiu Ivanov
@ness01 , done; sorry, I totally forgot to rebase this branch :-( --- Reply to this email directly or view it on GitHub: https://github.com/sympy/sympy/pull/1430#issuecomment-7562441 -- You received this message because you are subscribed to the Google Groups sympy-patches group. To post to

Re: [sympy] Diagram Drawing (#1430)

2012-08-07 Thread Sergiu Ivanov
No problem. I'll start the reviewing tomorrow. Cool! --- Reply to this email directly or view it on GitHub: https://github.com/sympy/sympy/pull/1430#issuecomment-7562688 -- You received this message because you are subscribed to the Google Groups sympy-patches group. To post to this group,

[sympy] Set: Fix the sort_key. (#1464)

2012-08-04 Thread Sergiu Ivanov
Unfortunately, I haven't been sufficiently diligent to thoroughly check the recent `sort_key`-related modification, so two slight issues with `Set.sort_key` have slipped into `master`, sorry. I hope the changes here are pretty straightforward and we will be able to merge them soon. You can

[sympy] Dict: Add iteritems. (#1439)

2012-07-24 Thread Sergiu Ivanov
This method just invokes iteritems on the underlying dictionary. Having `iteritems` is useful for efficiency reasons. You can merge this Pull Request by running: git pull https://github.com/scolobb/sympy dict-iteritems Or you can view, comment on it, or merge it online at:

[sympy] Fix long arrows in Unicode pretty printing. (#1440)

2012-07-24 Thread Sergiu Ivanov
Previously those classes were pretty printed using long Unicode symbols, which worked erratically on different terminals. This commit uses more standard characters. Things are now printed like this: ``` {g∘f:A₁——▶C₁: ∅, id:A₁——▶A₁: ∅, id:B——▶B: ∅, id:C₁——▶C₁: ∅, f:A₁——▶B: ∅, g:B——▶C₁: ∅} ══▶

[sympy] Diagram Layout (#1429)

2012-07-18 Thread Sergiu Ivanov
This pull request adds the code which lays out the objects of a diagram, depending how they are connected with morphisms and some other parameters. Some tests for this pull request still fail half of the time, because of the issue with `FiniteSet` sort keys. I do submit this pull request

[sympy] Diagram Drawing (#1430)

2012-07-18 Thread Sergiu Ivanov
Based on the diagram layouts produced by the code in #1429, the code introduced by this pull request allows producing Xy-pic presentations of diagrams. This pull request should only be merged after #1429. You can merge this Pull Request by running: git pull https://github.com/scolobb/sympy

Re: [sympy] plot error (#1424)

2012-07-17 Thread Sergiu Ivanov
Hello, On Tue, Jul 17, 2012 at 6:30 PM, shd101wyy reply+i-5666703-6f286e2aea96ea0518bde7a24cc3f5d172abfdd7-452...@reply.github.com wrote: Please help me, I got the following error My OS is Mac OS 10.7.4 Thank you! Python console for SymPy 0.7.1-git (Python 2.7.3-64-bit) (ground types:

[sympy] Fix some failures (#1395)

2012-06-30 Thread Sergiu Ivanov
This fixes some of the test failures in master. You can merge this Pull Request by running: git pull https://github.com/scolobb/sympy fix-some-failures Or you can view, comment on it, or merge it online at: https://github.com/sympy/sympy/pull/1395 -- Commit Summary -- * Expr.expand:

[sympy] Fix hash randomisation-related doctest failures in categories. (#1393)

2012-06-29 Thread Sergiu Ivanov
The doctests now sort the lists before showing them, and avoid showing dictionaries. You can merge this Pull Request by running: git pull https://github.com/scolobb/sympy fix-categories-doctests Or you can view, comment on it, or merge it online at:

[sympy] Do not implicitly sort elements in FiniteSet. (#1380)

2012-06-23 Thread Sergiu Ivanov
This pull request makes FiniteSet not sort its elements at construction and fixes the consequences. You can merge this Pull Request by running: git pull https://github.com/scolobb/sympy finiteset-nosort Or you can view, comment on it, or merge it online at:

[sympy] Fix the sorting of elements in FiniteSet. (#1381)

2012-06-23 Thread Sergiu Ivanov
This pull request makes `FiniteSet` use `default_sort_key` to sort its elements and also removes the pre-sorting of `FiniteSet` elements before printing it in `pretty.py`. You can merge this Pull Request by running: git pull https://github.com/scolobb/sympy finiteset-fixsorting Or you can

[sympy] Fix FiniteSet-related Python 3 test failures. (#1368)

2012-06-21 Thread Sergiu Ivanov
This pull request makes the behaviour of `element_sort_fn` in `core/sets.py` consistent with that of `sort_key` in all SymPy classes. This pull request also makes exception handling in `element_sort_fn` more specific. You can merge this Pull Request by running: git pull

[sympy] Use `sort_key()` to sort those elements in `FiniteSet` which have it. (#1362)

2012-06-20 Thread Sergiu Ivanov
Using `sort_key` instead of relying on the objects being comparable considerably widens the range of objects which are sorted deterministically rather than arbitrarily. You can merge this Pull Request by running: git pull https://github.com/scolobb/sympy finiteset-sort_key Or you can view,