hello my friend

2011-07-05 Thread Fabian Seoane
dear friend how are you ? in 5-7 days will get the new Iphone 4 i order the Iphone4 from here i like it much hope you try too regards -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patches@googlegrou

Re: [PATCH] Basic.simplify() implemented.

2008-10-15 Thread Fabian Seoane
I'm 0 for this. Don't see the need for this, I think that there are already too many classmethods for Basic, and having sympify as a classmethod and as a static method (same name, different arguments expected) would only confuse users ... 2008/10/15 Ondrej Certik <[EMAIL PROTECTED]> > This just

[PATCH] Make Rational accept a wider range of types as arguments.

2008-10-16 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> Before of this, simple things like Rational(1, Integer(2)) failed with a ValueError. Now this is solved and it is even possible to define a rational wit arbitrary symbolic arguments as long as they are supposed to be integers (i.e. they hav

[PATCH] Better error message for MemoizeArg.process.

2008-10-16 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> Since certain Sympy types emulate de behaviour of numerical types, you could end up with the following unhelpfull error message: ValueError: sympy/core/numbers.py:488:function __new__ 2-th argument must be of type (, , ) but got 2 The output of t

Re: [PATCH] test_limits.py: a wrong test fixed.

2008-10-16 Thread Fabian Seoane
; assert limit(log(2+sqrt(atan(x)*sin(1/x))), x, 0) == log(2) > > def test_issue772(): > +z = Symbol("z", positive=True) > f = -1/z*exp(-z*x) > assert limit(f, x, oo) == 0 > assert f.limit(x, oo) == 0

Re: Make Rational accept a wider range of types as arguments.

2008-10-17 Thread Fabian Seoane
ur 15 patches now ... is there a repo we could pull from? You see, couldn't get git am working on my mac ... (not to say windows users!) Thanks, > > > Ondrej > > > Fabian Seoane http://fseoane.net --~--~-~--~~~---~--~~

Re: [PATCH 04/15] gruntz.py: documentation how to debug added.

2008-10-17 Thread Fabian Seoane
+-sign(_x, _x) = 1 > +| +-mrv_leadterm(1, _x) = (1, 0) > ++-sign(0, _x) = 0 > ++-limitinf(1, _x) = 1 > + > +And check manually which line is wrong. Then go to the source code > and debug > +this function to figure out th

Re: [PATCH 04/15] gruntz.py: documentation how to debug added.

2008-10-17 Thread Fabian Seoane
On Oct 17, 2008, at 10:37 AM, Ondrej Certik wrote: > > On Fri, Oct 17, 2008 at 10:29 AM, Fabian Seoane <[EMAIL PROTECTED] > > wrote: >> >> >> >> >> On Oct 17, 2008, at 2:37 AM, Ondrej Certik wrote: >> >>> >>> --- >>

Re: [PATCH] Make Rational accept a wider range of types as arguments.

2008-10-17 Thread Fabian Seoane
On Oct 17, 2008, at 11:23 AM, Fredrik Johansson wrote: > > On Fri, Oct 17, 2008 at 1:53 AM, <[EMAIL PROTECTED]> wrote: >> >> From: Fabian Seoane <[EMAIL PROTECTED]> >> >> Before of this, simple things like Rational(1, Integer(2)) failed >> wi

Re: [PATCH] Make Rational accept a wider range of types as arguments.

2008-10-17 Thread Fabian Seoane
ork with numbers from gmpy, etc, But then Rational(1.) == Integer(1) and that is not only ugly but incorrect ... > > > Fredrik > > > Fabian Seoane http://fseoane.net --~--~-~--~~~---~--~~ You received this message

Re: [PATCH 15/15] Tests for the issue #605 added.

2008-10-17 Thread Fabian Seoane
(sin(1 + sin(1)), 0) > > +def test_leadterm3(): > +assert (y+z+x).leadterm(x) == (y+z, 0) > + > def test_as_leading_term2(): > assert (x*cos(1)*cos(1 + sin(1)) + sin(1 + > sin(1))).as_leading_term(x) == \ > sin(1 + sin(1)) > --

Fwd: [PATCH] Make Rational accept a wider range of types as arguments.

2008-10-21 Thread Fabian Seoane
-- Forwarded message -- From: Fabian Seoane <[EMAIL PROTECTED]> Date: 2008/10/21 Subject: Re: [PATCH] Make Rational accept a wider range of types as arguments. To: sympy-patches@googlegroups.com > > > But then Rational(1.) == Integer(1) > > and that

Fwd: [PATCH] Make Rational accept a wider range of types as arguments.

2008-10-21 Thread Fabian Seoane
(sorry if you receive this twice, my email client got crazy) > > > But then Rational(1.) == Integer(1) > > and that is not only ugly but incorrect ... > > A solution would be to check if int(p) == p. > yeah, that would be a nice solution, but I think that accepting float's as arguments is in

[PATCH] Make Rational accept arguments of type Integer.

2008-10-21 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> --- sympy/core/numbers.py| 12 +--- sympy/core/tests/test_numbers.py | 13 + 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/sympy/core/numbers.py b/sympy/core/numbers.py index 000d326..da2b833

Re: [PATCH] Make Rational accept arguments of type Integer.

2008-10-22 Thread Fabian Seoane
gt;> Ondrej > > I don't see anything objectionable. > > Fredrik > > > Fabian Seoane http://fseoane.net --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "sy

[PATCH] Make the constructor of Derivative treat correctly instances of Derivative.

2008-10-23 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> Two XFAIL test now pass. This also fixes #979 and #1124. --- sympy/core/function.py|2 +- sympy/core/tests/test_basic.py|1 - sympy/core/tests/test_functions.py|3 +++ sympy/simplify/tests/test_simplify.py

Re: [PATCH] Make the constructor of Derivative treat correctly instances of Derivative.

2008-10-24 Thread Fabian Seoane
pushed in. Thanks, On Oct 24, 2008, at 6:22 PM, Ondrej Certik wrote: > > Very cool, +1 from me. > > Ondrej > > On Thu, Oct 23, 2008 at 1:57 PM, <[EMAIL PROTECTED]> wrote: >> >> From: Fabian Seoane <[EMAIL PROTECTED]> >> >> T

Re: [PATCH 06/10] Integer.__new__(): use isinstance instead of is_Integer.

2008-11-10 Thread Fabian Seoane
2008/11/10, Ondrej Certik <[EMAIL PROTECTED]>: > > > On Mon, Nov 10, 2008 at 2:09 AM, Brian Granger <[EMAIL PROTECTED]> > wrote: > > > > ...please be patient with me - I am sympy newbie... > > No, I am glad you are asking, so that we can discuss the design. :) > > > > >> The general idea is that al

Re: [PATCH 10/10] ModularInteger(): assert integer input

2008-11-10 Thread Fabian Seoane
self.value = value % self.modulus > > def __repr__(self): > -- > 1.5.6.5 > > > > Fabian Seoane http://fseoane.net --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups &

Re: patch review

2008-11-12 Thread Fabian Seoane
welcomed back anytime! >> >> He told me he will reply in the evening, as he is busy at the moment. > > Until this issue is resolved (either way), I reverted the patch: > > http://hg.sympy.org/sympy/rev/0fd0ff3467d3 > > Let's first discuss this, reach consensus and then pu

Re: [PATCH] sinh(asinh(x)) and similar implemented (#1037)

2008-11-14 Thread Fabian Seoane
sert cosh(asinh(x)) == sqrt(1+x**2) > +assert cosh(acosh(x)) == x > assert cosh(atanh(x)) == 1/sqrt(1-x**2) > > +assert tanh(asinh(x)) == x/sqrt(1+x**2) > +assert tanh(acosh(x)) == sqrt(x-1) * sqrt(x+1) / x > +assert tanh(atanh(x)) == x > + > def test_

Re: [PATCH] Updates ccode printing module according to new printer paradigm.

2008-11-19 Thread Fabian Seoane
[EMAIL PROTECTED] escribió: > From: Andy R. Terrel <[EMAIL PROTECTED]> > > --- > sympy/printing/ccode.py|1 + > sympy/printing/tests/test_ccode.py |8 +++- > 2 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/sympy/printing/ccode.py b/sympy/printing/ccode.

Re: [PATCH] Updates ccode printing module according to new printer paradigm.

2008-11-20 Thread Fabian Seoane
2008/11/20 Andy Ray Terrel <[EMAIL PROTECTED]> > > On Thu, Nov 20, 2008 at 12:46 AM, Fabian Seoane <[EMAIL PROTECTED]> > wrote: > > > > [EMAIL PROTECTED] escribió: > >> From: Andy R. Terrel <[EMAIL PROTECTED]> > >> > >> --- >

[PATCH] Don't track vim backup files

2008-11-22 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index fd93e5e..b0a0fb2 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,4 @@ build/ doc/_build/ doc/sphinx/ +*~ -- 1

Re: [PATCH] Don't track vim backup files

2008-11-22 Thread Fabian Seoane
Ondrej, could you pull from my proposed branch ( http://fseoane.net/cgi-bin/gitweb.cgi?p=sympy.git;a=shortlog;h=refs/heads/proposed) if you find ok ? 2008/11/22 <[EMAIL PROTECTED]> > From: Fabian Seoane <[EMAIL PROTECTED]> > > --- > .gitignore |1 + > 1 files

Re: Don't track vim backup files

2008-11-23 Thread Fabian Seoane
anch, thanks > > Vinzent > > On Nov 22, 9:49 pm, [EMAIL PROTECTED] wrote: >> From: Fabian Seoane <[EMAIL PROTECTED]> >> >> --- >> .gitignore |1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/.gitignore b/.gitignore

Re: [PATCH] move all py.test imports into try/except clause (#1210)

2008-11-23 Thread Fabian Seoane
Ondrej Certik wrote: > This is important, because the new py.test breaks sympy (import py works, but > not the later imports). This patch should fix it. > --- > sympy/utilities/pytest.py |9 - > 1 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sympy/utilities/pytest.

Re: [PATCH] Reimplemented factoring utilities over Z[x]

2008-11-23 Thread Fabian Seoane
Nice work! Couple of questions: what does zzx stand for? Wouldn't this be the case (lot's of functions with the same prefix) where you should use a class and the methods should be static methods (instead of using prefixes all the time)? Mateusz Paprocki wrote: > This patch reimplements univar

[PATCH] Support for more types of expressions in solve

2008-11-23 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> For this, a guess_solve_strategy method was added Before of this, solve() parsed the expression searching for a polynomial and if this parse failed, it just called tsolve. Now the expression is parsed, and while parsing the best algorithm is select

[PATCH] Avoid one nesting by reordering a if/else block. This does not change the behaviour of the code, it just makes it more readable

2008-11-23 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> Also fixes a docstring that caused test_doc to fail and some formatting typos where corrected --- sympy/solvers/solvers.py| 167 ++- sympy/solvers/tests/test_solvers.py | 27 +++--- 2 files chang

[PATCH] Support for more types of expressions in solve

2008-11-23 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> For this, a guess_solve_strategy method was added Before of this, solve() parsed the expression searching for a polynomial and if this parse failed, it just called tsolve. Now the expression is parsed, and while parsing the best algorithm is select

[PATCH] Avoid one nesting by reordering a if/else block. This does not change the behaviour of the code, it just makes it more readable

2008-11-23 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> --- sympy/solvers/solvers.py | 161 +++--- 1 files changed, 80 insertions(+), 81 deletions(-) diff --git a/sympy/solvers/solvers.py b/sympy/solvers/solvers.py index 6a9daf4..0c2bff1 100644 --- a/sympy/s

Re: [PATCH] Avoid one nesting by reordering a if/else block. This does not change the behaviour of the code, it just makes it more readable

2008-11-23 Thread Fabian Seoane
[EMAIL PROTECTED] wrote: > From: Fabian Seoane <[EMAIL PROTECTED]> > > Also fixes a docstring that caused test_doc to fail and some formatting typos > where corrected > --- > sympy/solvers/solvers.py| 167 > ++-

Re: [PATCH] Reimplemented factoring utilities over Z[x]

2008-11-24 Thread Fabian Seoane
Fredrik Johansson wrote: > On Mon, Nov 24, 2008 at 8:47 AM, Mateusz Paprocki <[EMAIL PROTECTED]> wrote: >> On Sun, Nov 23, 2008 at 09:27:05PM +0100, Fabian Seoane wrote: >> The problem with factorization code is that it requires a lot of >> CPU resources, so spending

Re: [PATCH] Support for more types of expressions in solve

2008-11-24 Thread Fabian Seoane
Ondrej Certik wrote: > On Mon, Nov 24, 2008 at 1:35 AM, <[EMAIL PROTECTED]> wrote: >> From: Fabian Seoane <[EMAIL PROTECTED]> >> >> For this, a guess_solve_strategy method was added >> >> Before of this, solve() parsed the expression searching for

[PATCH] Implement debug framework.

2008-11-24 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> For now this is just a variable sympy.SYMPY_DEBUG that has values True/False. Values for this are set using the environment variable SYMPY_DEBUG --- doc/src/guide.txt |9 + sympy/__init__.py |3 +++ 2 files changed, 12 insertions

Re: [PATCH] move all py.test imports into try/except clause (#1210)

2008-11-25 Thread Fabian Seoane
I attach a reworked patch with my comments plus a small fix that let's you run python setup.py test even if you don't have pylib installed. 2008/11/23 Fabian Seoane <[EMAIL PROTECTED]> > Ondrej Certik wrote: > >> This is important, because the new py.test breaks sy

[PATCH] define a variable PYTHON in the doc's Makefile that let's you customize the default python interpreter

2008-11-26 Thread fabian . seoane
From: Fabian Seoane <[EMAIL PROTECTED]> useful if you have several python interpreters, but docutils not installed in all interpreters --- doc/Makefile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/doc/Makefile b/doc/Makefile index d1978b0..37aaae3 100644 ---

Re: Finally removed old sympy.polynomials module

2008-11-26 Thread Fabian Seoane
I pused all patches from your branch in today, thanks 2008/11/23 Ondrej Certik <[EMAIL PROTECTED]> > > On Sun, Nov 23, 2008 at 12:17 PM, Mateusz Paprocki <[EMAIL PROTECTED]> > wrote: > > > > Hi, > > > > the last missing piece - factorization routines for univariate > > and multivariate polynomial

Re: [PATCH] Fix import in statistics.distributions

2008-12-02 Thread Fabian Seoane
+1. I'll push this when you post the test Thanks, On Tue, Dec 2, 2008 at 2:04 AM, Riccardo Gori <[EMAIL PROTECTED]> wrote: > Fixes this: > > In [1]: from sympy.statistics import Normal > > In [2]: d = Normal(0, 1) > > In [3]: d.pdf(x) > ---

Re: [PATCH] Fix import in statistics.distributions

2008-12-03 Thread Fabian Seoane
On Tue, Dec 2, 2008 at 3:00 PM, Ondrej Certik <[EMAIL PROTECTED]> wrote: > > On Tue, Dec 2, 2008 at 2:54 PM, Riccardo Gori <[EMAIL PROTECTED]> > wrote: > > On Tuesday 02 December 2008 09:58:52 Fabian Seoane wrote: > >> +1. I'll push this when you post the

Re: [PATCH] tests for Matrix.eigenvects() robustified

2008-12-28 Thread Fabian Seoane
seems ok to me On Sat, Dec 27, 2008 at 8:57 PM, Ondrej Certik wrote: > > The ordering of the result of eigenvects() was platform dependent due to > hashes. That is ok, but when we test it, we need to make the comparison > platform independent (otherwise it fails in jython), so I introduced a > c

[PATCH] refactor Rational._eval_power

2008-12-30 Thread fabian . seoane
From: Fabian Seoane implemented factoring on negative roots, now (-8)**Rational(1,3) returns 2*(-1)**Rational(1,3). This is important, for example, in solve, so that it doesen't return uneecesarry long roots removed unnecesary nesting, renamed variables b -> base, e -> exp ---

[PATCH] Fix roots_quartic:

2009-01-11 Thread fabian . seoane
From: Fabian Seoane Also implemented some tests, apparently this method was not tested at all (!!) --- sympy/polys/rootfinding.py | 20 +--- sympy/polys/tests/test_polynomial.py | 27 --- 2 files changed, 41 insertions(+), 6 deletions

Re: [PATCH] Fixes the -Qnew bug in guess_solve_strategy tests (#1260)

2009-01-11 Thread Fabian Seoane
+1 On Sun, Jan 11, 2009 at 6:18 PM, Ondrej Certik wrote: > > Signed-off-by: Ondrej Certik > --- > sympy/solvers/tests/test_solvers.py |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sympy/solvers/tests/test_solvers.py > b/sympy/solvers/tests/test_solvers.py > i

Re: [PATCH] Fix roots_quartic:

2009-01-11 Thread Fabian Seoane
On Sun, Jan 11, 2009 at 7:29 PM, Ondrej Certik wrote: > > On Sun, Jan 11, 2009 at 10:13 AM, wrote: > > > > From: Fabian Seoane > > > > Also implemented some tests, apparently this method was not tested > > at all (!!) > > > Thanks! > > S

Re: [PATCH] BUG: Allow Piecewise to be pickled.

2009-01-15 Thread Fabian Seoane
A docstring on __getnewargs__ like """Method used by pickle, protocol 2""" would be useful, since it is not obvious what the use of the method is (i had to google for it) Otherwise +1 On Mon, Jan 12, 2009 at 7:02 AM, Ondrej Certik wrote: > > From: Robert Kern > > --- > sympy/functions/element

[PATCH] Use by default cubics and quartics formula on roots().

2009-01-15 Thread fabian . seoane
From: Fabian Seoane This has been discussed on issue #1158. --- sympy/polys/rootfinding.py | 10 +- sympy/polys/tests/test_polynomial.py |5 +++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/sympy/polys/rootfinding.py b/sympy/polys/rootfinding.py

Re: roots(): set cubics and quartics to True by default

2009-01-15 Thread Fabian Seoane
Same as my patch, but I believe you have to fix some tests. On Thu, Jan 15, 2009 at 3:36 PM, Vinzent Steinberg < vinzent.steinb...@googlemail.com> wrote: > -- > > > > -- Fabian, http://fseoane.net/blog/ --~--~-~--~~~---~--~~ You received this message because y

[PATCH] Use by default cubics and quartics formula on roots().

2009-01-15 Thread fabian . seoane
From: Fabian Seoane Docstring of roots by Vinzent Steinberg. This has been discussed on issue #1158. --- sympy/polys/rootfinding.py | 10 +- sympy/polys/tests/test_polynomial.py |5 +++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/sympy/polys

Re: Use by default cubics and quartics formula on roots().

2009-01-15 Thread Fabian Seoane
On Thu, Jan 15, 2009 at 8:09 PM, Vinzent Steinberg < vinzent.steinb...@googlemail.com> wrote: > > > > On 15 Jan., 13:42, fabian.seo...@gmail.com wrote: > > From: Fabian Seoane > > > > This has been discussed on issue #1158. > > --- > &

Re: Use by default cubics and quartics formula on roots().

2009-01-16 Thread Fabian Seoane
On Fri, Jan 16, 2009 at 8:41 PM, Ondrej Certik wrote: > > On Fri, Jan 16, 2009 at 9:09 AM, Vinzent Steinberg > wrote: > > > > > > On 16 Jan., 00:28, fabian.seo...@gmail.com wrote: > >> From: Fabian Seoane > >> > >> Docstring of roots by Vi

Re: Use by default cubics and quartics formula on roots().

2009-01-16 Thread Fabian Seoane
On Fri, Jan 16, 2009 at 8:41 PM, Ondrej Certik wrote: > > On Fri, Jan 16, 2009 at 9:09 AM, Vinzent Steinberg > wrote: > > > > > > On 16 Jan., 00:28, fabian.seo...@gmail.com wrote: > >> From: Fabian Seoane > >> > >> Docstring of roots by Vi

[PATCH] Calculate rational roots in roots() before calling degree-specific formulas.

2009-01-19 Thread fabian . seoane
From: Fabian Seoane Since no cubics of quartics formula is used in the determination of rational roots and the algorithm is fast, rational roots are first computed for all polynomials. In some cases this also reduces the degree of the polynomial, thus solving polynomials that where before

Fwd: [PATCH] Calculate rational roots in roots() before calling degree-specific formulas.

2009-01-19 Thread Fabian Seoane
Sorry, wront file. This is the good one -- Forwarded message -- From: Fabian Seoane Date: Mon, Jan 19, 2009 at 8:52 PM Subject: Re: [PATCH] Calculate rational roots in roots() before calling degree-specific formulas. To: sympy-patches@googlegroups.com I attach a reworked version

Re: [PATCH] Calculate rational roots in roots() before calling degree-specific formulas.

2009-01-19 Thread Fabian Seoane
gt; i've made some changes > i'll submit another one > ok > do it and ping me > > On Mon, Jan 19, 2009 at 4:40 AM, wrote: > > > > From: Fabian Seoane > > > > Since no cubics of quartics formula is used in the determination of > rational roots

[PATCH] Documentation for the solvers module.

2009-01-23 Thread fabian . seoane
From: Fabian Seoane Some changes where made on dsolve's docstring because the docstring's markup was clashing with sphinx's markup --- doc/src/modules.txt |1 + doc/src/modules/solvers.txt | 32 sympy/solvers/solvers.py| 1

[PATCH] Add docstring to solvers.recurr explaining the structure of the module.

2009-01-23 Thread fabian . seoane
From: Fabian Seoane Text is from Mateusz Paprocki: http://groups.google.com/group/sympy/browse_thread/thread/50d0914d12233b80?hl=en --- sympy/solvers/recurr.py | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/sympy/solvers

[PATCH] Rename canonize to eval

2009-01-23 Thread fabian . seoane
From: Fabian Seoane For backwards compatility, function .canonize was not deleted, but only deprecated (with the deprecated decorator, that prints a deprecation warning). This decorator was added to sympy.utilities.decorator --- doc/src/guide.txt | 10

Re: [PATCH] Add docstring to solvers.recurr explaining the structure of the module.

2009-01-23 Thread Fabian Seoane
pushed in, thanks On Fri, Jan 23, 2009 at 4:14 PM, Ondrej Certik wrote: > > Thanks for adding this in! +1 > > Ondrej > > On Fri, Jan 23, 2009 at 5:17 AM, wrote: > > > > From: Fabian Seoane > > > > Text is from Mateusz Paprocki: > http://group

[PATCH] Add a test for issue #1120, "solve(Eq(cos(x), sin(x)), x) hangs"

2009-01-28 Thread fabian . seoane
From: Fabian Seoane Issue is solved in trunk, but didn't have a test. It was probably solved when we added guess_solve_strategy to solve's routine --- sympy/solvers/tests/test_solvers.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/sympy/sol

[PATCH] Documentation for symplify.collect's internal methods.

2009-01-28 Thread fabian . seoane
From: Fabian Seoane --- sympy/simplify/simplify.py | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/sympy/simplify/simplify.py b/sympy/simplify/simplify.py index ffceb9d..4ccc886 100644 --- a/sympy/simplify/simplify.py +++ b/sympy/simplify/simplify.py

[PATCH] Solve bug in collect.

2009-01-28 Thread fabian . seoane
From: Fabian Seoane The bug caused a wrong result when collect was called with a product as second argument, for example: collect(1+x*(y**2), x*y) Added some test for this also Some doctests were changed because multiple answers where correct: - z*(1 + a) + x**2*y**4*(1 + z) (old

Re: [PATCH] Solve bug in collect.

2009-01-28 Thread Fabian Seoane
On Wed, Jan 28, 2009 at 10:32 PM, Ondrej Certik wrote: > > On Wed, Jan 28, 2009 at 5:23 AM, wrote: > > > > From: Fabian Seoane > > > > The bug caused a wrong result when collect was called with > > a product as second argument, for example: > > >

[PATCH] Solve bug in collect.

2009-01-29 Thread fabian . seoane
From: Fabian Seoane The bug caused a wrong result when collect was called with a product as second argument, for example: collect(1+x*(y**2), x*y) returned 1+(x*y)**2. The problem was that after matching the expression, it failed to build the matched object (lines 653-659 of simplify

Re: [PATCH] Solve bug in collect.

2009-01-29 Thread Fabian Seoane
I sended a reworked patch, please review. I think it also solves some issues related to coeff, like issue 1221 thanks On Thu, Jan 29, 2009 at 1:45 AM, Fabian Seoane wrote: > > > On Wed, Jan 28, 2009 at 10:32 PM, Ondrej Certik wrote: > >> >> On Wed, Jan 28,

Re: [PATCH] Solve bug in collect.

2009-01-30 Thread Fabian Seoane
On Thu, Jan 29, 2009 at 9:10 PM, Ondrej Certik wrote: > > On Thu, Jan 29, 2009 at 7:35 AM, wrote: > > > > From: Fabian Seoane > > > > The bug caused a wrong result when collect was called with > > a product as second argument, for example: > > > &

[PATCH] Solve '.coeff() fails for -x/8 + x*y'

2009-01-30 Thread fabian . seoane
From: Fabian Seoane Basic.coeff now uses collect with argument evaluate=False, which returns a dict, so there is no need to call match any more --- sympy/core/basic.py| 14 -- sympy/core/tests/test_basic.py |3 +++ 2 files changed, 11 insertions(+), 6 deletions

Re: [PATCH] Solve '.coeff() fails for -x/8 + x*y'

2009-01-30 Thread Fabian Seoane
On Fri, Jan 30, 2009 at 10:37 PM, Ondrej Certik wrote: > > This fixes it for me, thanks! +1 > > Ondrej > > On Fri, Jan 30, 2009 at 1:35 PM, wrote: > > > > From: Fabian Seoane > > > > Basic.coeff now uses collect with argument evaluate=False, which

Re: [PATCH] Solve '.coeff() fails for -x/8 + x*y'

2009-01-31 Thread Fabian Seoane
On Sat, Jan 31, 2009 at 12:07 AM, Ondrej Certik wrote: > > > > > This line is wrong, it failed for collect(expr, 2*x), for example. I > attach > > a reworked version > > of this patch that corrects this and adds a test > > Thanks for noticing. The reworked patch is +1. > > Only I suggest to use S

Re: Solve '.coeff() fails for -x/8 + x*y'

2009-02-01 Thread Fabian Seoane
On Sat, Jan 31, 2009 at 11:45 PM, Ondrej Certik wrote: > > On Sat, Jan 31, 2009 at 12:26 PM, Vinzent Steinberg > wrote: > > > > Why do you want to use S(1)? I don't get the point. > > So right now there is in the tests: > > S.One/2 > > while > > S(1)/2 > > seems to me more readable and understan

[PATCH] Add support for printing tuples with the mathml backend

2009-02-03 Thread fabian . seoane
From: Fabian Seoane --- sympy/printing/mathml.py| 20 sympy/printing/tests/test_mathml.py | 14 +- 2 files changed, 33 insertions(+), 1 deletions(-) diff --git a/sympy/printing/mathml.py b/sympy/printing/mathml.py index ec6c88c..ddae019 100644

Re: Geometric Algebra Upgrades

2009-02-05 Thread Fabian Seoane
On Wed, Feb 4, 2009 at 6:47 PM, Alan Bromborsky wrote: > Attached is a patch to upgrade the geometric algebra modules (GA > replaces GAsympy and latex_ex replaces latex_out). In brief: > > 1. GA now includes geometric differentiation (generalize n-dimensional > grad, div, and curl) and curviline

Re: Geometric Algebra Upgrades

2009-02-05 Thread Fabian Seoane
On Thu, Feb 5, 2009 at 2:05 PM, Alan Bromborsky wrote: > > Fabian Seoane wrote: > > > > > > On Wed, Feb 4, 2009 at 6:47 PM, Alan Bromborsky > <mailto:abro...@verizon.net>> wrote: > > > > Attached is a patch to upgrade the geometric algebra m

Re: Geometric Algebra Upgrades

2009-02-05 Thread Fabian Seoane
On Thu, Feb 5, 2009 at 11:39 PM, Ondrej Certik wrote: > > Hi Alan! > > > Certainly much of it is because I have been using LaTeX for at least 25 > > years. However, the rst syntax for tables is especially ugly (maybe > > microsoft invented it) and at least to me gets in the way of getting the >

[PATCH] Do return pretty xml by default in sympy.printing.mathml.mathml as it does not validate.

2009-02-05 Thread fabian . seoane
From: Fabian Seoane If you want pretty xml, use print_mathml instead. --- sympy/printing/mathml.py|7 --- sympy/printing/tests/test_mathml.py |2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/sympy/printing/mathml.py b/sympy/printing/mathml.py index

Re: [PATCH 3/3] license: the year 2009 added to the copyright

2009-02-06 Thread Fabian Seoane
On Fri, Feb 6, 2009 at 5:36 PM, Ondrej Certik wrote: > > --- > LICENSE |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/LICENSE b/LICENSE > index fba8414..c955fdc 100644 > --- a/LICENSE > +++ b/LICENSE > @@ -1,4 +1,4 @@ > -Copyright (c) 2006, 2007, 2008 SymPy Develo

[PATCH] Don't import os globally in the top level module.

2009-02-06 Thread fabian . seoane
From: Fabian Seoane This could represent a security risk if sympy was allowed to run in a 'safe' environment in which sympy was the only module allowed to be imported since you could have access to the os module at sympy.os. Currently django-sympy works this way, althought it is

[PATCH] Solve bug, abs(x**2) was simplifying always, but this is only true

2009-02-09 Thread fabian . seoane
From: Fabian Seoane Added test and docs --- sympy/functions/elementary/complexes.py| 19 --- sympy/functions/elementary/tests/test_complexes.py |6 +- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/sympy/functions/elementary/complexes.py

Re: Solve bug, abs(x**2) was simplifying always, but this is only true

2009-02-19 Thread Fabian Seoane
On Thu, Feb 19, 2009 at 11:19 AM, Vinzent Steinberg < vinzent.steinb...@googlemail.com> wrote: > > > > On 9 Feb., 21:35, fabian.seo...@gmail.com wrote: > > From: Fabian Seoane > > > > Added test and docs > ^^^ Git send-email strip

Re: trigsimp-two-hacks-removed

2009-03-10 Thread Fabian Seoane
Ondrej Certik wrote: > Hi, > > sending a trivial patch to remove hacks from trigsimp. > removing hacks is always good news, but I do not agree that sin(x)**2/cos(x)**2 is a valid answer. By definition, trigsimp will try to return the simplest possible expression, and although 'the simplest p

[PATCH] Documentation for the integrals and functions module.

2009-03-12 Thread Fabian Seoane
I've added a new functions.txt file to document sympy.function module, and also added docstrings to functions that did not have one. However most of the functions documented in the functions.txt file are simply references to the docstrings. Someday this should be expanded with examples and docume

[PATCH] abs(sin(1)) simplifies to sin(1)

2009-03-13 Thread Fabian Seoane
Before of this patch, this calculation returned an AssertionError (see issue #1051). Adopted approach is to not use the assumptions framework for this calculation. This is faster, but also, since we are slowly moving the assumption system out of the core, this will have to be how things are done

Re: [PATCH] abs(sin(1)) simplifies to sin(1)

2009-03-14 Thread Fabian Seoane
Fredrik Johansson wrote: > On Fri, Mar 13, 2009 at 9:53 AM, Fabian Seoane wrote: > >> Before of this patch, this calculation returned an AssertionError >> (see issue #1051). >> > > The new version is worse, IMO. Instead of just asking whether the > argu

Re: [PATCH] abs(sin(1)) simplifies to sin(1)

2009-03-14 Thread Fabian Seoane
Fabian Seoane wrote: > Before of this patch, this calculation returned an AssertionError > (see issue #1051). > > Adopted approach is to not use the assumptions framework for this > calculation. This is faster, but also, since we are slowly moving > the assumption system out

[no subject]

2009-03-16 Thread Fabian Seoane
this introduces my work on the new assumption system. The old assumption is left untouched until we migrate all the code the new assumption system. you can pull from http://fseoane.net/git/sympy.git, branch proposed --~--~-~--~~~---~--~~ You received this message

[PATCH 2/5] implement get_class and get_mod_func in sympy.utilities.source

2009-03-16 Thread Fabian Seoane
Function get_class returns a class from a given string. It makes use of get_mod_func --- sympy/utilities/source.py | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/sympy/utilities/source.py b/sympy/utilities/source.py index 56ca7f7..1470759 100644

[PATCH 3/5] implement backward-chaining for propositional logic in core.facts.

2009-03-16 Thread Fabian Seoane
This is a very naive implementation. It constructs EVERY possible query with propositions from self.defined_facts and tries every one to see if it succeeds. It has unacceptable slow performance. This is implemented just as workaround for the new assumption system, but eventually a complete backwa

[PATCH 1/5] Implement variations in sympy.utilities.iterables

2009-03-16 Thread Fabian Seoane
variations is a routine that calculates all possible variations of size n (with or without repetition) of a given set. --- sympy/utilities/iterables.py| 36 +++ sympy/utilities/tests/test_iterables.py |6 - 2 files changed, 41 insertions(+), 1 del

[PATCH 5/5] documentation for the query module

2009-03-16 Thread Fabian Seoane
--- doc/src/modules.txt |1 + doc/src/modules/query.txt | 85 + 2 files changed, 86 insertions(+), 0 deletions(-) create mode 100644 doc/src/modules/query.txt diff --git a/doc/src/modules.txt b/doc/src/modules.txt index 0232b4d..d13a655 10

Re: Boolean Algebra module

2009-03-16 Thread Fabian Seoane
Hi Akshay! Thanks for the git patch, it really makes reviewing easier :-) It looks good, but seems terribly similar to sympy.core.logic. Did you take a look at that? How does your module compare to this? Thanks, Akshay Srinivasan wrote: > I got git to work, and am happy to send in my patch. T

Re: [PATCH 2/5] implement get_class and get_mod_func in sympy.utilities.source

2009-03-16 Thread Fabian Seoane
Ondrej Certik wrote: > On Mon, Mar 16, 2009 at 8:13 AM, Fabian Seoane wrote: > >> Function get_class returns a class from a given string. It makes use >> of get_mod_func >> --- >> sympy/utilities/source.py | 26 ++ >> 1 files ch

Re: Boolean Algebra module

2009-03-17 Thread Fabian Seoane
Ondrej Certik wrote: > On Mon, Mar 16, 2009 at 9:58 PM, Akshay Srinivasan > wrote: > >> Yes , I agree that it'd better to merge this into sympy.core.logic , >> but I'm concerned about the usability. I'm not sure by how much >> facts.py would have to be changed, if this is done. I'll try mergin

Re: Boolean Algebra module

2009-03-23 Thread Fabian Seoane
Akshay Srinivasan wrote: > Shouldn't it be better to implement the assumptions system with > specialised classes instead of using strings and some make-shift > classes ? A sort of abstraction layer, so to speak. Keeping the layer > itself small will make it easier to implement it in Cython and sho

Re: [PATCH 2/2] Added simple PDE solver for equations with separable variables.

2009-03-23 Thread Fabian Seoane
Added simple PDE solver for equations with separable variables. > --- > diff --git a/sympy/solvers/solvers.py b/sympy/solvers/solvers.py > index 30722c0..fe6713d 100644 > --- a/sympy/solvers/solvers.py > +++ b/sympy/solvers/solvers.py > @@ -14,17 +14,17 @@ > """ > > from sympy.core.sympify imp

Re: Boolean Algebra module

2009-03-24 Thread Fabian Seoane
Vinzent Steinberg wrote: > > On Mar 23, 7:45 pm, Akshay Srinivasan > wrote: > >> On Mar 22, 4:13 pm, Akshay Srinivasan >> wrote: >> >> >>> Shouldn't it be better to implement the assumptions system with >>> specialised classes instead of using strings and some make-shift >>> classes ? A

Re: [PATCH 2/2] curvilinear_coordinates example added

2009-03-24 Thread Fabian Seoane
both patches are +1 Ondrej Certik wrote: > This example calculates all kinds of coordinate transformations and prints > useful information about them. > --- > examples/advanced/curvilinear_coordinates.py | 109 > ++ > examples/all.py |1

Re: trigsimp-two-hacks-removed

2009-03-25 Thread Fabian Seoane
nice patch. +1 Ondrej Certik wrote: > On Tue, Mar 10, 2009 at 2:31 PM, Fabian Seoane wrote: >> Ondrej Certik wrote: >>> Hi, >>> >>> sending a trivial patch to remove hacks from trigsimp. >>> >> removing hacks is always good news, but I do not

Re: [PATCH 3/3] solve( x**Rational(1,2) - 2, x) fixed

2009-03-29 Thread Fabian Seoane
Ondrej Certik wrote: > it used to return [sqrt(2)], but the answer is [4]. There was a bug in the > solver, that noone has noticed so far: it did everything correctly, only at > the > very end it should power the result to "m", and it used to power it to "1/m", > which is wrong. all patches are

Re: [PATCH 1/1] Fixed typo in docstring

2009-03-29 Thread Fabian Seoane
thanks for the patch, it's in. http://git.sympy.org/?p=sympy.git;a=commit;h=2caa23edfc41b2fd2bd30bb6ac59855896deb549 Aaron Meurer wrote: > --- > sympy/simplify/simplify.py |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sympy/simplify/simplify.py b/sympy/simplif

  1   2   >