Re: [PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-29 Thread Øyvind Jensen
I think he meant to put commutative=False, not noncommutative=True. Exactly, I put up another branch fix__lt__2, where this is fixed. It's weird that Symbol will let you create nonexistent assumptions on it: But that can be quite useful: In [4]: r = Symbol('r',something=True) In [5]:

Re: [PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-29 Thread Vinzent Steinberg
2010/3/29 Øyvind Jensen jensen.oyv...@gmail.com: I think he meant to put commutative=False, not noncommutative=True. Exactly, I put up another branch fix__lt__2, where this is fixed. Thanks! I'm +1 for this one. I have only a few minor stylistic remarks: +assert (ab) == Lt(a,b) +

[PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-28 Thread Øyvind Jensen
All comparisons of for non-commutative symbols used to return False. Now an Inequality or StrictInequality is returned instead. Added a test. --- sympy/core/basic.py| 12 +--- sympy/core/tests/test_basic.py |8 2 files changed, 13 insertions(+), 7 deletions(-)

Re: [PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-28 Thread Vinzent Steinberg
2010/3/28 Øyvind Jensen jensen.oyv...@gmail.com All comparisons of for non-commutative symbols used to return False. Now an Inequality or StrictInequality is returned instead. Added a test. --- sympy/core/basic.py| 12 +--- sympy/core/tests/test_basic.py |8

Re: [PATCH] Fix Basic.__lt__() and friends for noncommutative symbols (issue 1878)

2010-03-28 Thread Aaron S. Meurer
On Mar 28, 2010, at 2:50 PM, Vinzent Steinberg wrote: 2010/3/28 Øyvind Jensen jensen.oyv...@gmail.com All comparisons of for non-commutative symbols used to return False. Now an Inequality or StrictInequality is returned instead. Added a test. --- sympy/core/basic.py| 12